From nobody Tue Sep 03 10:27:43 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Wyhdq5cjVz5Mkb1; Tue, 03 Sep 2024 10:27:43 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Wyhdq4D0Rz4tmF; Tue, 3 Sep 2024 10:27:43 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1725359263; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=xGGo2Ky5H8rp0vL2BaWbq77E2uOEelAKDMFdgxaOsn8=; b=sIvys+xySi/WuzaboiXxdRziO08JLvw8a9vMW7ZZ8lDfuMfmbsXyPAt4QBfp14f6MBpmBV 0UBuz/cMZ0xXhnCP0laA6WQT7jL4hrZbzfmd6a4T20AkCA9QS2pVv9IkWxuJuiooQfMT4z 3obRNVmrXF8jsqfpmvtP6OdOTs/T2ZGpqlr4caBcskEYOhubhGgkbOt2OOthG7HP+dxaen EhhKf4BSyauZElYxEhG2t/5DuJ+mcqGuxymYeJ4O3Xbu87LuUVl+t7CA3YZ6z9/zXMJgJ2 7STSvYM+vYLxIiOgcK6OImPQCgJFNGc6flp41FU+mnpLZluxGzMaUGdDpSK+1g== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1725359263; a=rsa-sha256; cv=none; b=lq+dm8lvwB8W92pGeEpR9pIlYG2trRoU6Vg7bUqwORdNBBTxrRvtxc5ZN/6IM/a4S6KWnD Lt4lTshCAKwSfqv7dxh4FRlekcHi7nPEkoE0E6UsqSNW70UcJDhF1tZRH8ULqy0ckyO8PX yTJUNDh35j6sJhzmlw1aOjG+XypMWkq4T52EzFAfoaYSj17vp1PNVQMqPzVx0flnFUAW/W cj0SbLnVoJJcp9yeB7OHg3uui6YBEVEc3cWOODxt54VKD6Q+m/P8DMdhTKhfFHtl+yJfZG 5werf9ce6BkZgE4NSXpA89N6qNgOcZoeZtMki4eZYzJTTf2ipTUewNmGSo5n5w== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1725359263; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=xGGo2Ky5H8rp0vL2BaWbq77E2uOEelAKDMFdgxaOsn8=; b=jMuQbY0xLctZ0rtTkA2mhfUUAjiIfHfXbwroVuY7QYWk6vHWaxy9SHjzoP8UFy12ZYpuPl tCOu2VUDY8+C5bat4mPxNRCAjnI6e1pPg5pih3HQh9d+SXbgCLfD1FbpB2YlBA8xRMxII8 YbtujYSFB3VH1mGVRH1gaF0YImMZ+6vNWa2HsjqQ/obCrtCrCphWjminIRF+buRvbqu5Va oS1QAhWTdN9PVONEpuDayYOvQFACrGIRNyfrnGIt76u3RhKYoghGNqJrEU+B0v4uTMCnGe JbrEpcfWHGgd1AV0AyMPCH5uXMOMNN49t3O8II6TZEN3QMlW1Xrqj4w7+DcPBg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Wyhdq3rGYzcLK; Tue, 3 Sep 2024 10:27:43 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 483ARhkM011413; Tue, 3 Sep 2024 10:27:43 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 483ARhJL011410; Tue, 3 Sep 2024 10:27:43 GMT (envelope-from git) Date: Tue, 3 Sep 2024 10:27:43 GMT Message-Id: <202409031027.483ARhJL011410@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Zhenlei Huang Subject: git: 57cd8f27b727 - main - liquidio(4): Stop checking for failures from malloc/taskqueue_create/buf_ring_alloc(M_WAITOK) List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: zlei X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 57cd8f27b727e7a87312f6f141cfa13807dc81a0 Auto-Submitted: auto-generated The branch main has been updated by zlei: URL: https://cgit.FreeBSD.org/src/commit/?id=57cd8f27b727e7a87312f6f141cfa13807dc81a0 commit 57cd8f27b727e7a87312f6f141cfa13807dc81a0 Author: Zhenlei Huang AuthorDate: 2024-09-03 10:25:38 +0000 Commit: Zhenlei Huang CommitDate: 2024-09-03 10:25:38 +0000 liquidio(4): Stop checking for failures from malloc/taskqueue_create/buf_ring_alloc(M_WAITOK) MFC after: 1 week Differential Revision: https://reviews.freebsd.org/D45853 --- sys/dev/liquidio/base/lio_request_manager.c | 9 --------- sys/dev/liquidio/base/lio_response_manager.c | 4 ---- sys/dev/liquidio/lio_main.c | 4 ---- sys/dev/liquidio/lio_sysctl.c | 3 --- 4 files changed, 20 deletions(-) diff --git a/sys/dev/liquidio/base/lio_request_manager.c b/sys/dev/liquidio/base/lio_request_manager.c index f4eae0c8bf31..95eac12ecf3b 100644 --- a/sys/dev/liquidio/base/lio_request_manager.c +++ b/sys/dev/liquidio/base/lio_request_manager.c @@ -159,11 +159,6 @@ lio_init_instr_queue(struct octeon_device *oct, union octeon_txpciq txpciq, db_tq = &oct->check_db_tq[iq_no]; db_tq->tq = taskqueue_create("lio_check_db_timeout", M_WAITOK, taskqueue_thread_enqueue, &db_tq->tq); - if (db_tq->tq == NULL) { - lio_dev_err(oct, "check db wq create failed for iq %d\n", - iq_no); - return (1); - } TIMEOUT_TASK_INIT(db_tq->tq, &db_tq->work, 0, lio_check_db_timeout, (void *)db_tq); @@ -179,10 +174,6 @@ lio_init_instr_queue(struct octeon_device *oct, union octeon_txpciq txpciq, oct->instr_queue[iq_no]->br = buf_ring_alloc(LIO_BR_SIZE, M_DEVBUF, M_WAITOK, &oct->instr_queue[iq_no]->enq_lock); - if (oct->instr_queue[iq_no]->br == NULL) { - lio_dev_err(oct, "Critical Failure setting up buf ring\n"); - return (1); - } return (0); } diff --git a/sys/dev/liquidio/base/lio_response_manager.c b/sys/dev/liquidio/base/lio_response_manager.c index 12a3ad60521e..ac5fc6229885 100644 --- a/sys/dev/liquidio/base/lio_response_manager.c +++ b/sys/dev/liquidio/base/lio_response_manager.c @@ -59,10 +59,6 @@ lio_setup_response_list(struct octeon_device *oct) ctq = &oct->dma_comp_tq; ctq->tq = taskqueue_create("lio_dma_comp", M_WAITOK, taskqueue_thread_enqueue, &ctq->tq); - if (ctq->tq == NULL) { - lio_dev_err(oct, "failed to create wq thread\n"); - return (-ENOMEM); - } TIMEOUT_TASK_INIT(ctq->tq, &ctq->work, 0, lio_poll_req_completion, (void *)ctq); diff --git a/sys/dev/liquidio/lio_main.c b/sys/dev/liquidio/lio_main.c index 7104ff07674f..3c73a6b10eed 100644 --- a/sys/dev/liquidio/lio_main.c +++ b/sys/dev/liquidio/lio_main.c @@ -1854,10 +1854,6 @@ lio_setup_rx_oom_poll_fn(if_t ifp) rx_status_tq->tq = taskqueue_create("lio_rx_oom_status", M_WAITOK, taskqueue_thread_enqueue, &rx_status_tq->tq); - if (rx_status_tq->tq == NULL) { - lio_dev_err(oct, "unable to create lio rx oom status tq\n"); - return (-1); - } TIMEOUT_TASK_INIT(rx_status_tq->tq, &rx_status_tq->work, 0, lio_poll_check_rx_oom_status, (void *)rx_status_tq); diff --git a/sys/dev/liquidio/lio_sysctl.c b/sys/dev/liquidio/lio_sysctl.c index 729f4d432274..61a7e96098c8 100644 --- a/sys/dev/liquidio/lio_sysctl.c +++ b/sys/dev/liquidio/lio_sysctl.c @@ -744,9 +744,6 @@ lio_get_regs(SYSCTL_HANDLER_ARGS) regbuf = malloc(sizeof(char) * LIO_REGDUMP_LEN_XXXX, M_DEVBUF, M_WAITOK | M_ZERO); - if (regbuf == NULL) - return (error); - switch (oct->chip_id) { case LIO_CN23XX_PF_VID: len += lio_cn23xx_pf_read_csr_reg(regbuf, oct);