From nobody Sun Sep 01 13:28:04 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4WxXkr31blz5VCtr; Sun, 01 Sep 2024 13:28:04 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4WxXkr1xr1z4KfK; Sun, 1 Sep 2024 13:28:04 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1725197284; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=vRDkzKruvAECBq+K31zetDerIjtjHDcUSn6FBxcg8aQ=; b=qHsOMMV/r6sGPprBzojIjk0pVV2ZIEFvOzgomyPmZLyeOWwQdeZDh0Vhf4uJm8XnNUxwxe pm73ln5PrAojwg+nweiVUZZBnpQwOdYQBjf6Yge9xzy71wdri0cNzI/pDsNeclBEgwZhzY bh2ORQuKW/BQI5XoeK1D75UB7ahpYJ9t78HTJW9qKLzZVG3be0fHWZxUSoF7+VOO42vxu3 PXiuMocbGmi+cQOS15kf6LBg3iD1Tee7c9Trp/1cPo22BmRE6IRQL5g1xpDou48SOoD0TJ xqx8s6u4NUHhoMUVU5IQrs8ZaQ7Iai34K3rME7Qc4X3r7WZEkHV+sxKCrT45jw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1725197284; a=rsa-sha256; cv=none; b=qUpRFKKoUKwcLWf4fV1UUEzecCX6wnlgeQxarox59v3IoNoto6HhNclxK4FG3BTuDmYJLu pft8rg+A/UmYe+cMxJr1xcGN8rn5CRusPHncs6qc/ZdiedhT8M+GZvLAGRO4hIj4sWNuiF 36/lQ4G0LfRcOTtETb3BIrcuo9kdOLQXMuarV9UHeSHAJK7BOg50A7VOO1CK2YtMB5ZbYR 8b3TWIXBoHSCjTJxtD3QmPoCGjPyA+i4CxqZ4bBYCGbpbDSH6rPKWo002W6MhzcrbflPFH Yh0VKxbXI/Iue0GljOGXxxQh1d/eIaYUe0vb0j+xPjqbIbSdgUwabZTzodbcQA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1725197284; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=vRDkzKruvAECBq+K31zetDerIjtjHDcUSn6FBxcg8aQ=; b=GShgHKdH/9lb3yzbkbFXx4Uc8Nx3sEq64HdrzbdC2t1+/AR4OBmO5Nx6A/iNIkslHD9698 dwMZYX26oRrYon+QUFhsuI+qByBqebeU7B2VZJMcqD4G+ZPfPc09Mc7onZi4AhdOSvl5Lr ywtr5StSnj2ADY0bOMUIuhN5iDodR+FwnmHMjeAuDlHX87X1QPknceLOebWQUbB3yyjyOY y5V76FnLFVR8UuaLUbiWSoIY5UvaE8sccvD3+ujNgx9zYUYPhCgiWO21wuGLaUS8fJwFnm G+nWYuBBOYABT056GQwlHW3qEpASe7XIKFSFi9Rn+EziUt2HIY9bLwpajyHouQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4WxXkr1XdDzVwJ; Sun, 1 Sep 2024 13:28:04 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 481DS4rS030828; Sun, 1 Sep 2024 13:28:04 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 481DS4RW030825; Sun, 1 Sep 2024 13:28:04 GMT (envelope-from git) Date: Sun, 1 Sep 2024 13:28:04 GMT Message-Id: <202409011328.481DS4RW030825@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: "Bjoern A. Zeeb" Subject: git: 1847e63d63f4 - main - LinuxKPI: add no_printk List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: bz X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 1847e63d63f440cfcb2f4ee2c2ee8990f0272d88 Auto-Submitted: auto-generated The branch main has been updated by bz: URL: https://cgit.FreeBSD.org/src/commit/?id=1847e63d63f440cfcb2f4ee2c2ee8990f0272d88 commit 1847e63d63f440cfcb2f4ee2c2ee8990f0272d88 Author: Bjoern A. Zeeb AuthorDate: 2024-08-27 21:12:08 +0000 Commit: Bjoern A. Zeeb CommitDate: 2024-08-31 21:36:01 +0000 LinuxKPI: add no_printk Add a version of no_printk(), which seems to be there to have format string checking while never calling the printk. It seems a very weird thing and it needs a return code and for some reason my initial while (0) { } version hadn't worked while porting over new code but could have been further downstream format string problems. if (0) seems to do the job though I would have expected that to more likely simply get optimised out without any futher format checking. Sponsored by: The FreeBSD Foundation MFC after: 3 days Reviewed by: emaste Differential Revision: https://reviews.freebsd.org/D46463 --- sys/compat/linuxkpi/common/include/linux/printk.h | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/sys/compat/linuxkpi/common/include/linux/printk.h b/sys/compat/linuxkpi/common/include/linux/printk.h index 933d5aa6f94a..3840a6e5fb8a 100644 --- a/sys/compat/linuxkpi/common/include/linux/printk.h +++ b/sys/compat/linuxkpi/common/include/linux/printk.h @@ -125,4 +125,11 @@ print_hex_dump_bytes(const char *prefix_str, const int prefix_type, #define pr_info_ratelimited(fmt, ...) \ printk_ratelimited(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__) +#define no_printk(fmt, ...) \ +({ \ + if (0) \ + printk(pr_fmt(fmt), ##__VA_ARGS__); \ + 0; \ +}) + #endif /* _LINUXKPI_LINUX_PRINTK_H_ */