From nobody Thu Oct 31 16:38:32 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4XfV6x02q0z5c0Rv; Thu, 31 Oct 2024 16:38:33 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4XfV6w6Ld7z4hGv; Thu, 31 Oct 2024 16:38:32 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1730392712; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=SdPAFb2eyIDKtuktErwhrjuMGvWRk3S7Fxl/T0018J8=; b=PiWXz1wnFdNbuSyba399ZfVUL0mEvYBH21GSIipSG4Ja/n9gml1B5/VnDuESGsCP6uVZJf l7JXOWbbgdXYTad0AnvPoIRW9iO2GiGZqu6UojL36dxiXApWxnKeQzmGrKiLkO78K8HZ3o 9wR2mC5gWC6QQ1u/ifl/NiWDOmfwivZctt355oAAwfgvhEdKZJdjXKY2YWRVHU96c9Sw+6 ODtwvXF6NLUdTgMnt0tAvaYM9Hcs3WvFVsOqZwGGCAhnG0vy5/GYT6ga2H4Lmb4p2l7RGU J4au4tVCP+GSmTUztsahofoKBwPWXlAEhGZQXQigosOSGsmLm+gAC4xDh11RVQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1730392712; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=SdPAFb2eyIDKtuktErwhrjuMGvWRk3S7Fxl/T0018J8=; b=NPnDWIDbUjmX83WWajUxOfUwNm6Kai1cJdSCXxXtMRc8ooOui2D3vUqHkAwkAQjSnMZw5Y HbNXurSlwXYRhwEjFqTNtWctdVXJvSaTQclc9s5+Q+df7D0L/wnoZflr9e3P3b0l2Ca9SW xegslebF7dLwE49+vfTOORVwkALknpXmUkbjFVKughOnWINQQ2MfReIyzXW25QSrNHi+8S kBXK+2YIk3rqcfdq0zh42S7z0KWaCstvO+JH19AOnzFC29/g7fIqBvdm/oIdfImsQTJgfi Zrm3XUj28jtr7OpzQKBb/Itm/S29lruzi3bQCIfdDM5lmzAYwXKRjB3JvIHwdw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1730392712; a=rsa-sha256; cv=none; b=sJqhvUloZ+rznEeXM8O8GtRtVqgByYR8P0+S/lz5QmJ1uGN2bJIX7j8TzaxJez3G4O7N7p Oc3QO4grACakyfIZ6pIUYPYruKxQgtQQ4bI3uvy7Gd7xDiWRqL1Gh3AgAwG4hN59Y4dZyw jtYw+z26WVALEAGAtHqO7bzbir3K5BrLpfwwL76TRx0qMVqmmt6izQ1/dicsnHKSZhoBsv QT/NhSgnW+eVpX5/FekJuJr67CzxtKmLdw76HSOBS6bGRxMb8q+fF+15tkXaEPAdky2yxL W075SpymwgKHcWZPMcaGFnWWMc26IMSEA28/9oFyC5YJ9VZTrMsUf19qrXAlvA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4XfV6w5rszzjch; Thu, 31 Oct 2024 16:38:32 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 49VGcWqk034046; Thu, 31 Oct 2024 16:38:32 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 49VGcWWZ034043; Thu, 31 Oct 2024 16:38:32 GMT (envelope-from git) Date: Thu, 31 Oct 2024 16:38:32 GMT Message-Id: <202410311638.49VGcWWZ034043@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Michael Tuexen Subject: git: 822e06011ed9 - stable/13 - al_eth: improve TCP LRO List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: tuexen X-Git-Repository: src X-Git-Refname: refs/heads/stable/13 X-Git-Reftype: branch X-Git-Commit: 822e06011ed997442a98b9932753bec4697363d1 Auto-Submitted: auto-generated The branch stable/13 has been updated by tuexen: URL: https://cgit.FreeBSD.org/src/commit/?id=822e06011ed997442a98b9932753bec4697363d1 commit 822e06011ed997442a98b9932753bec4697363d1 Author: Michael Tuexen AuthorDate: 2024-09-05 15:35:40 +0000 Commit: Michael Tuexen CommitDate: 2024-10-31 16:38:11 +0000 al_eth: improve TCP LRO Use the appropriate function to flush correctly all entries. The old code does not remove the element from the hash table, only from the active queue. Reviewed by: Peter Lei, rscheff Sponsored by: Netflix, Inc. Differential Revision: https://reviews.freebsd.org/D46434 (cherry picked from commit 0b45d36510d8c629fcc49805bc64e5893f4ba63c) --- sys/dev/al_eth/al_eth.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/sys/dev/al_eth/al_eth.c b/sys/dev/al_eth/al_eth.c index 409769b5ee5f..afdf4a160917 100644 --- a/sys/dev/al_eth/al_eth.c +++ b/sys/dev/al_eth/al_eth.c @@ -1585,7 +1585,6 @@ al_eth_rx_recv_work(void *arg, int pending) { struct al_eth_ring *rx_ring = arg; struct mbuf *mbuf; - struct lro_entry *queued; unsigned int qid = rx_ring->ring_id; struct al_eth_pkt *hal_pkt = &rx_ring->hal_pkt; uint16_t next_to_clean = rx_ring->next_to_clean; @@ -1676,10 +1675,7 @@ al_eth_rx_recv_work(void *arg, int pending) "%s: not filling rx queue %d\n", __func__, qid); } - while (((queued = LIST_FIRST(&rx_ring->lro.lro_active)) != NULL)) { - LIST_REMOVE(queued, next); - tcp_lro_flush(&rx_ring->lro, queued); - } + tcp_lro_flush_all(&rx_ring->lro); if (napi != 0) { rx_ring->enqueue_is_running = 0;