From nobody Thu Oct 31 16:37:56 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4XfV6F1R2qz5c0tg; Thu, 31 Oct 2024 16:37:57 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4XfV6F0t5Nz4hCm; Thu, 31 Oct 2024 16:37:57 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1730392677; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=ruWu/URPa1wHTnl/cw1PZQ0VptPpuSbEM9eLg6Y9cC4=; b=d1FlpmrYh2LCjVIWpIjMcIkLMDjjZJB5Mq0+zgP9jW5RjBJio/pOqvCKqe9BeLDl6xXuGk 4aQiX7ZPOqAJSHGkWKb32+S7MpOdB3fumvb5Fvh428MMVwcYdK4UrOyrVVw9SzkRmeH3hQ RRUfx+YXT6+mEJVjeL5LqQEVLOplXrnhSo+gIzeZSRw0XgGNuIUezNYJYn4d9utTJaq7OW N2UlYlnHNFkWtdxu0AVAXunHji00BwDEACRok/DDq/nA8GJZl3hlPwf9xBpKDr65vkbJhE XOd12YFAFO5BmSHSRaWbZ6+EucuXJrKD5WMO0KpjAo/RL7q9Csjb/mt6cKAQIg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1730392677; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=ruWu/URPa1wHTnl/cw1PZQ0VptPpuSbEM9eLg6Y9cC4=; b=E3VOIlp0cnZqFdDQGz6qPKYVFRne+gqweJD2YBX4xH7o8q1yKtG1fEWPaQw5P8hBze6o2m QCw5NjwAtw0SmGJ+7M+rn2zup1b638EhLVHP5gzznUj2mXr63MInehgMpZMwkpsGaeKu4T 0U/gkHRp5/dCgRoDA0zjwwGryjRNYQRvlC+Pv80/Oic7MKfgp5RE8ZmSCFQhKUPE9G2z3p cd2QsvjZeJNNV1i1PqHke+9v9kbaoQ9GVP+K2Z23/gaVp3fejh8q99Ul4C9jA9mmXkAAUM Q6VL2YhXSwnDUlRxvyeWEh6fmPU5Z9ej0NkmkXCa2trwy/nhgQ9+rvMVh5VRYw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1730392677; a=rsa-sha256; cv=none; b=r4j3178YqAAQMWgc8wdT7CICdLPq5kBjqwt3h9edPx1QuwAeuDI1NNtVGNCODQaj9v7Boy rGeAmHFVLN0CHjuarDtZmP9Wj/Hm5LaHXlkofHflQ1X5bRgCsYHTT3yTwBr5XejBmEUdja Y+uoWnfVdRcGgwo3NXVXbSgqDx/laBmNZZOCQkjL0wMM06Nqr65NelOQycxGI5GSLQUax/ 2ZeUdImxR3UsPF9P2M3NOZIXumQoLqCuOrVi4FmOQNDtLiPd9hIeR2g30KH5S81CNsHSqI EfUdOzMKYQk8CwA0nJYaSeKDbIj7/ljHQFI58G2rBix6raMAORzrevdz+BqGdQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4XfV6D6H0PzkWN; Thu, 31 Oct 2024 16:37:56 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 49VGbujN033737; Thu, 31 Oct 2024 16:37:56 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 49VGbuof033734; Thu, 31 Oct 2024 16:37:56 GMT (envelope-from git) Date: Thu, 31 Oct 2024 16:37:56 GMT Message-Id: <202410311637.49VGbuof033734@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Michael Tuexen Subject: git: b245bcc1460e - stable/13 - neta: improve TCP LRO List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: tuexen X-Git-Repository: src X-Git-Refname: refs/heads/stable/13 X-Git-Reftype: branch X-Git-Commit: b245bcc1460ef5ec0b7e97abd45afdb57c4d5bfc Auto-Submitted: auto-generated The branch stable/13 has been updated by tuexen: URL: https://cgit.FreeBSD.org/src/commit/?id=b245bcc1460ef5ec0b7e97abd45afdb57c4d5bfc commit b245bcc1460ef5ec0b7e97abd45afdb57c4d5bfc Author: Michael Tuexen AuthorDate: 2024-09-05 15:31:31 +0000 Commit: Michael Tuexen CommitDate: 2024-10-31 16:37:34 +0000 neta: improve TCP LRO Use the appropriate function to flush correctly all entries. The old code does not remove the element from the hash table, only from the active queue. Reviewed by: Peter Lei, rscheff Sponsored by: Netflix, Inc. Differential Revision: https://reviews.freebsd.org/D46433 (cherry picked from commit 5203dcce2527fd235648e2b855a13f62247eb2de) --- sys/dev/neta/if_mvneta.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/sys/dev/neta/if_mvneta.c b/sys/dev/neta/if_mvneta.c index fa5b9a38ac73..af0d1add0e1a 100644 --- a/sys/dev/neta/if_mvneta.c +++ b/sys/dev/neta/if_mvneta.c @@ -3018,8 +3018,6 @@ mvneta_rx_queue(struct mvneta_softc *sc, int q, int npkt) struct mvneta_rx_desc *r; struct mvneta_buf *rxbuf; struct mbuf *m; - struct lro_ctrl *lro; - struct lro_entry *queued; void *pktbuf; int i, pktlen, processed, ndma; @@ -3133,11 +3131,7 @@ rx_lro: /* * Flush any outstanding LRO work */ - lro = &rx->lro; - while (__predict_false((queued = LIST_FIRST(&lro->lro_active)) != NULL)) { - LIST_REMOVE(LIST_FIRST((&lro->lro_active)), next); - tcp_lro_flush(lro, queued); - } + tcp_lro_flush_all(&rx->lro); } STATIC void