git: 406d75a5816e - stable/14 - MAC: improve consistency in error handling

The branch stable/14 has been updated by tuexen:

URL: https://cgit.FreeBSD.org/src/commit/?id=406d75a5816eb45bc16197b0eff9360461541ad7

commit 406d75a5816eb45bc16197b0eff9360461541ad7
Author:     Michael Tuexen <tuexen@FreeBSD.org>
AuthorDate: 2024-09-26 06:02:06 +0000
Commit:     Michael Tuexen <tuexen@FreeBSD.org>
CommitDate: 2024-10-31 11:24:34 +0000

    MAC: improve consistency in error handling
    
    Whenever mac_syncache_init() returns an error, ensure that
    *label = NULL. This simplifies the error handling by the caller.
    
    Reviewed by:            rscheff
    Sponsored by:           Netflix, Inc.
    Differential Revision:  https://reviews.freebsd.org/D46701
    
    (cherry picked from commit 3f2792166aeed4baf07d351bcb12a9d196c443eb)
---
 sys/security/mac/mac_inet.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/sys/security/mac/mac_inet.c b/sys/security/mac/mac_inet.c
index 29a355071065..9770fa840f95 100644
--- a/sys/security/mac/mac_inet.c
+++ b/sys/security/mac/mac_inet.c
@@ -485,6 +485,7 @@ mac_syncache_init(struct label **label)
 			MAC_POLICY_PERFORM_NOSLEEP(syncache_destroy_label,
 			    *label);
 			mac_labelzone_free(*label);
+			*label = NULL;
 		}
 		return (error);
 	} else