From nobody Thu Oct 31 13:40:25 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4XfQ9P5Hb5z5bjFt; Thu, 31 Oct 2024 13:40:25 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4XfQ9P4kSqz4s7M; Thu, 31 Oct 2024 13:40:25 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1730382025; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=oIxoG9nLUC3unN+GGMEZY6w0QVuFqNMYZ/4/kwybXu0=; b=Fp4OysvN7jzEZHoGivLE4Fw69id1wWhStyET0HBUHYqZ7nhjAckjiD8GVmRaRd9TRbc6If wOJqYdfWeKQhlilWngxq8j+MMhRygoVVeW5cto3aBNAvF4KY2RAg3yUSsCvY3g5x1f6+kb goFPwtyR5kZtIXeNOdXXZHx1Vzt4T/PVjlaFmHa8mkluGsmTjaRfA1GwzggI4bC+sncELl 7uxWLO+/qAg1dABl++cFAPBrP/CGY6h04qRLFIA5aC72X9+uV33XUOdK+ZJ7gYe7YtCojr x0ZuehI2dIqk4HLDG979Jz3d+KU06VO3VpWDefXTa5kg4vadmu8QIaSFub7v9w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1730382025; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=oIxoG9nLUC3unN+GGMEZY6w0QVuFqNMYZ/4/kwybXu0=; b=N3gl2yGp5TyzuQU/eO+sGTGMuWLn2td2Q358cLz5mELR+J7PgVCNFyS/A0ILOEqQzzib4R C5c7oHPNKUzTot+3JdMyhNWSecBYWolcJqPcpx34fMkcW9JJFyxfY5ZWNuut+7HjYYcYyr esAWddDOHlhrmEQW0KhTbhq9FOV0flN8ELPmLZ7gL+6PlITQduQo7/dht30F7j/D1Guk0H SIAqbeJvbI9dDxjkeTYVMLL1LrCtEfrFRhgjemR7XjMcDExKZ+4jBAMlmos8WkESv84pQ6 WmWwG74cn2fhT2+RPRqsmOZMlIyS19eauHKWycKmw3k5dF3KFvWbWBjPSDrz3g== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1730382025; a=rsa-sha256; cv=none; b=TndFptNhIlvPdggkAKJp+4MerRrOL/TvBijh7oHWlmSctjUtwzY8DuFPe4GXIRtTUTDS6J 3GVcbeKYN6JS0FXkEdCFJNWKr0WyMiEktgcf14KR1PE4/m10Q3MB8fqkW6rqYAJmlH9xwj 4WrHL3c/tb0bzc4ahMVpPT37inMihHWgBnn0X20Budf4zM9tu03Zd+3YuY/DYpV/dTYBWh JMxT/uwcOesGFIOBl4pq8CsJ/PhBNQ7t6F+mJBnrMyDqlfuLkLOwPjbyVYmjQEM3lrxLDR NEzG1jVszhAG/diAboElwk8n8FiZwzPp9RUqC0e6qd/7ENXEyefS5er+kEdssw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4XfQ9P4Bl7zddH; Thu, 31 Oct 2024 13:40:25 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 49VDeP9O001766; Thu, 31 Oct 2024 13:40:25 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 49VDePxm001763; Thu, 31 Oct 2024 13:40:25 GMT (envelope-from git) Date: Thu, 31 Oct 2024 13:40:25 GMT Message-Id: <202410311340.49VDePxm001763@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Michael Tuexen Subject: git: c87c8fda44ba - stable/14 - neta: improve TCP LRO List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: tuexen X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: c87c8fda44ba507a4ac373bf2998e755ab2dd8c9 Auto-Submitted: auto-generated The branch stable/14 has been updated by tuexen: URL: https://cgit.FreeBSD.org/src/commit/?id=c87c8fda44ba507a4ac373bf2998e755ab2dd8c9 commit c87c8fda44ba507a4ac373bf2998e755ab2dd8c9 Author: Michael Tuexen AuthorDate: 2024-09-05 15:31:31 +0000 Commit: Michael Tuexen CommitDate: 2024-10-31 11:18:52 +0000 neta: improve TCP LRO Use the appropriate function to flush correctly all entries. The old code does not remove the element from the hash table, only from the active queue. Reviewed by: Peter Lei, rscheff Sponsored by: Netflix, Inc. Differential Revision: https://reviews.freebsd.org/D46433 (cherry picked from commit 5203dcce2527fd235648e2b855a13f62247eb2de) --- sys/dev/neta/if_mvneta.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/sys/dev/neta/if_mvneta.c b/sys/dev/neta/if_mvneta.c index fdd6467edde1..0bdcdf0db5da 100644 --- a/sys/dev/neta/if_mvneta.c +++ b/sys/dev/neta/if_mvneta.c @@ -3000,8 +3000,6 @@ mvneta_rx_queue(struct mvneta_softc *sc, int q, int npkt) struct mvneta_rx_desc *r; struct mvneta_buf *rxbuf; struct mbuf *m; - struct lro_ctrl *lro; - struct lro_entry *queued; void *pktbuf; int i, pktlen, processed, ndma; @@ -3115,11 +3113,7 @@ rx_lro: /* * Flush any outstanding LRO work */ - lro = &rx->lro; - while (__predict_false((queued = LIST_FIRST(&lro->lro_active)) != NULL)) { - LIST_REMOVE(LIST_FIRST((&lro->lro_active)), next); - tcp_lro_flush(lro, queued); - } + tcp_lro_flush_all(&rx->lro); } STATIC void