From nobody Tue Oct 29 18:12:27 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4XdJJS3llwz5blPb for ; Tue, 29 Oct 2024 18:12:40 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4XdJJS1kD9z3x84 for ; Tue, 29 Oct 2024 18:12:40 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-4315e9e9642so52748055e9.0 for ; Tue, 29 Oct 2024 11:12:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730225559; x=1730830359; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=LnLlvZCVSY10lagHOe7+NPIwXleyzwnJSlRznw2xXz4=; b=UGLIC8djVyDLkiEcz3vtCbqAIf15LFvdHUxAKE/M1jBiZDN7DX8Wo7OgwivpyQfxJ3 lfjcH/0PCwHhynEv0fNezi+PhSH2aHyILJqjlRwkvuq7nEUSojAcm9toO7jIDUzigTIU 6ojUf5XVRjma1esdb4GIJ0a3SP1VxKl2jK0ztYLjWSzaP8Rb4mF0HhXDQzuvaFIoYD/S 0lz2/h12eFJ4zs8GQ+5d+BpA3c5hbZ6+JCMuahW5+PzWKqbPtHGU+y6X8moox3MxJKxp bFpSFInNotylLXdY6BW9h/+WK9PMHi7SJfbaObhxSQ90VzFu+tReRN6iGdht66TDOHmp wtvg== X-Forwarded-Encrypted: i=1; AJvYcCXD9wO6vqsfQftoLchtlglxvGIAbjwqYAuE8dba9mizZON44hHt9IuicXr2+oauSyyc6q+6Ga9tIQlza2WVON6qXgeb@freebsd.org X-Gm-Message-State: AOJu0YyiexCsoVghUkx0bs251y31wVuY9y6icrQDlzctkPc65pHtvsjz mOTrPkFZP33NW4J/wrlmpENlEm/31JRZ76+kBoF+Qgh0jzrAWfk4h5eYazZ0U88= X-Google-Smtp-Source: AGHT+IFJwA6SXiZo62BmCFr8Pf/TfqYH/y8q2JVDv8az6BOFELjD6Ve0jCJqJ+lJsFg2irYp/tOZDw== X-Received: by 2002:a5d:4d43:0:b0:37d:2d45:b3d4 with SMTP id ffacd0b85a97d-38061222606mr9756701f8f.52.1730225558535; Tue, 29 Oct 2024 11:12:38 -0700 (PDT) Received: from smtpclient.apple ([131.111.5.201]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38058b71221sm13140052f8f.68.2024.10.29.11.12.37 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 29 Oct 2024 11:12:38 -0700 (PDT) Content-Type: text/plain; charset=us-ascii List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3818.100.11.1.3\)) Subject: Re: git: bc9e19dce0ab - main - Fix buildworld with gcc 12 after llvm-19 import From: Jessica Clarke In-Reply-To: Date: Tue, 29 Oct 2024 18:12:27 +0000 Cc: Dimitry Andric , "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Content-Transfer-Encoding: quoted-printable Message-Id: References: <202410251608.49PG8pSI044793@gitrepo.freebsd.org> <4af71fad-407d-48f2-aec4-f6c50fa72c1f@FreeBSD.org> <4740E6A9-B104-46C5-AB19-9C5F2BF66AA3@FreeBSD.org> To: John Baldwin X-Mailer: Apple Mail (2.3818.100.11.1.3) X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US] X-Rspamd-Queue-Id: 4XdJJS1kD9z3x84 X-Spamd-Bar: ---- On 29 Oct 2024, at 18:09, John Baldwin wrote: > On 10/28/24 16:12, Dimitry Andric wrote: >> On 28 Oct 2024, at 20:56, John Baldwin wrote: >>>=20 >>> On 10/25/24 12:08, Dimitry Andric wrote: >>>> The branch main has been updated by dim: >>>> URL: = https://cgit.FreeBSD.org/src/commit/?id=3Dbc9e19dce0abee80750e6fa04aaf9798= 73bfe0d2 >>>> commit bc9e19dce0abee80750e6fa04aaf979873bfe0d2 >>>> Author: Dimitry Andric >>>> AuthorDate: 2024-10-25 16:07:59 +0000 >>>> Commit: Dimitry Andric >>>> CommitDate: 2024-10-25 16:08:32 +0000 >>>> Fix buildworld with gcc 12 after llvm-19 import >>>> Unfortunately gcc 12's is not yet capable of compiling all = of libc++ >>>> 19's C++23 code, which results in errors similar to: >>>> = /usr/src/freebsd/src/contrib/llvm-project/libcxx/include/__algorithm/range= s_contains.h:41:3: error: 'static constexpr bool = std::__1::ranges::__contains::__fn::operator()(_Iter, _Sent, const = _Type&, _Proj)' must be a non-static member function >>>> 41 | operator()(_Iter __first, _Sent __last, const = _Type& __value, _Proj __proj =3D {}) { >>>> | ^~~~~~~~ >>>> = /usr/src/freebsd/src/contrib/llvm-project/libcxx/include/__algorithm/range= s_contains.h:48:3: error: 'static constexpr bool = std::__1::ranges::__contains::__fn::operator()(_Range&&, const _Type&, = _Proj)' must be a non-static member function >>>> 48 | operator()(_Range&& __range, const _Type& __value, = _Proj __proj =3D {}) { >>>> | ^~~~~~~~ >>>> Until we can get rid of gcc 12, work around this by making = it compile >>>> libc++ in C++20 mode instead. >>>> NOTE: The resulting libc++ library will not be C++23 = compatible! Please >>>> try to avoid shipping it, and use gcc 13 instead, if you must = use gcc. >>>> PR: 280562 >>>> MFC after: 3 days >>>=20 >>> In this case I think we probably should drop support for GCC 12 for = main. Just let me >>> know when you are thinking of merging libcxx 19 to stable branches = so I can ensure they >>> build with GCC 13/14 and get our CI jobs updated before then. >> It depends a bit on how many ports still need to be fixed, and of = course when 13.5 and 14.2 are done. After those I will probably do the = merges. >> That said, is gcc 13 good for all arches we want to support? In the = past we still kept a few old gcc versions alive because they were the = only one that could build for $OBSOLETE_ARCH. >=20 > I am only aware that GCC 12+ can build amd64 world + GENERIC = currently. I believe > aarch64 is close. i386 is also pretty close (but I care less about = it). riscv64 > needs a libatomic since GCC doesn't inline atomics as much as clang. = I haven't > really tried powerpc much. GCC 13 did finally fix that for RISC-V. Jess