From nobody Sat Oct 26 19:09:45 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4XbTjq50flz5b51H; Sat, 26 Oct 2024 19:09:51 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: from mail-io1-xd33.google.com (mail-io1-xd33.google.com [IPv6:2607:f8b0:4864:20::d33]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4XbTjq3BnWz4vRd; Sat, 26 Oct 2024 19:09:51 +0000 (UTC) (envelope-from markjdb@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-io1-xd33.google.com with SMTP id ca18e2360f4ac-83ac817aac3so123480139f.0; Sat, 26 Oct 2024 12:09:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1729969789; x=1730574589; darn=freebsd.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=lylg5gDE40TqqiJ/dVE9+POPsVnYx0wSK5ZSXu1OQfM=; b=Pdeh5588Jakz8+3GO4I2GISV8k0UupSOTc2ih7OFf1TqlMFbLNbpBbHWTgDPTgAgba HaduSgazqOEZIuDYd70PWMsdTV/e5A+rt/qZ9mQ2Sq8T8f8Oz6n0zhJSClMhtaUNrSGR P9AavH4TqOr1eHb6WIJ9VXC28Pigg05ZJWXrPh8KUU1qxV3z0AtSRf0NfMQkpTdq2WsI cZ2feBLatYbzMgzNr1cYIm6BO1UqSLUBkg21z44GZm8LqM6iPiDwtUCb7XmceHbYOBme PYdt2jwKRuZTlqGY1+z/MrdGkVvQcfdKKafws8RVdxPXzUPgSQwslz8D4WzgSJmnu8cX DEeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729969789; x=1730574589; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=lylg5gDE40TqqiJ/dVE9+POPsVnYx0wSK5ZSXu1OQfM=; b=gA8w9jXsHwdLAaTeG5aqgsKNjusortylgTCNxI1gSz+0axZ/YnfxJ4XpBeLkRXebta S93mF1oX1YKNhzjT2PEk/bNfNgHsycVwHaaWgw3X89g0lHoXCrxauHNVf9JTF2AFmyBr uH2wghG2s1TQemR2mUO7EMOwxrKWcIVR/59SzmdlLox8wKbOwnZ7+8gvaCSmUeGBexfv G3M8t6ghVeNW9biQq4n6dn+uuaaSWwEu5KMvrziUqnJaFJu6OfjdDlIumnRPpkj2YJP8 dy5SwAkjf8hrgsqLeLi1HMc89Dm68u2Dh7sbQDHp49hMnsSJZmu4xooWANZtozlbARKr /8WQ== X-Forwarded-Encrypted: i=1; AJvYcCUFhfTaqw8io0NriMSELJuXvBxk1iu8tb73Bzvd0F7Do04wvK8Vb6gYi1mWjwMX7t13Z6gCn+d+Sd6lqKCEhPQTYrV6B/0=@freebsd.org, AJvYcCUIIJGlFXC7Nq2chOipLQdAGrVTFrIJ6eFNRsg4EMb6VpWalJZsHe449tWbzoaOH+4c1y0NFv4pk5JiwBjvXpecuY0N@freebsd.org X-Gm-Message-State: AOJu0Yyh575lu/oaZWjXoliYgD7fTkvw08PDyzCVkC5l+oSdBfBBFdc7 mLX/NXZ60CLS+2nEWVFuGAUBrCDSvVqPtq3R2xeYQbHeWpba4ozyrnZ77A== X-Google-Smtp-Source: AGHT+IE34/NM9goLrGuf7ABjTinBq9QjVYvl0h4tvvDmQI+8wpbd7WUpMOXHHLHIXx0ndElrqtT9Ow== X-Received: by 2002:a05:6e02:20e8:b0:3a3:41cf:f594 with SMTP id e9e14a558f8ab-3a4ed2b06d5mr26252215ab.12.1729969789545; Sat, 26 Oct 2024 12:09:49 -0700 (PDT) Received: from nuc (192-0-220-237.cpe.teksavvy.com. [192.0.220.237]) by smtp.gmail.com with ESMTPSA id 8926c6da1cb9f-4dc725eb4efsm853649173.4.2024.10.26.12.09.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 26 Oct 2024 12:09:48 -0700 (PDT) Date: Sat, 26 Oct 2024 15:09:45 -0400 From: Mark Johnston To: Jessica Clarke Cc: "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Subject: Re: git: 152382e6613d - main - rc.d/kld: Print the kernel modules being loaded Message-ID: References: <202410261900.49QJ0cLo037733@gitrepo.freebsd.org> <08AA3DE1-0618-44A0-AE8C-7BDECD2BE933@freebsd.org> List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <08AA3DE1-0618-44A0-AE8C-7BDECD2BE933@freebsd.org> X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US] X-Rspamd-Queue-Id: 4XbTjq3BnWz4vRd X-Spamd-Bar: ---- On Sat, Oct 26, 2024 at 08:02:27PM +0100, Jessica Clarke wrote: > On 26 Oct 2024, at 20:00, Mark Johnston wrote: > > > > The branch main has been updated by markj: > > > > URL: https://cgit.FreeBSD.org/src/commit/?id=152382e6613d7998fe6f5233767df54d3fdec329 > > > > commit 152382e6613d7998fe6f5233767df54d3fdec329 > > Author: Mark Felder > > AuthorDate: 2024-10-26 18:43:46 +0000 > > Commit: Mark Johnston > > CommitDate: 2024-10-26 18:43:46 +0000 > > > > rc.d/kld: Print the kernel modules being loaded > > > > PR: 282269 > > MFC after: 2 weeks > > --- > > libexec/rc/rc.d/kld | 4 +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > diff --git a/libexec/rc/rc.d/kld b/libexec/rc/rc.d/kld > > index d9c45a05f7a6..729416323d6e 100755 > > --- a/libexec/rc/rc.d/kld > > +++ b/libexec/rc/rc.d/kld > > @@ -44,10 +44,12 @@ kld_start() > > > > local _kld > > > > - echo 'Loading kernel modules:' > > + echo -n 'Loading kernel modules: ' > > for _kld in $kld_list ; do > > load_kld -e ${_kld}.ko $_kld > > + echo -n "${_kld} " > > This always prints a trailing space, whether the list is empty or not. If the list is empty, we won't get this far. > Why not drop the space from the first echo and put it as a prefix in > the second instead? That's a better way to handle it, thanks.