From nobody Thu Oct 24 09:53:40 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4XZ1T11h2qz5bJ96; Thu, 24 Oct 2024 09:53:41 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4XZ1T10jHrz4m3L; Thu, 24 Oct 2024 09:53:41 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1729763621; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=RCuZoNFOm9fK//5NDf4ZojN1pC2S2oJKw6B1xuFhGnA=; b=dmOkV350ap4DJEBao2upWnHqzKvUHh4moADQeAPGqfuXVtZEbqG5FnFNnyHyDuuyrg23eI UKBClRS9XVtSglsY9qm2qkDrKMhdKFc7vIH8R79BaWem+iJo3RqHvrhAmyoWEOVZOSLLBo sPk0RRCzA0SLJpT6j5jIEaUxEaXULNyfVjigkoMR1XEAZRdz9UCarW8qE9X83Ade5x0Zbl K9YEOiDisEmV06fwGxojgEVuAxfZcGMjPVCMH6hLpdO4yNU1ms/UE0K2bJ+YiSxSMAzJOJ 6qlKs0Z1z2Ek9nHEKf3p/QAMZ7hT1jpDeu5CsN8vUWv/GJeh2mfotdtLfifjGQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1729763621; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=RCuZoNFOm9fK//5NDf4ZojN1pC2S2oJKw6B1xuFhGnA=; b=aw9/LZKVY4qkOtH7c2IdK/PALFyV9fH0SZ11Bn1lU7nOJTKRfuYnid1gvgZ6mD1mZ2WArd TTlNBEqp3tN4HpJRjQU48Pywm7e03dlwE7XuoWDRNGsi7nd36eVSpT1K3RT1ZtE8mSe1th qAmMcra25zcIBHAgLnqt0wbWNpSuUhqOkUhZITc3dVKy/QL+PmnHkdFqxWh/TYHlneO5vC u3YYQKO9cCJLtFeNG5CIMVWltouzMLBAKqTH74RGYjWO5ayHardv7sv/hpJeL5ivecTZlk dYN7QCnz4ErntXZMPt1ecLKi4u8L79/fVRcFNMu3v2n3Oy+QTKWv55YjAVBY6g== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1729763621; a=rsa-sha256; cv=none; b=Mq6xvczg9QJMa5j50VxZkD3HjMoAnYDat+aDGvUyWeZa86V1fE3iRJozlkIL9+4s8TwQYq 0lhE5qC9kMyDki6RCFS4zFi0ultYj9VNPtZMLqnKmfCNOzXg0X0rczjnQ1Tl3nZhemIaeh D06owfnqpFmTB6vT554Ruu+oYE0yd6rsPnmWKRrS+doG1MKLeijvIvSgZihD001bcTKDVC 4MAiRjDAiBC8+236/oqKZRzOP1owSFNm0bd8CE69SLUz7IYAwo+DgeuFmOyfASfJpkNFdD RMr07WD1rc6rip7tVYG2C/UT5JOu2mkeYaSl+0drPhb4mEO32Fnnr25wxUsT4A== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4XZ1T10JNVzdQt; Thu, 24 Oct 2024 09:53:41 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 49O9rexb083744; Thu, 24 Oct 2024 09:53:40 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 49O9re2H083741; Thu, 24 Oct 2024 09:53:40 GMT (envelope-from git) Date: Thu, 24 Oct 2024 09:53:40 GMT Message-Id: <202410240953.49O9re2H083741@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Dimitry Andric Subject: git: 1c83996beda7 - main - Adjust LLVM_ENABLE_ABI_BREAKING_CHECKS depending on NDEBUG List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: dim X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 1c83996beda7b6a382857c318f46daefcb6bd84c Auto-Submitted: auto-generated The branch main has been updated by dim: URL: https://cgit.FreeBSD.org/src/commit/?id=1c83996beda7b6a382857c318f46daefcb6bd84c commit 1c83996beda7b6a382857c318f46daefcb6bd84c Author: Dimitry Andric AuthorDate: 2024-10-24 09:53:19 +0000 Commit: Dimitry Andric CommitDate: 2024-10-24 09:53:19 +0000 Adjust LLVM_ENABLE_ABI_BREAKING_CHECKS depending on NDEBUG When assertions are disabled, the upstream build system disables LLVM_ENABLE_ABI_BREAKING_CHECKS by default. Though the upstream build system allows it to be force-enabled, it looks like that is not a well-tested build-time configuration. Therefore, always disable LLVM_ENABLE_ABI_BREAKING_CHECKS when assertions are disabled, which will also save some more runtime cost when people use WITHOUT_LLVM_ASSERTIONS. PR: 280562 MFC after: 1 month --- lib/clang/include/llvm/Config/abi-breaking.h | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/lib/clang/include/llvm/Config/abi-breaking.h b/lib/clang/include/llvm/Config/abi-breaking.h index eb90be1fe37b..55e67e2ebad7 100644 --- a/lib/clang/include/llvm/Config/abi-breaking.h +++ b/lib/clang/include/llvm/Config/abi-breaking.h @@ -13,7 +13,11 @@ #define LLVM_ABI_BREAKING_CHECKS_H /* Define to enable checks that alter the LLVM C++ ABI */ +#ifdef NDEBUG +#define LLVM_ENABLE_ABI_BREAKING_CHECKS 0 +#else #define LLVM_ENABLE_ABI_BREAKING_CHECKS 1 +#endif /* Define to enable reverse iteration of unordered llvm containers */ #define LLVM_ENABLE_REVERSE_ITERATION 0