From nobody Thu Oct 24 03:17:03 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4XYrgP0HN0z5b09G; Thu, 24 Oct 2024 03:17:05 +0000 (UTC) (envelope-from kevans@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4XYrgN6ZW3z4Dn2; Thu, 24 Oct 2024 03:17:04 +0000 (UTC) (envelope-from kevans@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1729739824; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=aQ2MaLLvtFkymU0NZxcDP6MHWNk98ddcoLRW+i/mGeU=; b=cIMr+1+7tIztlHtM5+PZdgy4+60JdrlLnVWXqXcrRiH/G3RGm+3SmPIivRR493oFrgIMWh UwH9221d3edMebKKMfLTNzotSLQz/xJytdICD0Uatuei7FRItLwR110d2pa4UN6Q4uFCnQ +V7KUO8En6hqEgdoJwY/VqVARXUuvz5t7B/+YitezPRBhMynBACXete1mE4SrIeEd6iGRS zdd1G8miTTQQoAKVf79PMGMN6n+gImN6674SaFaCRpj0xhCNzAVShBIZN1XK6l5oYFncSC 4zUGsqD1jHARlhUTDJvkNpUxvncpzIrYPM2kWxUlNGHbCmmk3yif1DYRmlhC6g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1729739824; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=aQ2MaLLvtFkymU0NZxcDP6MHWNk98ddcoLRW+i/mGeU=; b=uvrY94RoOLiAZmy4dgG6L0pmqPuCzPMB4jfGkiSOHSPJ3nDxMVEoEotHoavWwK5Fo0loE7 s5niTIxHZmQk2jBg2e8bSAEEtbEP/bfPqhsTQU15s+TRKm6FRsCpRxz0L0r36d++LGsel+ KSXF67YkGFwu5SJI/zhjmOKK+mw0oaRsLtE8jCMVB0QYfnjRZJ65ezgwJbmIqTx9wqQHpm k0ym0ba9fet4f/grz3DXnqO+Bql6sxk05CxDviu4HjjRJ31M7p4ywyrlFxe0zpb3VhUdIM Nm271Nb2Y2kpybqnAVNPdiOf/SkNb+3VLt1goRj+9YIEY/wpKFm4p8NqUniQIg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1729739824; a=rsa-sha256; cv=none; b=Q7TTSH2KRE0tiMCgmDCSn/ThGDumIYuCi30QPiCeeP+mfeBzd2YUC6Ybmva7kFDgHtWtpl ttzjkYmZLNDzRnoHXvnMCDP3iito33o5xKDV3ff5PjEHWhF0oHpJTX9hgem44dvxQDD3Bi MsMUgOShnlyWgYVRMqJTCt65f28LHBXtXIqdXEnktdAPXFw17WWqz0p+MoKx//EelduZ81 N2WCpyptNdZxSuT91WRqxqm+y/4R36IqMkmn36md2M9PHiN+HnKctarum3kJGoa9v95stD 7cHn28PVR5Zh8D/kEQZ6O/iJqL99pQ6XOAvuLz7gV+rhMXoOQq1lFANvoLmvaA== Received: from [IPV6:2001:470:39df:1:f67b:9ff:fe9c:6c5b] (unknown [IPv6:2001:470:39df:1:f67b:9ff:fe9c:6c5b]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: kevans/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4XYrgN4V63z1HHw; Thu, 24 Oct 2024 03:17:04 +0000 (UTC) (envelope-from kevans@FreeBSD.org) Message-ID: <505d67af-eca8-4e21-86d2-fee25bdd0687@FreeBSD.org> Date: Wed, 23 Oct 2024 22:17:03 -0500 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: git: 3360a15898ce - main - net: route: convert routing statistics to a sysctl From: Kyle Evans To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org References: <202410240316.49O3G8gQ043914@gitrepo.freebsd.org> Content-Language: en-US In-Reply-To: <202410240316.49O3G8gQ043914@gitrepo.freebsd.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 10/23/24 22:16, Kyle Evans wrote: > The branch main has been updated by kevans: > > URL: https://cgit.FreeBSD.org/src/commit/?id=3360a15898ce6cd06aad5afd9b48c8a5454cf952 > > commit 3360a15898ce6cd06aad5afd9b48c8a5454cf952 > Author: Kyle Evans > AuthorDate: 2024-10-24 03:15:55 +0000 > Commit: Kyle Evans > CommitDate: 2024-10-24 03:15:55 +0000 > > net: route: convert routing statistics to a sysctl > > Exporting the relevant pcpustat is trivial, so let's do that. We will > use it in a near-future change in netstat to avoid having to dig around > in mem(4) for live kernel statistics. > > Differential Revision: https://reviews.freebsd.org/D47231 Sorry, I failed to ^C it in time. Reviewed by: glebius, markj, zlei Thanks, Kyle Evans > --- > sys/net/route.c | 4 ++++ > sys/net/route.h | 1 + > 2 files changed, 5 insertions(+) > > diff --git a/sys/net/route.c b/sys/net/route.c > index 650da826d89d..7a50bcc43e06 100644 > --- a/sys/net/route.c > +++ b/sys/net/route.c > @@ -75,6 +75,10 @@ VNET_PCPUSTAT_SYSINIT(rtstat); > VNET_PCPUSTAT_SYSUNINIT(rtstat); > #endif > > +SYSCTL_DECL(_net_route); > +SYSCTL_VNET_PCPUSTAT(_net_route, OID_AUTO, stats, struct rtstat, > + rtstat, "route statistics"); > + > EVENTHANDLER_LIST_DEFINE(rt_addrmsg); > > static int rt_ifdelroute(const struct rtentry *rt, const struct nhop_object *, > diff --git a/sys/net/route.h b/sys/net/route.h > index 6d28f21e9181..603e4fac5354 100644 > --- a/sys/net/route.h > +++ b/sys/net/route.h > @@ -239,6 +239,7 @@ struct rtstat { > uint64_t rts_add_retry; /* # of route addition retries */ > uint64_t rts_del_failure; /* # of route deletion failure */ > uint64_t rts_del_retry; /* # of route deletion retries */ > + uint64_t rts_spare[5]; > }; > > /*