From nobody Mon Oct 21 18:39:23 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4XXPH00wSDz5Zcr9; Mon, 21 Oct 2024 18:39:24 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4XXPH006cpz4G95; Mon, 21 Oct 2024 18:39:24 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1729535964; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=ZLlJdjXbO/aDrE717pnobQ0fTaPEeqaRfRk9J9LOZQ8=; b=aXKuB7LI7lKqtGJpbbmKhh45f0QzOO7553nQ6Fbatpvjuk+HwkBgw1/WkT9lI+qfyJvnxR 1eL416IZVcdIO6sNA56a/XbCP0Z9h2Wkol/cDRl+rucBDzaCShDd5+HgmTkMwjxzsb4t6g 0Q03eXdvCe/iNcbm19LICVIqisySAXyO9mb92yj7cH/tq1hFbW4DfuJeSN4kJlgdvjfjhL kgrIlMxa60CEpViQji2l7iJrLNw0ESvmCKDMxqqMDvrGevKE9RmHGyZqk/wKeHy4CwKQMX nufNZ7GQ3bcCbykyzrnE/q4Mvfhl3gfqRPeMTm2Gq6U5tWuL988IZRZee3JaCA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1729535964; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=ZLlJdjXbO/aDrE717pnobQ0fTaPEeqaRfRk9J9LOZQ8=; b=m8PaOJg3j5DdhRoJTGB75m+OGAmtwjRDE+MCc1BkdDXc6BZC0/M/Zx5sfW0XhvUd+FT369 3GoOXSWBQvQg2h1i6FGnyucYSr30jP2FlHXPE8DsKYZEI138jEg1ehRXo8ip8uu0ewJxtn eq2I73Ga70IOsW8ZSto6MKc8Swc815VUjxSIAHhbezqQfkmIGcLUz6C9uD700Qv05qnY9C mybM+cx+RGljQXDdlDsGS6AAIrLD3McCfv304FsemYuaL9ZvUbHtgyEsPydf7R9PqfgXET cDVjxpAX7I5Y9Q8G/OM8IOtMQebbABUf6CnMlqrJgpKsKAcssicHQaTd0IaVag== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1729535964; a=rsa-sha256; cv=none; b=nlt/gDsBDEOnTYWbJSpasFWHF3myIHyS4Fm7Tn6FmXDpOgrqM+BL6DXqFYkfJopLRYgO42 ahI2SFEFpASB64rymhmZTwyl/1/XgsVE8RI7xWeSSZ4rAKcf7kJ9tJOx6mTxAzgJOZS31Y Vykq6lqGrg6dAwWHa+W8PFOFEBuVm4pLLDbGlWrcOuP3brXJOsBn5phTxJoAoElMHbVFft L5F36ixRlph2a2V88yy+NAf5wi33J0nFlvRO5bOELgobJ3eXsk1jFKtqIz3DoJLyEe4xa3 ldj3I8rztfGSWvQuh2BpR+cy3EMKRwoK9lwiiLdNyYiuZxKGUlcnFH3aZca3YQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4XXPGz6qMnzhVk; Mon, 21 Oct 2024 18:39:23 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 49LIdNaM036781; Mon, 21 Oct 2024 18:39:23 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 49LIdNVG036778; Mon, 21 Oct 2024 18:39:23 GMT (envelope-from git) Date: Mon, 21 Oct 2024 18:39:23 GMT Message-Id: <202410211839.49LIdNVG036778@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Navdeep Parhar Subject: git: 0366d0bd5028 - stable/14 - cxgbe/iw_cxgbe: c4iw_connect should return a negative errno. List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: np X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: 0366d0bd50281cff65e3856f238e250dba39adfa Auto-Submitted: auto-generated The branch stable/14 has been updated by np: URL: https://cgit.FreeBSD.org/src/commit/?id=0366d0bd50281cff65e3856f238e250dba39adfa commit 0366d0bd50281cff65e3856f238e250dba39adfa Author: Navdeep Parhar AuthorDate: 2024-08-30 00:43:43 +0000 Commit: Navdeep Parhar CommitDate: 2024-10-21 17:08:27 +0000 cxgbe/iw_cxgbe: c4iw_connect should return a negative errno. Avoid a pointless assignment while here. Sponsored by: Chelsio Communications (cherry picked from commit 3b4dcc0feb41120017381681d612d3cc21beb1d7) --- sys/dev/cxgbe/iw_cxgbe/cm.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/sys/dev/cxgbe/iw_cxgbe/cm.c b/sys/dev/cxgbe/iw_cxgbe/cm.c index 62961ca88aab..cf4a8f1aa87b 100644 --- a/sys/dev/cxgbe/iw_cxgbe/cm.c +++ b/sys/dev/cxgbe/iw_cxgbe/cm.c @@ -2664,8 +2664,7 @@ int c4iw_connect(struct iw_cm_id *cm_id, struct iw_cm_conn_param *conn_param) CTR2(KTR_IW_CXGBE, "%s:cc7 %p", __func__, ep); printk(KERN_ERR MOD "%s - cannot find route.\n", __func__); - err = EHOSTUNREACH; - return err; + return -EHOSTUNREACH; } if (!(if_getcapenable(nh_ifp) & IFCAP_TOE) ||