From nobody Mon Oct 21 18:21:40 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4XXNtb01HNz5Zc7s; Mon, 21 Oct 2024 18:21:43 +0000 (UTC) (envelope-from maxim@freebsd.org) Received: from maxim.int.ru (maxim.int.ru [167.71.75.67]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "maxim.int.ru", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4XXNtZ4Sz9z4Cxd; Mon, 21 Oct 2024 18:21:42 +0000 (UTC) (envelope-from maxim@freebsd.org) Authentication-Results: mx1.freebsd.org; none Received: from localhost (maxim@localhost [127.0.0.1]) by maxim.int.ru (8.17.1/8.17.1) with ESMTPS id 49LILe3M079848 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Mon, 21 Oct 2024 18:21:40 GMT (envelope-from maxim@freebsd.org) Date: Mon, 21 Oct 2024 18:21:40 +0000 (UTC) From: Maxim Konovalov To: Pedro Giffuni cc: "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Subject: Re: git: b88df1e893c4 - main - Reapply "sbin/ping: allow normal users to specify larger packets" In-Reply-To: <1791968192.4471640.1729534703845@mail.yahoo.com> Message-ID: <1e630992-e41c-2edd-ef48-61396146f72c@maxim.int.ru> References: <202410161840.49GIe8CR000407@gitrepo.freebsd.org> <39113afb-66e8-da08-14ab-83564c1271b2@maxim.int.ru> <1791968192.4471640.1729534703845@mail.yahoo.com> List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:14061, ipnet:167.71.64.0/20, country:US] X-Rspamd-Queue-Id: 4XXNtZ4Sz9z4Cxd X-Spamd-Bar: ---- Hi Pedro, No worries at all! Maxim On Mon, 21 Oct 2024, 18:18-0000, Pedro Giffuni wrote: > Sorry ... > I completely missed this was causing any trouble. My filters threw the reply into a folder that I don't look at regularly. > Thanks to markj@ for backing it out.  > Pedro. > On Friday, October 18, 2024 at 02:41:12 PM GMT-5, maxim@freebsd.org wrote: > > Hi Pedro, > > Unless you have a plan to address this issue please backout this code > as it is clearly wrong. > > Thanks, > > Maxim > > On Wed, 16 Oct 2024, 19:04-0000, Maxim Konovalov wrote: > > > Hi Pedro, > > > > No, this is not right.  Let me clarify: > > > > (1) I never told that there are any issues with the tests.  I just > > mumbled that the tests should catch such regression though I never > > checked if they actually did. > > > > (2) The MAXPAYLOAD calculation in the code below is not fully correct. > > > > It should be > > > > 65535 - 20 (ip header) - 8 (icmp part) = 65507 without IP options > > > > OR > > > > 65535 - 20 (ip header) - 40 (ip options) - 8 (icmp part) = 65467 with > > IP options, ie. whenever you run ping -R. > > > > The code below hardcoded the latter value which is simply wrong. > > > > I wouldn't rely on the fact that you get it from other BSD flavours > > and would recommend to have this code reviewed before committing it. > > > > Maxim > > > > -- Maxim Konovalov