From nobody Sat Oct 19 14:31:12 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4XW3sc2mxFz5b8TL; Sat, 19 Oct 2024 14:31:16 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: from mail-qk1-x735.google.com (mail-qk1-x735.google.com [IPv6:2607:f8b0:4864:20::735]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4XW3sc0JXBz4Y2t; Sat, 19 Oct 2024 14:31:16 +0000 (UTC) (envelope-from markjdb@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-qk1-x735.google.com with SMTP id af79cd13be357-7b152a923a3so166335085a.3; Sat, 19 Oct 2024 07:31:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1729348275; x=1729953075; darn=freebsd.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:sender :from:to:cc:subject:date:message-id:reply-to; bh=pT1sKTDvEaqTuIITBsXOtbuRwzvC5Chd3ATtccXaEfQ=; b=QyejdiHgOe0tQ7+PM5AR4aTPYyb58bXbpoDGXy4QGH1LF/KDAlsV1HETAGsNE+L1a+ +4hGq+yKc4Kaey/V8Sr5w9Oc+IJuILCE9NvWmUriqX/el+5GObFOXi1DHIiiO6ny437b B+a80mgZOBVd5OJnwOuTthuPjg0s9tTUa5vEPykNYcvYtMI6BUbdI1zCCkw4VTHhtE60 huC/gOH6CzheYSHUbJUdEZgDNAggOaeeVdXGw9iR/EEiMBM5v49N3Lj68mLx1tfS/XoC iaGdp7291ExHro6EcXzn60A0/nhcGDt04Ld1dTunnwsXFgNe6S7kzrf15j1lWJpoltHQ VY5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729348275; x=1729953075; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:sender :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=pT1sKTDvEaqTuIITBsXOtbuRwzvC5Chd3ATtccXaEfQ=; b=QZVUgFpzCCwNj26oK5mKybBlRb43GEtIhHbHbEDZ2m0bh3BXXvc6yWb7l9IasD1Zmh Brd2kHOR1LBdFFPlA+iQP5Hy0Wm+h2bVC5Wdxq4sYjtQNS5rrkTwylDbyfZSHMeT0vXE Iq65PAs6TX2Fr7pv1YZirkWD91rxGYK1/pO2HRr0BANAiMDq5qCNA6k5SjYrmuPftNOm TCSv7WyWDhPU05Od2wWNQuZ8oSvNEaalTppagDGaehu7H5YLur62+F3RVpHuVMDj8pxt IPigpBR6attUiprcMoxNJI7C8eY4NHAmryUDETP8IujCkz8Iwj12KslsclgKcpeKkbGv I1vQ== X-Forwarded-Encrypted: i=1; AJvYcCV5uO6maeFRDCUX+G07i4ND0Kc5B3MHIhFvVu7xprCnIBL12a8jy7iw0wyYsoojXKo/QujlnWAo864qYZm0mTn2y/og@freebsd.org, AJvYcCVPzHlOZPejnt8PISv2692Ey8/cQg+eBWFbLLvyzw5fPQ6U1OtrDWs49RL4z/akuSJljkasyQnTMjpyZYY5Hvbb3apyKdE=@freebsd.org X-Gm-Message-State: AOJu0Ywszzsf7I+0mZ/V7x7dF59LHqAXdMk4OyAz4Hw4yrf5SU22SvnT novBo6EKml4g+VRQs2h83Y+vqxViSqPZHmSMf67e9FuxJw+pS6u1nm7glw== X-Google-Smtp-Source: AGHT+IEIUF4y8rfhHOWVSn0+yjI7Bg1KCHmyqKbX4/Y6vfgrPbeuGuWD/rgyOumOIW+eBkkf5c1kJA== X-Received: by 2002:a05:620a:1a8d:b0:7af:c818:bca with SMTP id af79cd13be357-7b157be31d4mr611860285a.46.1729348274646; Sat, 19 Oct 2024 07:31:14 -0700 (PDT) Received: from nuc (192-0-220-237.cpe.teksavvy.com. [192.0.220.237]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7b156f954fbsm188129385a.46.2024.10.19.07.31.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 19 Oct 2024 07:31:14 -0700 (PDT) Date: Sat, 19 Oct 2024 10:31:12 -0400 From: Mark Johnston To: Jessica Clarke Cc: "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Subject: Re: git: 4f2ca36c7bec - main - arm64: Disable coverage sanitization of `pmap_update_strided` Message-ID: References: <202410111653.49BGrin3091045@gitrepo.freebsd.org> <92030090-11B4-484B-8FD4-6B92F34FD717@freebsd.org> List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <92030090-11B4-484B-8FD4-6B92F34FD717@freebsd.org> X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US] X-Rspamd-Queue-Id: 4XW3sc0JXBz4Y2t X-Spamd-Bar: ---- On Fri, Oct 18, 2024 at 10:01:18PM +0100, Jessica Clarke wrote: > On 11 Oct 2024, at 17:53, Mark Johnston wrote: > > > > The branch main has been updated by markj: > > > > URL: https://cgit.FreeBSD.org/src/commit/?id=4f2ca36c7becd20b21ce5ef7256bbd42f732dafe > > > > commit 4f2ca36c7becd20b21ce5ef7256bbd42f732dafe > > Author: Zhuo Ying Jiang Li > > AuthorDate: 2024-10-11 16:41:49 +0000 > > Commit: Mark Johnston > > CommitDate: 2024-10-11 16:52:53 +0000 > > > > arm64: Disable coverage sanitization of `pmap_update_strided` > > > > The break-before-make update invalidates PTEs, including the PTE > > pointing to curthread, causing a fault in `trace_pc`. This > > addresses a similar issue in > > 01bb9a2a3557bc9389f628d301cd691e08266f1d. > > This broke* GitHub Actions due to the use of Clang 12 (newest Clang in > Ubuntu 20.04 LTS which isn’t EOL until April 2025) which doesn’t > support this sanitiser. Probably the easiest thing to do is to leave > the relevant __nosanitizefoo defined to nothing unless that sanitiser > is actually enabled (via __has_feature), as it’s not necessary outside > of that, and if it’s enabled then you know it’s supported? This seems to work, in that I reproduced the build failure locally with CROSS_TOOLCHAIN=llvm12 and then verified this patch: https://reviews.freebsd.org/D47193 > Jess > > * Masked by the OpenZFS import breaking it earlier in both commit > history and build order >