From nobody Tue Oct 15 15:44:20 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4XSdgp06VLz5Yc8V; Tue, 15 Oct 2024 15:44:22 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4XSdgn6JRPz4Kst; Tue, 15 Oct 2024 15:44:21 +0000 (UTC) (envelope-from jhb@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1729007061; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=aCBnc+6rwnZHGULX7eT1oJm4fRF4VG0si91Lgmwrktk=; b=Oor4zCVXLD4WL50u1nlP0w0TVyFNZmgcbqpP3BkYDqjXx/TPWH3jLvs52etPEwEo86pL0e 5fwJWxrHZDZqAMCH7i4u7Kr3vmIFtvCYZlNFvyN6iXEM3OVz+EwprsrOASAi0gbIVIfO40 2BzL4u6sZv7GoDbmPfHAS3xRxC044a5hRhmAziQaWZ2UIhDXi+Sq/pvUrk7rZFTIMAIcBj C82hRRa78Ry4IHw831xb2RYyggmVyCW/1LXLW1MZpcZQNOojNoTWPML1OFyaohusURoZEH S0/wMLok14GR8/fDOQ4MDDIhOymylFmfFrnc1TN1UvKsS/XcMS40EOwuCIojRQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1729007061; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=aCBnc+6rwnZHGULX7eT1oJm4fRF4VG0si91Lgmwrktk=; b=BBy6Sj2PrKht4Bv5oTglSGWWAcEYBWBn59rk4cLY0ZaIup3MpC5968nhsbIICSL7Jnsr5f 67jKeqgjoGSIuRou07CLYA6iF6OF75tIh5OxAkcYqtkr1WwSaDQVfXVu6uxY3wrTb2IPfX auu2eoghLswKi9LbUThAXTkTatN/npryEMg5FQ81mvIplHMMM9xDlqiKssakR8VCEBzHdz cztpvClGPRn2NJml9yT5ERJL99Efcl8huGNhyRSkI3zEaXAvB1SrIluuHHTyyJ+0+zgdjF KLjNev/bW8WVseG6gk+TAEz2VyZaLoLqMF9GESasiXUzI9ZuJctPioqemVYDTw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1729007061; a=rsa-sha256; cv=none; b=CF574fE+3H3S20ftDwZD1fYCpUM7evFPtMbVOt5TokjtlcV9BRRHVku+ODLJsGgafbH7op 5v129UOgAeR3FQ+8VHbHaaL/yOp42/MXXxgG+30PN5IzyaIrveopn8NdA1F+UT+QZiVIse anBloh+KWjIW8eOcvxtwmdYoqIVDD8QQl6ZkK7tSvvPvmPtJOxB1+YVC6amEsx7qrpU/q6 ns7C9+RwevPt4WILF1FlZ8sY2hcI1OfMwzJccAXfYsN0mi1kdfqEPejIhRwABPm1l3w3F9 yfIhSqft7rHXD0ZzL8HXhhwRK50slaIkHMYJfoNXZmAml0RWAj6l4HExccPR9g== Received: from [IPV6:2601:5c0:4200:b830:6065:7bd2:5db8:bc5f] (unknown [IPv6:2601:5c0:4200:b830:6065:7bd2:5db8:bc5f]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id 4XSdgn3WX1zjG9; Tue, 15 Oct 2024 15:44:21 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Message-ID: <1d8771ba-319f-419d-a567-200d538bc704@FreeBSD.org> Date: Tue, 15 Oct 2024 11:44:20 -0400 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: git: 50c64df2a173 - main - Revert "libkldelf: add a private library for kernel/kld-related ELF parsing" Content-Language: en-US To: Ka Ho Ng , Cy Schubert Cc: Dmitry Morozovsky , Shawn Webb , Ka Ho Ng , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org References: <202410081940.498JeV5t035958@gitrepo.freebsd.org> <20241008201627.4EE5719D@slippy.cwsent.com> From: John Baldwin In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 10/8/24 15:16, Ka Ho Ng wrote: > On Tue, Oct 8, 2024 at 4:16 PM Cy Schubert > wrote: > >> In message , Dmitry >> Morozo >> vsky writes: >>> On Tue, 8 Oct 2024, Shawn Webb wrote: >>> >>>> On Tue, Oct 08, 2024 at 07:40:31PM UTC, Ka Ho Ng wrote: >>>>> The branch main has been updated by khng: >>>>> >>>>> URL: >> https://cgit.FreeBSD.org/src/commit/?id=50c64df2a1739dca84c0e3bc795b >>> 70e5991b7010 >>>>> >>>>> commit 50c64df2a1739dca84c0e3bc795b70e5991b7010 >>>>> Author: Ka Ho Ng >>>>> AuthorDate: 2024-10-08 19:40:20 +0000 >>>>> Commit: Ka Ho Ng >>>>> CommitDate: 2024-10-08 19:40:20 +0000 >>>>> >>>>> Revert "libkldelf: add a private library for kernel/kld-related >> ELF p >>> arsing" >>>>> >>>>> This reverts commit 0a2cfd653e86ac41c4e6e32a449d133c0ee6d677. >>>> >>>> Could you please explain why? >>> >>> bapt@: Since this set of commits, incremental building of packages >> fail! >> >> Hmm. I didn't experience this in my poudriere here. >> >> >> -- >> Cheers, >> Cy Schubert >> FreeBSD UNIX: Web: https://FreeBSD.org >> NTP: Web: https://nwtime.org >> >> e^(i*pi)+1=0 >> >> >> It affects pkgbase users mainly, and the reason is rather due to the > linkage issue between the separated privatelib and kldxref resulting in > empty LINKER_SETs in the privatelib. I will recommit this once it's fixed. One thing I would still like to understand, btw, is your use case for having the separate library? I think you plan to teach libkvm about kernel modules so it can resolve symbols defined in kernel modules when examining a vmcore? However, I'm curious why you need that functionality in libkvm itself? That is, many of the problems you have to solve (e.g. finding the separate debug files for kernel modules in /usr/lib/debug so that you can parse the symbol table) are already handled in existing debuggers like gdb and lldb. It's not clear to me that teaching libkvm about kernel modules in crashdumps is the right way to solve the problem you are solving vs using a debugger directly? -- John Baldwin