git: 6b8096fa5f6f - main - netpfil tests: skip checksum verification in pft_ping.py

From: Kristof Provost <kp_at_FreeBSD.org>
Date: Mon, 14 Oct 2024 15:55:09 UTC
The branch main has been updated by kp:

URL: https://cgit.FreeBSD.org/src/commit/?id=6b8096fa5f6f81e2959cbb2ca857c4e134273da2

commit 6b8096fa5f6f81e2959cbb2ca857c4e134273da2
Author:     Kristof Provost <kp@FreeBSD.org>
AuthorDate: 2024-10-14 12:57:49 +0000
Commit:     Kristof Provost <kp@FreeBSD.org>
CommitDate: 2024-10-14 15:54:49 +0000

    netpfil tests: skip checksum verification in pft_ping.py
    
    From scapy 2.6.0 it now removes (sets to None) the IP checksum in its defrag
    code. We typically ask for IPv4 or IPv6 defragmentation, which causes check
    function failures.
    
    Just skip the checksum verificiation here, because we're going to notice
    incorrect checksums even if the tests don't directly verify it.
    
    MFC after:      1 week
    Sponsored by:   Rubicon Communications, LLC ("Netgate")
---
 tests/sys/netpfil/common/pft_ping.py | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/tests/sys/netpfil/common/pft_ping.py b/tests/sys/netpfil/common/pft_ping.py
index 1caa26abe5f6..0d1134a22dda 100644
--- a/tests/sys/netpfil/common/pft_ping.py
+++ b/tests/sys/netpfil/common/pft_ping.py
@@ -205,12 +205,6 @@ def check_ipv4(expect_params, packet):
     if dst_address and ip.dst != dst_address:
         LOGGER.debug(f'Wrong IPv4 destination {ip.dst}, expected {dst_address}')
         return False
-    chksum = ip.chksum
-    ip.chksum = None
-    new_chksum = sp.IP(sp.raw(ip)).chksum
-    if chksum != new_chksum:
-        LOGGER.debug(f'Wrong IPv4 checksum {chksum}, expected {new_chksum}')
-        return False
     if flags and ip.flags != flags:
         LOGGER.debug(f'Wrong IP flags value {ip.flags}, expected {flags}')
         return False