From nobody Mon Oct 14 12:57:02 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4XRy1B4BQ1z5YX5M; Mon, 14 Oct 2024 12:57:02 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4XRy1B3jk1z47JH; Mon, 14 Oct 2024 12:57:02 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1728910622; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Q+RDBbOi2oNGAOHUKmhfsiSDAs09Yo1cOVVXgxodEi4=; b=uReToCpZFzdNI4UfosM/Fg1uJYfFY05Rn8VLdNsY7wAYzIbKOITqFGz1YeRWVBgrLrP1oT Xq8XAOnfMIq6XjJdTywfXq6HNxGyCFuLCYl8YO721A1/yb1hq7NwgepAB0/fgCcweyuArH ARVxes+4awSb+cdSItoyzr61CwQ/ittvJuwys14cfS29j6y4fYTcCEComYiASTXTmfTuo+ cKzxFEeLqC5Elmvp6rWRoNGOHSrUkwxbWg7BeQSwGwh6WHzN6jxZit47oly6XnxkN7jdl/ 2BoGK7BlLaiEX3n4bpgpIhorPbPmdQRltW4vWK/WhdMF0YPxOtOc2jgQn8EO/w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1728910622; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Q+RDBbOi2oNGAOHUKmhfsiSDAs09Yo1cOVVXgxodEi4=; b=QLVvLcvfQ4YeQqzW6uNNMQajfJ/DbPLa73NkJAxQwRy+5aKpB5d2IVjygVCMw0xIBe7Hvd dao7k1THxKVgsVSePK7AHVWBFH342NqJhTH4lPWowELGLqwgskd+n1bSBLvsHe20uMRXJc +w65KqZAbPUKMTBczueIkoiMYSVSyC4O7Oujd+mXSkcw+OCRtIA6Cnr9M2HaDklc3nLY25 ZKlyHoHbqCGeDC+BY/zLTzssOggPE326zrKa5VAXtbLM5bBDG/4JiBPF8CYdFEIY+6/EJ1 5M0t4zLbi6jfFd17srWtveqtzgTjVHR0yDZUzM9jZK7+IddVmujT8e812ARgdg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1728910622; a=rsa-sha256; cv=none; b=P6cy0CQ0XTT1EH7a66OVx2+w2erhcfjV/P7uV6W9nCD//vpqhDzNMhKM4hIGARdNSouKwp 9r2rYB2aMROcwLO+cbQShpOEbs7Jr7D52d/alPnsMLozhzc5FG5ewgkkA5F+d2Wh+Xn10e V1JGc56S627XZmkB2Or6iGWmGeM6XMMUpxUx7qFwS7LqCTEvLFBREYHuFiMQhOuY9NKR6t XX2kUWDZXbjK1UV14Xs2FLURkegWXJ04Z+0DiKsTPuqGjnLL39L1IkuIp3Cw+Rdd6XQ6ku 29LMbTox/iFdnhCMp9y8uWvOCRHEzvhcuJIWD4l4N2GpncHywEMemHU2dGbIKQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4XRy1B31CLzds5; Mon, 14 Oct 2024 12:57:02 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 49ECv2Oe023633; Mon, 14 Oct 2024 12:57:02 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 49ECv2o2023630; Mon, 14 Oct 2024 12:57:02 GMT (envelope-from git) Date: Mon, 14 Oct 2024 12:57:02 GMT Message-Id: <202410141257.49ECv2o2023630@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Kevin Bowling Subject: git: 68b1f5dc5936 - main - igc: Add sysctl for DMA Coalesce List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kbowling X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 68b1f5dc59368ce5175e3300bf95476ea5a560bc Auto-Submitted: auto-generated The branch main has been updated by kbowling: URL: https://cgit.FreeBSD.org/src/commit/?id=68b1f5dc59368ce5175e3300bf95476ea5a560bc commit 68b1f5dc59368ce5175e3300bf95476ea5a560bc Author: Kevin Bowling AuthorDate: 2024-10-14 12:55:18 +0000 Commit: Kevin Bowling CommitDate: 2024-10-14 12:56:39 +0000 igc: Add sysctl for DMA Coalesce This feature can increase efficiency at the expense of latency It does not work well with the default interrupt delay, but expose the otherwise unconnected code in the driver in case people want to experiment. See https://www.intel.com/content/dam/support/us/en/documents/network/adapter/pro100/sb/466827_intel_r__dma_coalescing_white_paper_v003.pdf MFC after: 1 week Sponsored by: BBOX.io --- sys/dev/igc/if_igc.c | 56 ++++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 56 insertions(+) diff --git a/sys/dev/igc/if_igc.c b/sys/dev/igc/if_igc.c index d964fbe4cf91..da897d636cfe 100644 --- a/sys/dev/igc/if_igc.c +++ b/sys/dev/igc/if_igc.c @@ -141,6 +141,7 @@ static int igc_msix_link(void *); static void igc_handle_link(void *context); static int igc_set_flowcntl(SYSCTL_HANDLER_ARGS); +static int igc_sysctl_dmac(SYSCTL_HANDLER_ARGS); static int igc_sysctl_eee(SYSCTL_HANDLER_ARGS); static int igc_get_regs(SYSCTL_HANDLER_ARGS); @@ -490,6 +491,12 @@ igc_if_attach_pre(if_ctx_t ctx) CTLTYPE_INT | CTLFLAG_RW | CTLFLAG_NEEDGIANT, adapter, 0, igc_get_rs, "I", "Dump RS indexes"); + SYSCTL_ADD_PROC(device_get_sysctl_ctx(dev), + SYSCTL_CHILDREN(device_get_sysctl_tree(dev)), + OID_AUTO, "dmac", + CTLTYPE_INT | CTLFLAG_RW, adapter, 0, + igc_sysctl_dmac, "I", "DMA Coalesce"); + /* Determine hardware and mac info */ igc_identify_hardware(ctx); @@ -3030,6 +3037,55 @@ igc_set_flowcntl(SYSCTL_HANDLER_ARGS) return (error); } +/* + * Manage DMA Coalesce: + * Control values: + * 0/1 - off/on + * Legal timer values are: + * 250,500,1000-10000 in thousands + */ +static int +igc_sysctl_dmac(SYSCTL_HANDLER_ARGS) +{ + struct igc_adapter *sc = (struct igc_adapter *) arg1; + int error; + + error = sysctl_handle_int(oidp, &sc->dmac, 0, req); + + if ((error) || (req->newptr == NULL)) + return (error); + + switch (sc->dmac) { + case 0: + /* Disabling */ + break; + case 1: /* Just enable and use default */ + sc->dmac = 1000; + break; + case 250: + case 500: + case 1000: + case 2000: + case 3000: + case 4000: + case 5000: + case 6000: + case 7000: + case 8000: + case 9000: + case 10000: + /* Legal values - allow */ + break; + default: + /* Do nothing, illegal value */ + sc->dmac = 0; + return (EINVAL); + } + /* Reinit the interface */ + igc_if_init(sc->ctx); + return (error); +} + /* * Manage Energy Efficient Ethernet: * Control values: