From nobody Fri Oct 11 14:14:27 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4XQ7sw1Gz6z5YxCF; Fri, 11 Oct 2024 14:14:28 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4XQ7sw0gwwz4g7G; Fri, 11 Oct 2024 14:14:28 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1728656068; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=qZzJHbPillcv3m1Ff6CDpTiW6YoVIJb0dj8M3jAzheo=; b=xmy2TTP8LVJ8jL9gPtX/n6moXSHOPFMwuZAEV+TqfEAvBCQbCmPfpYPyIiO51AjhVd7qeN 1MtNWjE2iBdljisF0dptqHNGiH0mU5OV882hSV4Pu6AkrK/pImKp6azILcHHDRFyYoxpho mq0v4a4yOAcy52WHwawbYoC416RGRxTXbP8ECZZuxNCzz1+6R2qQdIXYv6b5C1dK6SaBIA bgb0+UCGg9omH/+CUoW50ga0cWfjMCG6sJbfX/I4jAXlA2UUs535gxC4IWRpLazQeavTkD Fvpg5AcsPyf8fyXsugNt4hwZpN/l02LGzZXwm2rlUbX4+V2X3lE1wEGeVIB+Bw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1728656068; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=qZzJHbPillcv3m1Ff6CDpTiW6YoVIJb0dj8M3jAzheo=; b=HbJNcuNwRi4CFlprEuRpX0t9oSofOJ/axd0OOkhkT5SQn8z2OmrO3cbl4sGIT1B2w0Vnv1 QBldiHlsoy81E+kPILadciPsvIaBQVYAaHvSnCotYceEC515E9DxVF0SKIBEFVFPBl9jtw 9AiP3zWnoes+tWb7JBJayFuzBzD5sLLaF5Znn3vXYEaL9kv6VAEWQcIw2z3EHRjmyo/3s/ m+awIbdxyK1Hzi0RVaIwM+9JPsl5TOMEdjzg/lvFh9UfJjye5HtqRx8zf2A0N9ime3EXqg eZS0G05NDf9jmoW251PnM9a+4C9YorfyUEJQyf9a4aaA75v//rDQRSfLwOCYYw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1728656068; a=rsa-sha256; cv=none; b=GtFFqf1jD+V1L8mCb2BWNy7KgjhTrGcdkMowp1BCd8ie2NO8lAEFy245B9okeE/8VjZYNd EuoCUao94WSsqzRFu0JDV0qz0zW/MOTwuRnA7jz2NGPcdeqriuGbJ9n6Cp3OjqsCqM8Vv6 iaSIMJsjA9ySX+a28RS4LoV+8W+YN0EJ7j+9oVHZczZvO7a83ZrkA6ewH3s9HXqmwSWxHW 1aU2/hn8Wjop1Tj5+LEtZQTMqAESd5JkTFex/+m1Nah1+52Mj2uISbaPL2JKKUkUO4rIRf HF0cLF29aaSH6tWfcrkd9kehwfECSBuUZAVf3Jpb+j+x4rT1KvBH6XHs8jzIzA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4XQ7sw0Gw5zlSs; Fri, 11 Oct 2024 14:14:28 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 49BEERsA019012; Fri, 11 Oct 2024 14:14:27 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 49BEERus019009; Fri, 11 Oct 2024 14:14:27 GMT (envelope-from git) Date: Fri, 11 Oct 2024 14:14:27 GMT Message-Id: <202410111414.49BEERus019009@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Ed Maste Subject: git: 21d9853ed553 - main - arm64/gicv3: Skip programming vPE GITS_BASERs to avoid a boot crash List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: emaste X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 21d9853ed5533a87f59937b564a53a2d6ac3c637 Auto-Submitted: auto-generated The branch main has been updated by emaste: URL: https://cgit.FreeBSD.org/src/commit/?id=21d9853ed5533a87f59937b564a53a2d6ac3c637 commit 21d9853ed5533a87f59937b564a53a2d6ac3c637 Author: D Scott Phillips AuthorDate: 2024-10-11 14:12:15 +0000 Commit: Ed Maste CommitDate: 2024-10-11 14:13:04 +0000 arm64/gicv3: Skip programming vPE GITS_BASERs to avoid a boot crash On AmpereOne, the current programming of GITS_BASER2 to individual allocations per ITS causes a: panic: APEI Fatal Hardware Error! This is due to the ITS reporting a BASER2_DATA_ERR error. The GIC-700 expects all GITS_BASER2.Physical_Address fields to match system-wide. Skip programming any vPE GITS_BASER registers to avoid this crash. Sponsored by: Ampere Computing LLC Reviewed by: andrew Differential Revision: https://reviews.freebsd.org/D46094 --- sys/arm64/arm64/gicv3_its.c | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/sys/arm64/arm64/gicv3_its.c b/sys/arm64/arm64/gicv3_its.c index a79706526c80..5ecd9b8c0e94 100644 --- a/sys/arm64/arm64/gicv3_its.c +++ b/sys/arm64/arm64/gicv3_its.c @@ -586,11 +586,20 @@ gicv3_its_table_init(device_t dev, struct gicv3_its_softc *sc) its_tbl_size = l1_esize * l1_nidents; its_tbl_size = roundup2(its_tbl_size, page_size); break; - case GITS_BASER_TYPE_VP: case GITS_BASER_TYPE_PP: /* Undocumented? */ case GITS_BASER_TYPE_IC: its_tbl_size = page_size; break; + case GITS_BASER_TYPE_VP: + /* + * If GITS_TYPER.SVPET != 0, the pending table is + * shared amongst the redistibutors and ther other + * ITSes. Requiring sharing across the ITSes when none + * of the redistributors have GICR_VPROPBASER.Valid==1 + * isn't specified in the architecture, but that's how + * the GIC-700 behaves. We don't handle vPE tables at + * all yet, so just skip this base register. + */ default: if (bootverbose) device_printf(dev, "Unhandled table type %lx\n",