From nobody Wed Oct 09 23:13:50 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4XP7xB2mXLz5Z6W9; Wed, 09 Oct 2024 23:13:50 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4XP7xB221Gz4k48; Wed, 9 Oct 2024 23:13:50 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1728515630; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=PfKh9LRhp+B+GykHG6V2TdxtGT4vGAQtYi8C5cpz4qY=; b=D9HXOA6fpJIG2LqZlW8/zGLO1Re3Cormy1LnTfqOibS6CprVAzRkPnQeHxOCk9M6clR5JX MGeVLZChypI9bhA8h1bH2KQcM2ueEmCMP95sZXNkMNsPbdQ+a2HMW38dHzIVTWLTdZ7H6Q EIrOEt1MQNRTi3SbpFO7CWK0n9SugV46wr+W3BdYMkk3AmsWUBEg06xH98WtlSm0y1p+AY SVtk2txIDrN1fDsceGOlqKM5CjgJOz0tNbnn/ymmRGrn/U4mCp2CMLC9nVHbmuto3yZc5W J2JCWnBpXfjj5wW2l3oY9iozBIqh7JPhm7qx6/2z5kY2CpMqhPFG3RfHBfmY5g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1728515630; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=PfKh9LRhp+B+GykHG6V2TdxtGT4vGAQtYi8C5cpz4qY=; b=Y+UuCURKewHGz+J+0gK+UoNKyQ3/4bfr7HJ3+w6dqPOXHOwwMf8PuJYgbSWbdgRV5FXlYS ikSB0v6pXip+DOXgXUEP3TJJw3hWoHLreHlaFrfwn3/vTyWkNF7sIuAFxbSOw2CkE5wT2i IuQGcoccaUmWuUB2xPYT+kyLub6uZ917/UvM8X33nSXgcPkW9ASdQLGumtGZYkLCiIkNMc kHZKJi7dyuOXr8nqIU2h9aMQnej1a5IDQcy604XqnuzOFI6/FMBkRQj3ViNzbq8zDXH6cT 5k8amnOV9kKXEzBxOuNGkXpQgpP3fs8fXY01c9Kf0dDnvT/3bA7W8qmtUzTNLg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1728515630; a=rsa-sha256; cv=none; b=J+wM4Mjq+TnhnhH8A/lrRURQZRYwlhls3qCy4e7kqe8PoTHaeMWC1nTrVZXrJKXs0I85aZ ZHLpZSSUeg5TK2L/4b4xNrt0XY/pzTIbf+zANB2kAae9dCYhUf1OEEeL1T05uH6dGtr6hH hwlxZdM4J9J4lgtz153xSb77xZwkMYg5IMzHkvCj1/VvDlc1sLIWqy+brAHwE7OOXKbeWe Pu+I/baYSFiaUneyxnITc4sXd1G4BNeCWMlB/vRg8fH1rJn65z0C0lCZigOxibHn24DvIV E0vWRA0euD/aLk2cBYc3Y65eUVFtCyzp4CVUl7dhGkfkqTkWFqjiPD8FcL6raA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4XP7xB1ckgzZJY; Wed, 9 Oct 2024 23:13:50 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 499NDotC044955; Wed, 9 Oct 2024 23:13:50 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 499NDoXS044952; Wed, 9 Oct 2024 23:13:50 GMT (envelope-from git) Date: Wed, 9 Oct 2024 23:13:50 GMT Message-Id: <202410092313.499NDoXS044952@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: "Bjoern A. Zeeb" Subject: git: a92626b33e17 - stable/14 - linux80211: fix default deflink.rx_nss List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: bz X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: a92626b33e171489e5f440644d1429297b4be573 Auto-Submitted: auto-generated The branch stable/14 has been updated by bz: URL: https://cgit.FreeBSD.org/src/commit/?id=a92626b33e171489e5f440644d1429297b4be573 commit a92626b33e171489e5f440644d1429297b4be573 Author: Mikhail Pchelin AuthorDate: 2024-09-06 18:04:52 +0000 Commit: Bjoern A. Zeeb CommitDate: 2024-10-09 19:19:21 +0000 linux80211: fix default deflink.rx_nss Native Linux implementation sets this as a maximum between 1 and ht/vht/eht rx SS'es, FreeBSD does the same, but uses 0 as a minimum, which leads setting it to 0 if we're not in ht/vht case. This 0 was breaking rtw89 driver, when it was trying to determine SS number by subtracting 1 from rx_nss and passing the value to the hardware. After this patch rtw89 association and simple ping work reliably, but more work is needed to make the driver robust with heavy traffic (iperf3) and being long idle. Reviewed by: bz Sponsored by: Future Crew LLC Differential Revision: https://reviews.freebsd.org/D46528 (cherry picked from commit f5a58c2da23930ee4870f2eb54788f4669b9aa33) --- sys/compat/linuxkpi/common/src/linux_80211.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/compat/linuxkpi/common/src/linux_80211.c b/sys/compat/linuxkpi/common/src/linux_80211.c index 34e40b961bed..56bc9252511a 100644 --- a/sys/compat/linuxkpi/common/src/linux_80211.c +++ b/sys/compat/linuxkpi/common/src/linux_80211.c @@ -348,7 +348,7 @@ lkpi_lsta_alloc(struct ieee80211vap *vap, const uint8_t mac[IEEE80211_ADDR_LEN], sta->deflink.smps_mode = IEEE80211_SMPS_OFF; sta->deflink.bandwidth = IEEE80211_STA_RX_BW_20; - sta->deflink.rx_nss = 0; + sta->deflink.rx_nss = 1; ht_rx_nss = 0; #if defined(LKPI_80211_HT)