From nobody Wed Oct 02 19:56:00 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4XJlt859l7z5Y1YW; Wed, 02 Oct 2024 19:56:00 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4XJlt84c21z4ZTn; Wed, 2 Oct 2024 19:56:00 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1727898960; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=JpHopi0as5pl8d4+RmePhiq519uSKuVUaIagrgudd2s=; b=XwaHRoCzEV2RugoZ6Lz4qp+PqABFzbmakJDfHcXcVAtGqM4W8e/ix91vSslCn2C650GQlN kDAgME1Uu7zBHmufqvbBn5OBicjwGjI/k/gp2pXquqULVReaA4ZncVHM5hZnWh7fR4yv3a ATVElaGYQX/Of7WVkU094rNmQIq4obGnArbp5afCiNsDvoBXipeNpoJ14lqCAVI7rNxpZ8 y15aJ3EtO2WDzzmLoYBPpv+T+khU+huCKmXHwYDPpebo/J9QChPSWTAyp/g799Ux+YcbQ8 Yo4B6aIe1J1Xal9Xp22anZ4iQ2aXQeL9UQJxJcjf0mILP82cVegfVsvsne6O9g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1727898960; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=JpHopi0as5pl8d4+RmePhiq519uSKuVUaIagrgudd2s=; b=nFW2Fi1joXEh6sZOQ9b64S8Lh16VPSc1MRJuyH1iGXZTY7Ja51m2JMnlFuZhadytjzMjpl KR4Ij0Pf1K1dlOVKFTFhIBcTYDT2v6FVQl6BtbyGoCbG4TeWUBCs1m7bKWYVOW3oGH125q pVly4PbSRk3BY6AmmbQGItCKH1KGujtEnazwrzONObUQUe8phC7e0MqhCySfjnU3+NebUv L811HngDDDGSFb++PuJKpTX1FlqSuEJhbpyrNUEaNLV8RdhcRAbBWZn+0Vax3oMpOk+gEC yRVtwHhybr1Kb8yonk4Vt98vO4wMYfkMkkRY/auhIxL9rOQl1eGHYZh4SDvK7g== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1727898960; a=rsa-sha256; cv=none; b=j1M+MYDdaJONUcbNhchPAf1ID2duG8jFv7nKomODmP6d6JQJi3Y7tKM/MdaWe6/mWFZW2G ulSPKbC1UrGbzwVj6pSF6UNq5mr6m6fTiVZBPH4xb4t9p9v3h7blLprRBkj8yxjY08i7yd wrgVl7GrIOXOmtsdJu0G4YwRFSbfaxIzZ2yyETzDCjgtDXDuLGL2pMKPrYGnOatw0PyQVf GcaQJtj463aHJcJJeus+J+VMGGakiksicRbAeVQXbFDHC1/kvB4xZ4CfZmI86laaNFEw8j Laq2cQafoR3NO3L8V484zEyCfEjYzbXaOBd1eJUPjMeYeKP1ceVCnKgSzZMVcg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4XJlt84CKLzKHF; Wed, 2 Oct 2024 19:56:00 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 492Ju09S061527; Wed, 2 Oct 2024 19:56:00 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 492Ju0Nr061524; Wed, 2 Oct 2024 19:56:00 GMT (envelope-from git) Date: Wed, 2 Oct 2024 19:56:00 GMT Message-Id: <202410021956.492Ju0Nr061524@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Kevin Bowling Subject: git: 8688a242b515 - stable/13 - e1000: Add sysctl for igb(4) DMA Coalesce List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kbowling X-Git-Repository: src X-Git-Refname: refs/heads/stable/13 X-Git-Reftype: branch X-Git-Commit: 8688a242b51535c0860e06a98ca00bd94fc95254 Auto-Submitted: auto-generated The branch stable/13 has been updated by kbowling: URL: https://cgit.FreeBSD.org/src/commit/?id=8688a242b51535c0860e06a98ca00bd94fc95254 commit 8688a242b51535c0860e06a98ca00bd94fc95254 Author: Kevin Bowling AuthorDate: 2024-09-24 10:25:24 +0000 Commit: Kevin Bowling CommitDate: 2024-10-02 19:55:12 +0000 e1000: Add sysctl for igb(4) DMA Coalesce This feature can increase efficiency at the expense of latency It does not work well with the default interrupt delay, but expose the otherwise unconnected code in the driver in case people want to experiment. See https://www.intel.com/content/dam/support/us/en/documents/network/adapter/pro100/sb/466827_intel_r__dma_coalescing_white_paper_v003.pdf Sponsored by: Blue Box Systems (cherry picked from commit c9021340a3266f924bf721182f14f2d265d8a82c) --- sys/dev/e1000/if_em.c | 56 +++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 56 insertions(+) diff --git a/sys/dev/e1000/if_em.c b/sys/dev/e1000/if_em.c index c328d03dca83..6d9eedae3df4 100644 --- a/sys/dev/e1000/if_em.c +++ b/sys/dev/e1000/if_em.c @@ -354,6 +354,7 @@ static void em_enable_vectors_82574(if_ctx_t); static int em_set_flowcntl(SYSCTL_HANDLER_ARGS); static int em_sysctl_eee(SYSCTL_HANDLER_ARGS); +static int igb_sysctl_dmac(SYSCTL_HANDLER_ARGS); static void em_if_led_func(if_ctx_t, int); static int em_get_regs(SYSCTL_HANDLER_ARGS); @@ -857,6 +858,12 @@ em_if_attach_pre(if_ctx_t ctx) CTLTYPE_INT | CTLFLAG_RW | CTLFLAG_NEEDGIANT, sc, 0, em_get_rs, "I", "Dump RS indexes"); + if (hw->mac.type >= e1000_i350) { + SYSCTL_ADD_PROC(ctx_list, child, OID_AUTO, "dmac", + CTLTYPE_INT | CTLFLAG_RW, sc, 0, + igb_sysctl_dmac, "I", "DMA Coalesce"); + } + scctx->isc_tx_nsegments = EM_MAX_SCATTER; scctx->isc_nrxqsets_max = scctx->isc_ntxqsets_max = em_set_num_queues(ctx); if (bootverbose) @@ -4975,6 +4982,55 @@ em_set_flowcntl(SYSCTL_HANDLER_ARGS) return (error); } +/* + * Manage DMA Coalesce: + * Control values: + * 0/1 - off/on + * Legal timer values are: + * 250,500,1000-10000 in thousands + */ +static int +igb_sysctl_dmac(SYSCTL_HANDLER_ARGS) +{ + struct e1000_softc *sc = (struct e1000_softc *) arg1; + int error; + + error = sysctl_handle_int(oidp, &sc->dmac, 0, req); + + if ((error) || (req->newptr == NULL)) + return (error); + + switch (sc->dmac) { + case 0: + /* Disabling */ + break; + case 1: /* Just enable and use default */ + sc->dmac = 1000; + break; + case 250: + case 500: + case 1000: + case 2000: + case 3000: + case 4000: + case 5000: + case 6000: + case 7000: + case 8000: + case 9000: + case 10000: + /* Legal values - allow */ + break; + default: + /* Do nothing, illegal value */ + sc->dmac = 0; + return (EINVAL); + } + /* Reinit the interface */ + em_if_init(sc->ctx); + return (error); +} + /* * Manage Energy Efficient Ethernet: * Control values: