From nobody Wed Nov 27 02:14:26 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4XyjgQ68mqz5fN1n; Wed, 27 Nov 2024 02:14:26 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4XyjgQ3s9lz4gG6; Wed, 27 Nov 2024 02:14:26 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1732673666; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=HSj5W+jx9z8gLDc5q0+GE4OS2w2LguxPRtSuMCbLKhg=; b=Yx5sykirwdC7q1VerpNsuTzTlZY0P1rQMVOUHwEnv3C7rUJp31tFGwBT48W5wiCeP9+ojb otudT1MJJXHQbNEPhRyT6YgQA8Y1/aw5Apw3IcxC0FuZ2PtYWL9l11XBZBe7GtIPvl7kHI gkzcVkc+akZBzQ06e17dEBt1x/hERCBGaKa2j5vy8naCh2wFcTUAAz8DZLBvlE85rYnlnu 5a9xZeFGG/wPkHQuTYkWplXjHpAa1yOY5pYLTvnzRfkVVJS0YoWWh2z54xCUHDC7/jso/3 Y/rG932dQBar5/jsBvVsbrbGol69+83mg+y6+gaPz1aAZHjY8CZg6zTJDIy/wg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1732673666; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=HSj5W+jx9z8gLDc5q0+GE4OS2w2LguxPRtSuMCbLKhg=; b=kqTyXnH9yhe0KTWqe992PqMG5Q7+unL6eSlQWxN78PXXc+1iiXlSJSV4Mz5ZOe+uEKklZ/ BgE+Tm55VG5iNmrWrUKcwhPtiAzC3+IXaG2+qY84Jjo09Dn5lWHrttgtlYD4mDeuxxxj6k 0ne6TM5adxz/RBp+g1KxVbfPTGSg5NL5yryGofdg3Z0YkfsScqPOa0/bBIY4d3b0+o2YzJ 8mgkIgNVS4lSE0tJ7gnwknc/vRA3eKhNMi+0/PCCnZ+cgxBULiQZGd4iURgP3CRs3zOxxF tQx43Meyuqt4HXxF2YnEK4kseZZyRWmNGwC9PJ37xk0T6nwcNxALJzi0Nm8oVQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1732673666; a=rsa-sha256; cv=none; b=qyDSB3ppgsKc4x4DwqrI7ssdPEGhinfE7FQNd2ASb41UlOaq1R+Rdkvt5+DgHSYWYXZnwP A7LPHuzcdqC8IdW8UQjFVZHD5l+K259e8Z3526azDZJrgSLrUdQxHlrQ8RscvsDhbTRP2h bUW4IY5loOo8yVIUfZoSsSA9JQOdqb3cyjZ4S7OcGnAFJpMMmAi0ABib5tFzp0z+lfXK5c FvJ4dcvC6qz+rT3HWnNrfdTA5kkPTxv18S6e+OJ9Qs64TMKvN6TjWmMWwWT20w+Yf8qZLZ e0ZRtELUeGlYJ8T9hjbKdF3Tdtg7SH0ODBd24z9QTY0xxOvBD1c7UIi3dKib1w== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4XyjgQ2Xc5zqbt; Wed, 27 Nov 2024 02:14:26 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 4AR2EQKf066828; Wed, 27 Nov 2024 02:14:26 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 4AR2EQla066823; Wed, 27 Nov 2024 02:14:26 GMT (envelope-from git) Date: Wed, 27 Nov 2024 02:14:26 GMT Message-Id: <202411270214.4AR2EQla066823@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Kevin Bowling Subject: git: 8de3ffc1c780 - stable/13 - ixgbe: Do not count L3/L4 checksum errors as input errors List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kbowling X-Git-Repository: src X-Git-Refname: refs/heads/stable/13 X-Git-Reftype: branch X-Git-Commit: 8de3ffc1c78009162dbcfe0c82f56526394bc884 Auto-Submitted: auto-generated The branch stable/13 has been updated by kbowling: URL: https://cgit.FreeBSD.org/src/commit/?id=8de3ffc1c78009162dbcfe0c82f56526394bc884 commit 8de3ffc1c78009162dbcfe0c82f56526394bc884 Author: Andrew Gallatin AuthorDate: 2023-02-02 15:02:44 +0000 Commit: Kevin Bowling CommitDate: 2024-11-27 01:13:56 +0000 ixgbe: Do not count L3/L4 checksum errors as input errors NIC input errors have traditionally indicated problems at the link level (crc errors, runts, etc). People tend to build monitoring infrastructure around such errors in order to monitor for bad network hardware. When L3/L4 checksum errors are included in the category of input errors, it breaks such monitoring, as these errors can originate anywhere on the internet, and do not necessarily indicate faulty local network hardware. Reviewed by: erj, glebius Differential Revision: https://reviews.freebsd.org/D38346 Sponsored by: Netflix (cherry picked from commit 8de48df35c3bf4800176b7aa54c75a01864d458b) --- sys/dev/ixgbe/if_ix.c | 9 ++------- sys/dev/ixgbe/ixgbe.h | 1 - 2 files changed, 2 insertions(+), 8 deletions(-) diff --git a/sys/dev/ixgbe/if_ix.c b/sys/dev/ixgbe/if_ix.c index d79972e0788d..3639adc0feba 100644 --- a/sys/dev/ixgbe/if_ix.c +++ b/sys/dev/ixgbe/if_ix.c @@ -1660,21 +1660,16 @@ ixgbe_update_stats_counters(struct ixgbe_softc *sc) * Aggregate following types of errors as RX errors: * - CRC error count, * - illegal byte error count, - * - checksum error count, * - missed packets count, * - length error count, * - undersized packets count, * - fragmented packets count, * - oversized packets count, * - jabber count. - * - * Ignore XEC errors for 82599 to workaround errata about - * UDP frames with zero checksum. */ IXGBE_SET_IERRORS(sc, stats->crcerrs + stats->illerrc + - (hw->mac.type != ixgbe_mac_82599EB ? stats->xec : 0) + - stats->mpc[0] + stats->rlec + stats->ruc + stats->rfc + stats->roc + - stats->rjc); + stats->mpc[0] + stats->rlec + stats->ruc + stats->rfc + + stats->roc + stats->rjc); } /* ixgbe_update_stats_counters */ /************************************************************************ diff --git a/sys/dev/ixgbe/ixgbe.h b/sys/dev/ixgbe/ixgbe.h index 3b8782bec6ed..5141e9d27003 100644 --- a/sys/dev/ixgbe/ixgbe.h +++ b/sys/dev/ixgbe/ixgbe.h @@ -510,7 +510,6 @@ struct ixgbe_softc { "\nSum of the following RX errors counters:\n" \ " * CRC errors,\n" \ " * illegal byte error count,\n" \ - " * checksum error count,\n" \ " * missed packet count,\n" \ " * length error count,\n" \ " * undersized packets count,\n" \