From nobody Tue Nov 26 15:35:29 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4XyRVB16G9z5fcTP; Tue, 26 Nov 2024 15:35:30 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4XyRVB0Kkpz4j63; Tue, 26 Nov 2024 15:35:30 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1732635330; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=z/4AAkGk1Hkp4wGtqSGWr8iTVC5Jp5p+W1/MOwNIvW0=; b=GzinPBoQ9J0ao6iW/Cq6+C3IRnWmTfg1X9DcudC0NtgGfU3HJYRtm80fNSAb7N8agf7psa sYec6a62HbWAOuj4Qi4XIDDpCEJaikaycEQPgOf69nU7nkhJrpzsTPtLmIjnqqSdrDsVDm Lw2G82UdUuuOPQzi2L7/tcgs1lhj6wgU8TGI5UUPNcGIpl1k+gbIQ+HXFvZlR4Hgr+JSvp BLZC+1Q21R2neGAepH3McJVZlXHAZaW9dKIwe8JqQKh80gKOLi6IBfM6WAzJY8SCxoZ5cs zEMj+UsPGU4zwDyFATiYmZVhzB4ZmmUbgaRZyPHDUk/kStFKE7CTxZ7y3Fov6A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1732635330; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=z/4AAkGk1Hkp4wGtqSGWr8iTVC5Jp5p+W1/MOwNIvW0=; b=ZTqr13NLY1n4vKJVXSsIpoWGyHI1RDKlhFopH60DyIH+9MLzChI9KItoOa0+kddAcAz+pv Majdmj/Lj1WK3Wcc2RyYglkkIptKrB9uLt7ePYNsJKtLCgeUd3XZl662/sIZoEDYlcpj9p vaIHdIeqdZhicoyg4kJcFYSXT/wR1xG8UFez5nDnhF7wH1tXCbp5Gj6Qw6FWIcyY2kzq41 ZJjCBXJWC7NMW3DCMX+valcJsvgV97a7ZRfLnwDbcNzfJlItt20BypTWrlMC+uJMysSydm 7iD2NGI3/+US538ORbbcM1xgU4dOG6Sp/SHyHy45rNflgK0m/V+bkCMFWu9hxw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1732635330; a=rsa-sha256; cv=none; b=axSSCyUHBqlKzaVWTzgm7kEhq4Dz9GsmaoZR0Fa2HTQk5OLZgqeDIr05GmRcYIikhqAj2i mcINxdLvVRrKzNYvayOpmM4egVW3myKenuLpniElnoZ5FtcTzq+FUBHUcU8Xxf4JuxIWip sCng1MP00EZdkcbqcK1duJcWSaQofpB8uftosNlX5Ps9usIQGfULXnTl8I/+nTHBi8u6mi SoFCkWsKYimal9WOMTiB8DbuhiXDW1N/MERVGOG9EDWISpPUPdwqdg0YpOKMg3224WI2TD 61wsdCD9oM/v/Rjl1H9NaWCOn0rsLdPAslziPcw4F54Ug2N4gSAaiu1XC7g3+g== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4XyRV972ghzX0r; Tue, 26 Nov 2024 15:35:29 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 4AQFZTYu075847; Tue, 26 Nov 2024 15:35:29 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 4AQFZTE4075844; Tue, 26 Nov 2024 15:35:29 GMT (envelope-from git) Date: Tue, 26 Nov 2024 15:35:29 GMT Message-Id: <202411261535.4AQFZTE4075844@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Zhenlei Huang Subject: git: 770498cf8bdc - stable/13 - pvscsi: maximum target number is one less than number of targets List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: zlei X-Git-Repository: src X-Git-Refname: refs/heads/stable/13 X-Git-Reftype: branch X-Git-Commit: 770498cf8bdce4d0909093a4ebd4cab104fa0ff2 Auto-Submitted: auto-generated The branch stable/13 has been updated by zlei: URL: https://cgit.FreeBSD.org/src/commit/?id=770498cf8bdce4d0909093a4ebd4cab104fa0ff2 commit 770498cf8bdce4d0909093a4ebd4cab104fa0ff2 Author: Yuri Pankov AuthorDate: 2023-05-05 09:48:57 +0000 Commit: Zhenlei Huang CommitDate: 2024-11-26 15:32:47 +0000 pvscsi: maximum target number is one less than number of targets Fix the number of targets we inquiry to be one less than the maximum number of targets adapter reports. This gets rid of the errors reported on VMware Workstation: (probe36:pvscsi0:0:65:0): INQUIRY. CDB: 12 00 00 00 24 00 (probe36:pvscsi0:0:65:0): CAM status: CCB request completed with an error While here, print the maximum number of targets. Reviewed by: imp Differential Revision: https://reviews.freebsd.org/D39867 (cherry picked from commit 6abf81b3d6747da0baa90860d5a6e929c97c9bb9) --- sys/dev/vmware/pvscsi/pvscsi.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/sys/dev/vmware/pvscsi/pvscsi.c b/sys/dev/vmware/pvscsi/pvscsi.c index f7d49c62372e..b3be2280eb5e 100644 --- a/sys/dev/vmware/pvscsi/pvscsi.c +++ b/sys/dev/vmware/pvscsi/pvscsi.c @@ -1410,7 +1410,7 @@ finish_ccb: cpi->hba_misc = PIM_NOBUSRESET | PIM_UNMAPPED; cpi->hba_eng_cnt = 0; /* cpi->vuhba_flags = 0; */ - cpi->max_target = sc->max_targets; + cpi->max_target = sc->max_targets - 1; cpi->max_lun = 0; cpi->async_flags = 0; cpi->hpath_id = 0; @@ -1682,6 +1682,7 @@ pvscsi_attach(device_t dev) PVSCSI_MAX_REQ_QUEUE_DEPTH); device_printf(sc->dev, "Use Msg: %d\n", sc->use_msg); + device_printf(sc->dev, "Max targets: %d\n", sc->max_targets); device_printf(sc->dev, "REQ num pages: %d\n", sc->req_ring_num_pages); device_printf(sc->dev, "CMP num pages: %d\n", sc->cmp_ring_num_pages); device_printf(sc->dev, "MSG num pages: %d\n", sc->msg_ring_num_pages);