From nobody Wed Nov 20 14:52:06 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Xtkpv0w0tz5dMwF; Wed, 20 Nov 2024 14:52:07 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Xtkpv0S3yz45rS; Wed, 20 Nov 2024 14:52:07 +0000 (UTC) (envelope-from jhb@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1732114327; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Z7OTbtuRdLsueUOu9YiGj593FsGPx+Se4Ju3wlSbiDg=; b=LWHxfKCc2wCkyJAQtxMshW8yzsb6bCyi+8LgQR2bc+xFIxq1Sy7LoHUAQxgRDO3Mg2xXUE CobSqiwDc/1l9Ja5D2rrnD+AXBptHikjjNQ1SjvGfIJpWAv0MsGNlDJwznMJHhUUABzHam 3jbZ3wcjAkX5uTG+Op7lhy+jMGPVl2js81E7r623N9ayoxsByvi1nWd8rAYETiCl/VcQMm zPfkh1yuAtTxABMIxTTQxPFl9E1c9pDj8oa+0obp6h2BkIRmnc1qMx9vKYqksy5V79JsoA 1cKQYeLLR9yCFfGUsqBzaQ/53COrEHvlw3d5J4wPt3WWAWYCEMEk+iioSgKluw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1732114327; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Z7OTbtuRdLsueUOu9YiGj593FsGPx+Se4Ju3wlSbiDg=; b=llqGgwQHxTgFtFc/nbBJQi2u5YnZMM3MR6eQoBowpj1ukMKnXgX9rTzslWSH2dZFM59Z9h mEtk4wBsk//vWk58r1+kFYB5O3+4/YlAjx15Sm74s8bGOIKrCxbNwnBRyyNAKXcKzGk7mB CSbIJtnB3iUpOWKXNPCC6TY/KPY1TSz1VU4p9OWzoIzFurn3GFqF6y8TKd1N+gSkm05Pc3 K8yY94faVvwGLLIA5/IAzdioV8O5EYddu6H8edx+4YUfpwjbwz0SX+0D19MwvLW8YnAZHl VHuUGhzcf8fthY29GDiZuwa34TeHC9c+/UjFk1It7/sNmkKot7kcHotFksZA5w== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1732114327; a=rsa-sha256; cv=none; b=P7RXfdn4/rEesMmSbAFALP2tiPwfwa5ObxmWTD7BmJOCmQdBShSHeNCgKDZhKXkNd7fVoX 0sqTraNh22BWrHjAgiLycLoyzn/pzwNAkkCIBXBCISRp3DftE29npZvsL9P+FRGq6ZZYtz y3RVvCzyi0oLVyfKRScUrGnTwD5w040UQzwPBFdPBgpeUdgdZ0fMuw5Bn5tB+6xuad+K+S GBNF9eqtFIZ19UXexRRFZ0DGmVuvyO/A9lTqWN+2M1jzbwyLuAJ1UwL3gGSKdgjgWohkBm ZI/yy8oXZlsuTdsfi0PX4BAnqcf5d1EZQQNYma60Qgya7OiZH4k+xuNYmkrQUA== Received: from [IPV6:2601:5c0:4200:b830:2dc9:c321:2d58:e1d6] (unknown [IPv6:2601:5c0:4200:b830:2dc9:c321:2d58:e1d6]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id 4Xtkpt5xLCz16C7; Wed, 20 Nov 2024 14:52:06 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Message-ID: Date: Wed, 20 Nov 2024 09:52:06 -0500 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: git: b882d21558f3 - main - arm: link all .rodata variants into one output section Content-Language: en-US To: mmel@FreeBSD.org, src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org References: <202411171136.4AHBaK2D056199@gitrepo.freebsd.org> <0e6393a7-0624-4a24-8537-60917728ae8a@FreeBSD.org> <2ba6363f-3ff9-451d-8843-6bb6abe6a3ac@FreeBSD.org> From: John Baldwin In-Reply-To: <2ba6363f-3ff9-451d-8843-6bb6abe6a3ac@FreeBSD.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 11/19/24 08:02, Michal Meloun wrote: > > > On 19.11.2024 16:15, John Baldwin wrote: >> On 11/17/24 03:36, Michal Meloun wrote: >>> The branch main has been updated by mmel: >>> >>> URL: https://cgit.FreeBSD.org/src/commit/? >>> id=b882d21558f37e6a565694ac9b8f2a519e5b86fa >>> >>> commit b882d21558f37e6a565694ac9b8f2a519e5b86fa >>> Author:     Michal Meloun >>> AuthorDate: 2024-11-17 11:28:47 +0000 >>> Commit:     Michal Meloun >>> CommitDate: 2024-11-17 11:35:55 +0000 >>> >>>      arm: link all .rodata variants into one output section >>>      MFC after:      1 week >>> --- >>>   sys/conf/ldscript.arm | 2 +- >>>   1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/sys/conf/ldscript.arm b/sys/conf/ldscript.arm >>> index d9edcfac9f78..7cf904ce39ff 100644 >>> --- a/sys/conf/ldscript.arm >>> +++ b/sys/conf/ldscript.arm >>> @@ -17,7 +17,7 @@ SECTIONS >>>     _etext = .; >>>     PROVIDE (etext = .); >>>     .fini      : { *(.fini)    } =0x9090 >>> -  .rodata    : { *(.rodata) *(.gnu.linkonce.r*) } >>> +  .rodata    : { *(.rodata*) *(.gnu.linkonce.r*) } >>>     .rodata1   : { *(.rodata1) } >> >> Is this line now spurious or do linker scripts prefer more exact matches? >> >>>      .interp     : { *(.interp)     } >>>     .hash          : { *(.hash)        } >> > Right hit. I want write { *(.rodata) *(.rodata.*) *(.gnu.linkonce.r*) } > > Warner already tried to tell me the same thing, but I didn't get it :( > Btw arm64 has the same problem. > > This gives me another question. Who generates the .rodata1 section? This > section appeared in gnu ld three decades ago, with no real description. > Do we still need it? I have no idea if we still need .rodata1 (or why it exists), I was just reading the diff of the linker script. -- John Baldwin