From nobody Tue Nov 19 23:51:13 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4XtLqP6MWPz5cts1; Tue, 19 Nov 2024 23:51:13 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4XtLqP5ykCz525s; Tue, 19 Nov 2024 23:51:13 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1732060273; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Y2GAUmgTmYBJJTIjtema2a9tW0fgqdRkfBSfvslTwRc=; b=AF4O4uom38T0TnJre4vsCpWgC0L68hfxyjUkiVitZ+gxE2tY+sEsmq7APNU/Sc7mAtyoed jpOKxLqKzYpd/cqh6CJ/zn1bGQTqrxVTAWp32itwO2IFWGNOOW7b2r2r2gu1J2ByPQiX5I 5NRCKhYHMLhebuRErUFefCyrz8dHB4YZS6LJbmYzQJyb6yBeyONDI/JLvJEBdZartNx1o9 5/3qz8qz5YacS7apkg1j7hFhhMBIEk0EGUlAnyz9gL3FoK+sYBoekAjfZycvG7DxrCRwOM IKTXwr38hTaumdUupPtZhtfhSYb1pgafbzI+U1Z+/wez29lEampTCT+QDMQx8w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1732060273; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Y2GAUmgTmYBJJTIjtema2a9tW0fgqdRkfBSfvslTwRc=; b=wu7S7ff0EHu4mp+v5IQfZUekKELDXMxRBvDESegEVgLUY3Xxpc1aihk1fzIRlOzToz6910 sh25DGlpDSv5xM1XTmKn2y2R9NqgAhd2La5vFbhRIL2GC1ABQ10d5ZIISmh7dCpsm0GeQk lkjddPW22BBaIPyP50ZOizONw1WF35aVU/Jfcd1E6OXV2riRyYC9r/vlGUApVvRv4YZT/P yHelSK9cioCDPbkH+vlYokwk3qzte5Rilm+vIHMdLjX2yLx3rEJcg/Yo1oEDi1KhD4oDV0 H/tNntb56UALDZ5nSErmqy/X+Ms69ySZAl2S4iMH8C6eLNORQVcqVC4t59UB2Q== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1732060273; a=rsa-sha256; cv=none; b=E+eTXqkv+SHerJCvMVahmxW/QcNDOC9f2sMEDZDmUCbJGUHympcUX9ZWdvFSw7vpne84xv UxJZq4NKFyUMoyaUm5Tj012PcGU+YYrLesjZkMOB/efj/ZHlG5GJNGfrvOUbAkq7ErOdW3 R2KWDhbUGjxbYAsz6hFOc38mSh+xUcHj0E0yWsZ1ukdFQx4vmEZQL1GgCmTj+Uy9OONkQb HGrvjTXpsDqilaeepyOF8t1DSEJEGqNuB86GzHigt7jLH/niwMglnPFwDMnABjiPE+ZkBs iYAJDUFHaruwgVpS/BlafRy2j7UNGlCghSS1egO02vZmwj7EHwAMIm/ma9V4DA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4XtLqP5Yw9zWkJ; Tue, 19 Nov 2024 23:51:13 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 4AJNpDOY083874; Tue, 19 Nov 2024 23:51:13 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 4AJNpDGR083871; Tue, 19 Nov 2024 23:51:13 GMT (envelope-from git) Date: Tue, 19 Nov 2024 23:51:13 GMT Message-Id: <202411192351.4AJNpDGR083871@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Mark Johnston Subject: git: e03a056de0ba - main - vfs: Fix runningspace tuning after maxphys was bumped List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: e03a056de0baa06f7b38033e56a33a19526b542c Auto-Submitted: auto-generated The branch main has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=e03a056de0baa06f7b38033e56a33a19526b542c commit e03a056de0baa06f7b38033e56a33a19526b542c Author: Mark Johnston AuthorDate: 2024-11-19 23:46:24 +0000 Commit: Mark Johnston CommitDate: 2024-11-19 23:46:50 +0000 vfs: Fix runningspace tuning after maxphys was bumped The previous maximum value for the upper watermark was based on the old value of MAXPHYS. Raise it to allow more parallel I/O on large systems. This is still a rather flawed mechanism since it's applied without regard to the number of filesystems or block devices between which this mechanism sits, but we might as well bump the limits at this point, as they haven't been revised in quite a long time. Reviewed by: imp, kib MFC after: 2 weeks Fixes: cd8537910406 ("Make MAXPHYS tunable. Bump MAXPHYS to 1M.") Differential Revision: https://reviews.freebsd.org/D47398 --- sys/kern/vfs_bio.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/sys/kern/vfs_bio.c b/sys/kern/vfs_bio.c index 62b0567f269a..10ee88328875 100644 --- a/sys/kern/vfs_bio.c +++ b/sys/kern/vfs_bio.c @@ -1253,15 +1253,16 @@ bufinit(void) bufspacethresh = lobufspace + (hibufspace - lobufspace) / 2; /* - * Note: The 16 MiB upper limit for hirunningspace was chosen - * arbitrarily and may need further tuning. It corresponds to - * 128 outstanding write IO requests (if IO size is 128 KiB), - * which fits with many RAID controllers' tagged queuing limits. + * Note: The upper limit for hirunningspace was chosen arbitrarily and + * may need further tuning. It corresponds to 128 outstanding write IO + * requests, which fits with many RAID controllers' tagged queuing + * limits. + * * The lower 1 MiB limit is the historical upper limit for * hirunningspace. */ hirunningspace = lmax(lmin(roundup(hibufspace / 64, maxbcachebuf), - 16 * 1024 * 1024), 1024 * 1024); + 128 * maxphys), 1024 * 1024); lorunningspace = roundup((hirunningspace * 2) / 3, maxbcachebuf); /*