From nobody Tue Nov 19 16:02:06 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Xt8Q85qkGz5f9gP; Tue, 19 Nov 2024 16:02:08 +0000 (UTC) (envelope-from mmel@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Xt8Q854kgz4JQX; Tue, 19 Nov 2024 16:02:08 +0000 (UTC) (envelope-from mmel@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1732032128; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YjInUFKgv+TSA9q4YXbvygxq7pPNsQmnYlv1ElI3JYQ=; b=Qus3B35KoWfQH+5qs1k91ZSboR6GVM095Np22aq0ZAnZ9COGx3o3jmsJ7CWU4VtJPW4+H8 aJu/8sanLAT5pSAQ7wYIJl8rqnBtLBkak7h+vOP6dROZc9pGc5SiDAjIQCcCic2sM16G9h lp5Jq16SBnJqBJFTBgo+zcbfGseQNFI5oST0fJOp1PeTnISAtniIbG7rK715nYe83KkHFa zmOyxgx793hVMl1fjQlPJszxOyOE4FxIW3KNLO3jXy4NWWGLUbKejVz8sekhsYOpF7oCQa YU4epOefYQ84X4x2FVR6CPugdhH4nLIQXQwBX3pvCCs2I/C3c+9ub4d0Ni2rpg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1732032128; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YjInUFKgv+TSA9q4YXbvygxq7pPNsQmnYlv1ElI3JYQ=; b=uhTCGqRwCH93Ey+WJLlvFIY6bIjlS+3FWkshlpenOXeXPz38HYC/CwI7uAPYC2WIFEhLCB tdZhZbA++QA3+KvaGkT6JKWwnZMTOGtUcptTfHWWpHOzP5lrJP0yXjQMexfGhwGeFU7PZG EZTTIkFnuyt4UI14TfDCn5fJm5wS6LW5KA2NggnzI59aQwLv/b4tyZjA8Bj4GDuWHDhIcd JP/r9NTdCnIXHIiwBEztSPsLgKTrXUfZ4VoAuSc7XrlbxfPSm8tlZld/4EKHlIfYkzowYf sZuz1Ljm79MqNXRqsLHdJwCWCS2gF8grETcZ9SLSJlvXpCSnsggYukmDwZ5Ayw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1732032128; a=rsa-sha256; cv=none; b=ulKK1zSAmkpuq/J4iyrtlwNgUJlNQpF5RX8qs1xCeMxqlTRCjO+25mbhcawC1OGmbZ170W 5GAYivjdUXLCZgSn8DKR3OSdjFGhGHCvT8kKdaVrvbnd2N21M+2xuvmDyJGQlzKrvEIqUv 9vzle/Q5o6ikoUh1RV985hOqRvtUJVQx8yOqWg7gmdw4FG/zKAkWbSN78fbiBjLwh+iaQ/ KmSiIpI0wLLUAORqvxyIjkId2F/uZBkrkr4QV30j0PdYE/hqVD6kJcjH6IqcUIf0cWzUW7 6Jswl5In8n4Wgo21YuHx/45nDhru+PoOS9XfTBuQTNpm7b1BAtrYyv0Wl71iZQ== Received: from [192.168.168.195] (internet-251.radiolinkplus.cz [109.205.241.251]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: mmel/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4Xt8Q81FdBzKL6; Tue, 19 Nov 2024 16:02:08 +0000 (UTC) (envelope-from mmel@FreeBSD.org) Message-ID: <2ba6363f-3ff9-451d-8843-6bb6abe6a3ac@FreeBSD.org> Date: Tue, 19 Nov 2024 17:02:06 +0100 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Michal Meloun Reply-To: mmel@FreeBSD.org Subject: Re: git: b882d21558f3 - main - arm: link all .rodata variants into one output section To: John Baldwin , src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org References: <202411171136.4AHBaK2D056199@gitrepo.freebsd.org> <0e6393a7-0624-4a24-8537-60917728ae8a@FreeBSD.org> Content-Language: cs, en-US In-Reply-To: <0e6393a7-0624-4a24-8537-60917728ae8a@FreeBSD.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 19.11.2024 16:15, John Baldwin wrote: > On 11/17/24 03:36, Michal Meloun wrote: >> The branch main has been updated by mmel: >> >> URL: https://cgit.FreeBSD.org/src/commit/? >> id=b882d21558f37e6a565694ac9b8f2a519e5b86fa >> >> commit b882d21558f37e6a565694ac9b8f2a519e5b86fa >> Author:     Michal Meloun >> AuthorDate: 2024-11-17 11:28:47 +0000 >> Commit:     Michal Meloun >> CommitDate: 2024-11-17 11:35:55 +0000 >> >>      arm: link all .rodata variants into one output section >>      MFC after:      1 week >> --- >>   sys/conf/ldscript.arm | 2 +- >>   1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/sys/conf/ldscript.arm b/sys/conf/ldscript.arm >> index d9edcfac9f78..7cf904ce39ff 100644 >> --- a/sys/conf/ldscript.arm >> +++ b/sys/conf/ldscript.arm >> @@ -17,7 +17,7 @@ SECTIONS >>     _etext = .; >>     PROVIDE (etext = .); >>     .fini      : { *(.fini)    } =0x9090 >> -  .rodata    : { *(.rodata) *(.gnu.linkonce.r*) } >> +  .rodata    : { *(.rodata*) *(.gnu.linkonce.r*) } >>     .rodata1   : { *(.rodata1) } > > Is this line now spurious or do linker scripts prefer more exact matches? > >>      .interp     : { *(.interp)     } >>     .hash          : { *(.hash)        } > Right hit. I want write { *(.rodata) *(.rodata.*) *(.gnu.linkonce.r*) } Warner already tried to tell me the same thing, but I didn't get it :( Btw arm64 has the same problem. This gives me another question. Who generates the .rodata1 section? This section appeared in gnu ld three decades ago, with no real description. Do we still need it? Michal