From nobody Tue Nov 19 00:26:48 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Xslfw4ks5z5dGb4; Tue, 19 Nov 2024 00:26:48 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Xslfw3qCjz4dJy; Tue, 19 Nov 2024 00:26:48 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1731976008; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=ykZ/k6vLUdDEfqJImfhpevfJGbus9JKGUSz3MjtHaPg=; b=wqCnPB+aXuLWHlfc/f8Pa6ffDw2HfVFSPybuTmTEut6dUnIAwhmQTBwdjLlACPh4QebJS/ YzKsER+MObT4FKtinIsZnDsfaqpv3cJi3OoncFmRyjInUgXrPp935JP1Flw/fVamnWWEpi pclrEEMeMUAYQ7jGaCbHcgRhfwNDhK+bjKzIX++XTrw7hG1hW/foNG3VOYSqmy76czlVBf /W5otxPajURLuI65XeOG1TgVa4ccWyhBnLwRxORxOetYbp5+9VaxQJG1/lGkRJbg2vueAp kwtjk0pQwKrUzF2KzsOrtlHFNKa8X9nyCh9bHeYkeAIne4GKjWtT5EYuvN3GNg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1731976008; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=ykZ/k6vLUdDEfqJImfhpevfJGbus9JKGUSz3MjtHaPg=; b=OZzJAQ1f/W2hO88SypGOoe0IjPYH6yJirqLDcyTMWF5PQw3Ngyef0j3xsKCjnYc4PG+F/m MqYXp5i53WXqY1zDM20vjxct68U9XtPqPHKh+aScVMoWu7fVQiJyIPy5sSuSFngoh1PjQG waJkIIMREJd+7klS0SvDHVxbNt59GvHQo9tLeIVF65YK9jADOX7qUcYKZI3klKXNTXP1Rc RIFcCa53mxTr4fR0KT5w4ZxRtIS5E3FwPb3B6LxsCbF+QTxaXXRuIP5jLeVIwSl8c1poqS 6HuH3tgFzKgCs6TBx7tYe2J0KH8ZVOtIpX56UARZcpNA+Pv7MnaRkhGVZfLTYg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1731976008; a=rsa-sha256; cv=none; b=L3d/jN5LPz63ZvXpjbpkokPalP8vHEA9j2x2dmIT1sYeDqUcK1uJ2IUaqF6x7BGtqgDTaU cP9kRRdOb5AARXBl7Fnq1G8oS5TtwqgaYaMhByhtTBeop3W5nDieE+zBlxMnleD+EwEB47 mFoz0uqLicVmzS2behqb7DtqFWM/7Lftvw1sq21AvnnjiRP6ymnD1wnA/jXipd7xrpE9mW m2WrEXG1MfAq8Bf6ma06ADQKPxfsX08piL+c7xOZQpc1l/LkKfrLPcBXXPNatw1hyJppcm XIXO3RkMJorpuHGlkr7ZZ1mB+ExZrgEiJbJF+5gAHh4TGhIbuq9kY0qz+cDiCg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Xslfw3RKHz12Vc; Tue, 19 Nov 2024 00:26:48 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 4AJ0QmdC063751; Tue, 19 Nov 2024 00:26:48 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 4AJ0QmLK063748; Tue, 19 Nov 2024 00:26:48 GMT (envelope-from git) Date: Tue, 19 Nov 2024 00:26:48 GMT Message-Id: <202411190026.4AJ0QmLK063748@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Cy Schubert Subject: git: f9d3c2a44353 - stable/14 - ipfilter: Print the hash name when adding a hashnode fails List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: cy X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: f9d3c2a44353f3d987b5443d6fc30ee270ea0061 Auto-Submitted: auto-generated The branch stable/14 has been updated by cy: URL: https://cgit.FreeBSD.org/src/commit/?id=f9d3c2a44353f3d987b5443d6fc30ee270ea0061 commit f9d3c2a44353f3d987b5443d6fc30ee270ea0061 Author: Cy Schubert AuthorDate: 2024-11-07 15:51:12 +0000 Commit: Cy Schubert CommitDate: 2024-11-19 00:26:04 +0000 ipfilter: Print the hash name when adding a hashnode fails As with when printing errors for failed poolnodes, printing the hash node (IP address) only leads to speculation which hash pool the failed add occurred. This is especially useful when the same IP address is listed in multiple hash pools. (cherry picked from commit 8aae4220d76602f22291d7567ba0c61b9aa8c188) --- sbin/ipf/libipf/load_hashnode.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sbin/ipf/libipf/load_hashnode.c b/sbin/ipf/libipf/load_hashnode.c index 11525dc96e35..bf22edb9be87 100644 --- a/sbin/ipf/libipf/load_hashnode.c +++ b/sbin/ipf/libipf/load_hashnode.c @@ -55,7 +55,7 @@ load_hashnode(int unit, char *name, iphtent_t *node, int ttl, if (!(opts & OPT_DONOTHING)) { char msg[80]; - snprintf(msg, sizeof(msg), "%s node from lookup hash table", what); + snprintf(msg, sizeof(msg), "%s node from lookup hash table(%s)", what, name); return (ipf_perror_fd(pool_fd(), iocfunc, msg)); } return (0);