git: 125ce840bc93 - stable/14 - bsd.subdir.mk: Drop broken optimisation for realinstall parallelisation

The branch stable/14 has been updated by jrtc27:

URL: https://cgit.FreeBSD.org/src/commit/?id=125ce840bc93f9cd9286c9724bf18f951e17d3fa

commit 125ce840bc93f9cd9286c9724bf18f951e17d3fa
Author:     Jessica Clarke <jrtc27@FreeBSD.org>
AuthorDate: 2024-02-02 21:17:23 +0000
Commit:     Jessica Clarke <jrtc27@FreeBSD.org>
CommitDate: 2024-11-14 20:57:41 +0000

    bsd.subdir.mk: Drop broken optimisation for realinstall parallelisation
    
    Not all of the tree is happy for realinstall to be done in parallel. In
    particular, Makefile.inc1 uses .WAIT to force etc to be installed after
    earlier subdirectories, since etc calls into share/man's makedb to run
    makewhatis on the tree and needs all manpages to have been installed.
    Also, libexec/Makefile doesn't set SUBDIR_PARALLEL, and the link from
    ld-elf32.1 to ld-elf.1 relies on rtld-elf having been installed before
    rtld-elf32, otherwise creating the link will fail.
    
    In general, core behavioural differences like this between NO_ROOT and
    "normal" builds are also dangerous and confusing.
    
    If this optimisation is deemed important, it should be reintroduced in a
    more limited and robust manner that doesn't break the above situations.
    Until then value correctness over slight efficiency gains on high core
    count machines, the same machines where you're more likely to encounter
    issues from this optimisation.
    
    This reverts commits cd19ecdbdc87 ("Similar to r296013 for NO_ROOT,
    force SUBDIR_PARALLEL for buildworld WORLDTMP staging.") and
    b9c6f3168112 ("Add more STANDALONE_SUBDIR_TARGETS.").
    
    Found by:       CheriBSD Jenkins
    Reviewed by:    bdrewery, brooks
    Fixes:          cd19ecdbdc87 ("Similar to r296013 for NO_ROOT, force SUBDIR_PARALLEL for buildworld WORLDTMP staging.")
    Fixes:          b9c6f3168112 ("Add more STANDALONE_SUBDIR_TARGETS.")
    MFC after:      1 week
    Differential Revision:  https://reviews.freebsd.org/D43705
    
    (cherry picked from commit fbae308319b7678cd9d879f60b1efd8d4c99b5eb)
---
 share/mk/bsd.subdir.mk | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/share/mk/bsd.subdir.mk b/share/mk/bsd.subdir.mk
index 72e835d97730..83cead36ade6 100644
--- a/share/mk/bsd.subdir.mk
+++ b/share/mk/bsd.subdir.mk
@@ -56,11 +56,6 @@ STANDALONE_SUBDIR_TARGETS+= \
 		installconfig installdirs installincludes installfiles print-dir \
 		maninstall manlint obj objlink
 
-# It is safe to install in parallel when staging.
-.if defined(NO_ROOT) || !empty(SYSROOT)
-STANDALONE_SUBDIR_TARGETS+= realinstall
-.endif
-
 .include <bsd.init.mk>
 
 .if ${MK_META_MODE} == "yes"