From nobody Thu Nov 14 19:41:40 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Xq9Wm5jHVz5d4HG; Thu, 14 Nov 2024 19:41:40 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Xq9Wm5GNtz41W6; Thu, 14 Nov 2024 19:41:40 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1731613300; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=j+6Bcr+CwvRFjhVn1pot9k5ZIjvDYDNoZr9i9r1wOsE=; b=x001GneoIRgI3VmRY/SIY9/6j0H78TTta+3HHJQ7+VN3eBTzakbDQEAUH/P9hYg3dz43X0 GQc49DKAy1URk4QpYCaFPY7ruJ0sBDQ66VrIlR+ZuMOwXyrJv/Q5RCt8kQDIEtlCajUrfc qxSTV0QaDNjNConiypeGd5b79xzWtESxgfwBgPz73HAn6N3Xm40pJg+aXsGEGqSHhmNhLG cgDVaeaf4+znXFe9qNeSODXDxHaxUeofdQva/q9EKXyS3VpwkIJCsK2KhUqf6cZDRZNC9m UGTGKazCRT8ElHQxnU9COXUcqWp6Dr1GewEnjSqofMyWggGPrfBFNPgDg1y8NQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1731613300; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=j+6Bcr+CwvRFjhVn1pot9k5ZIjvDYDNoZr9i9r1wOsE=; b=fSotFGliAtoV5CGDiS5uGeNIGi5Z5JHDUMv65Lv00baKtIsTzGG99+1ZE2BGrW7P5CcRrn /MbTmMYE/F+Yd1QaIyGyhqplVfWYiLTENxsi1zXvmFhZXc0y5kbpWW5mNRADv++V1azw4u aXcQmvDVkABbJx4RoME9QXnhoGwlMdy3fNXf5NzRupCjAZj0180XeraVAKOJ923oY7r8DT a8FFvMVXFjTgZ6hzeDu9E8z0ns94vygbGnz7FgEGV2bzozVDDSDCSEC3IoqXdBYrXYsEG7 sqsybeO5BttaKeaTAD3kR3mXrBVG8tlrg80HTUm7KaBpsGSPQODcJjC1p70zyw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1731613300; a=rsa-sha256; cv=none; b=NVeIRVvkeb1BKk4VUOtF6BjbuUYDptMgPoe1Lsf3Owxw6xGAsuPl2/Iqe41ClRp4Ak9Dq7 RQBZaefAaVAVnm6bIB/lBiWQiS//jxoRitoLIMLnZ/BDg93BsRrtcXR+31bivZiuHr5mvj lVuFtmgqlQQV/BlIMg/pfGkw/sOvlju+tjPABbocXI3muG0synBBNYK2XaThsc2gdY7H/d Xz8lW/ngHF8P49DZxoKzse9lXQpRXS6vgBj/rr1W5CxN+ClBnpgGRiyxDhCV0lzofF4q3A xPyN3jYVVNuqbWWm1AwjdbqXOQPFvSV8fZdNCBS/fiXq7Xw92o36j7IhV/xAKQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Xq9Wm4r22zsM4; Thu, 14 Nov 2024 19:41:40 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 4AEJfeHt037185; Thu, 14 Nov 2024 19:41:40 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 4AEJfeSe037182; Thu, 14 Nov 2024 19:41:40 GMT (envelope-from git) Date: Thu, 14 Nov 2024 19:41:40 GMT Message-Id: <202411141941.4AEJfeSe037182@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Gleb Smirnoff Subject: git: 81f08f303805 - main - siftr: remove pointless assertion List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: glebius X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 81f08f303805bcfd0a32fb34835956740c3c9a81 Auto-Submitted: auto-generated The branch main has been updated by glebius: URL: https://cgit.FreeBSD.org/src/commit/?id=81f08f303805bcfd0a32fb34835956740c3c9a81 commit 81f08f303805bcfd0a32fb34835956740c3c9a81 Author: Gleb Smirnoff AuthorDate: 2024-11-14 19:39:12 +0000 Commit: Gleb Smirnoff CommitDate: 2024-11-14 19:39:12 +0000 siftr: remove pointless assertion The assertion is correct, but isn't useful. Also it contradicts its own comment. --- sys/netinet/siftr.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/sys/netinet/siftr.c b/sys/netinet/siftr.c index ea1fbc8ff394..374b5595fcbc 100644 --- a/sys/netinet/siftr.c +++ b/sys/netinet/siftr.c @@ -597,9 +597,6 @@ siftr_findinpcb(int ipver, struct ip *ip, struct mbuf *m, uint16_t sport, { struct inpcb *inp; - /* We need the tcbinfo lock. */ - INP_INFO_WUNLOCK_ASSERT(&V_tcbinfo); - if (dir == PFIL_IN) inp = (ipver == INP_IPV4 ? in_pcblookup(&V_tcbinfo, ip->ip_src, sport, ip->ip_dst,