git: 5d24286be13a - stable/14 - ping tests: Run tests unprivileged inside a vnet

From: Jose Luis Duran <jlduran_at_FreeBSD.org>
Date: Thu, 14 Nov 2024 03:25:08 UTC
The branch stable/14 has been updated by jlduran:

URL: https://cgit.FreeBSD.org/src/commit/?id=5d24286be13a0553fd8a2024c9f4a83d33649085

commit 5d24286be13a0553fd8a2024c9f4a83d33649085
Author:     Jose Luis Duran <jlduran@FreeBSD.org>
AuthorDate: 2024-11-05 03:00:38 +0000
Commit:     Jose Luis Duran <jlduran@FreeBSD.org>
CommitDate: 2024-11-14 03:23:33 +0000

    ping tests: Run tests unprivileged inside a vnet
    
    In order to create vnet jails, atf_python needs root privileges.
    However, once the vnet is created, its privileges inside the vnet can be
    demoted, as these tests should not require root in order to pass.
    
    Reviewed by:    markj
    Approved by:    emaste (mentor)
    Fixes:  4efaf43c6fa7 ("ping: Require root user for pytests")
    MFC after:      1 week
    Differential Revision:  https://reviews.freebsd.org/D42175
    
    (cherry picked from commit 5797a03fe8a7c3355a727aaaea803ee1f42d106b)
---
 sbin/ping/tests/test_ping.py | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/sbin/ping/tests/test_ping.py b/sbin/ping/tests/test_ping.py
index 93b42d7d53bd..3f9a3aecf924 100644
--- a/sbin/ping/tests/test_ping.py
+++ b/sbin/ping/tests/test_ping.py
@@ -724,6 +724,7 @@ PING(56=40+8+8 bytes) 2001:db8::1 --> 2001:db8::2
 
     @pytest.mark.parametrize("expected", testdata)
     @pytest.mark.require_user("root")
+    @pytest.mark.require_user("unprivileged")
     def test_ping(self, expected):
         """Test ping"""
         ping = subprocess.run(
@@ -753,6 +754,7 @@ PING(56=40+8+8 bytes) 2001:db8::1 --> 2001:db8::2
 
     @pytest.mark.parametrize("expected", ping46_testdata)
     @pytest.mark.require_user("root")
+    @pytest.mark.require_user("unprivileged")
     def test_ping_46(self, expected):
         """Test ping -4/ping -6"""
         for version in [4, 6]: