From nobody Wed Nov 13 19:35:45 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4XpYRP5Ms2z5cVBX; Wed, 13 Nov 2024 19:35:45 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4XpYRP4Hm2z48x9; Wed, 13 Nov 2024 19:35:45 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1731526545; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=/3AgPLubraIcZVh+LB+vcwVX+UXXeNNmi7bn1PnJVMU=; b=RthhwY1Jj+C5A2GL26FYjx/MsYcL1TVEiYE5IwAGCdfkMoK4cJ9x5zpk52tt2FlaHWpOXV FIn1v36IbH4gpSOaaiKQVZKoTlA5rteQmj5lPwdurHFfhiyA5YR3yNV6q23EsmtOqNYbRq 0LMesS3liNr7Jj22oF+6uDk4MWNGNJT4iUUdrld2HZbJWkdACL5G8ImTdx4O9K7NPPHyWi 53mKzap2Kj4yjs2vq9AeZ1fPeVVrXDiEX9cuIODfD2nZW/yupJisGlNYmwSvp56wjHJY1b 7yFX6GZ8OL4bOfCBFVFGgt1sN9RtC/WG/7rTiEWFvbnndEOpytAMdftvCoofsw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1731526545; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=/3AgPLubraIcZVh+LB+vcwVX+UXXeNNmi7bn1PnJVMU=; b=ajHpxkWrYAyjxFyCLOVu2X1Knn54gKF9ziQlIWDnpiEvu3qL4CcH1jvYoU3+DAns7tuwGz 2N1mcK2x8Wiaju+/GHiBDD0CWIWSyp8JkVyNLAW9nNO4Vsz8iQKuCf+6YwhG5alwQUZlNh rIwgMvXjzqNk3Q7CTuisKnuJk6xIXMjb1uxdVWPuTBRcjdpbvcqmg7tdKHNJkYFD2+wlwC j+OK9jmGFb4OMXJhgA39htOPYYDzzA4Jwr8QUePEKPh4qNvhYNBJh0YT2Q88sVCar+O5Xh ysNqwgpz0R551ui3LgMfF9x5OmobzZ/yEA21lY8Yh0JbRmCtUuG1KarYi952zw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1731526545; a=rsa-sha256; cv=none; b=oHUatS+9ADOfoGrRWNRtha0eynr1XP4bg6P8TC4Kxk0TC8t4XumEjI5FJxMxDwKqnsQoAJ qttpPv2pUmBPiuPK/2pqVFzWOeCgm2JI89Y4CryWGCSjeY6R+El6lSa0lGLasFAhc8/qIk 6PnMX7UAOePn2O6t51UO1w2BXFjm5le+EcQbwmujMrYUVeu2DOhQt91mmv/kxPiAs8Yjxe /YqeyxHSuDhLxXZqJyEhSxTFRzZKxgXbVnVU0CNThIvZjKZVwgkj+7otuDagjxGcHvJFxY TdccVReCl/2haOhBwYb5fctLLjiVHnZIJErB7UQPLXc33+y5vZbrgqakzwv34w== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4XpYRP3vPMz16dG; Wed, 13 Nov 2024 19:35:45 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 4ADJZjZr050708; Wed, 13 Nov 2024 19:35:45 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 4ADJZja2050705; Wed, 13 Nov 2024 19:35:45 GMT (envelope-from git) Date: Wed, 13 Nov 2024 19:35:45 GMT Message-Id: <202411131935.4ADJZja2050705@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Konstantin Belousov Subject: git: d0b41249bfbe - main - bufwrite(): adjust the comment List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kib X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: d0b41249bfbe4481baec8f1659468ffbb30388ab Auto-Submitted: auto-generated The branch main has been updated by kib: URL: https://cgit.FreeBSD.org/src/commit/?id=d0b41249bfbe4481baec8f1659468ffbb30388ab commit d0b41249bfbe4481baec8f1659468ffbb30388ab Author: Konstantin Belousov AuthorDate: 2024-11-12 06:24:03 +0000 Commit: Konstantin Belousov CommitDate: 2024-11-13 19:35:02 +0000 bufwrite(): adjust the comment The statement about 'do not deadlock there' is false, since this write might need other writes to finish, which cannot be started due to runningbufspace. PR: 282449 Reviewed by: markj Sponsored by: The FreeBSD Foundation MFC after: 3 days --- sys/kern/vfs_bio.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/sys/kern/vfs_bio.c b/sys/kern/vfs_bio.c index 3ef715baebfa..62b0567f269a 100644 --- a/sys/kern/vfs_bio.c +++ b/sys/kern/vfs_bio.c @@ -2375,11 +2375,9 @@ bufwrite(struct buf *bp) } else if (space > hirunningspace) { /* * Don't allow the async write to saturate the I/O - * system. We will not deadlock here because - * we are blocking waiting for I/O that is already in-progress - * to complete. We do not block here if it is the update - * or syncer daemon trying to clean up as that can lead - * to deadlock. + * system. We do not block here if it is the update + * or syncer daemon trying to clean up as that can + * lead to deadlock. */ if ((curthread->td_pflags & TDP_NORUNNINGBUF) == 0 && !vp_md) waitrunningbufspace();