Re: git: 1fa6daaafd74 - main - ipfilter: Avoid stopping with a lock held

On 11/12/24 10:35, Jose Luis Duran wrote:
> What would be the recommended approach in this case?
> Revert, and commit with the fixes, or just fix the problematic code.
> 
> At any rate, I have created https://reviews.freebsd.org/D47530. Feel
> free to commandeer it, as my testing is limited to what's currently in
> the "Test Plan". I was not able to recreate the deadlock described
> here, but it definitely makes sense.

There is no deadlock in this case because it is recursing on a shared lock.

FWIW, I think your review is fine, and I would have been ok with just committing
that instead of reverting everything.

-- 
John Baldwin