From nobody Tue Nov 12 13:56:43 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Xnnyr4Tr2z5cZCX; Tue, 12 Nov 2024 13:56:52 +0000 (UTC) (envelope-from zlei@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Xnnyr2xkKz4Jq9; Tue, 12 Nov 2024 13:56:52 +0000 (UTC) (envelope-from zlei@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1731419812; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=2RjeK5XhTQOZiZKtBsTQywhtmPvWaHJTMBn7bEjasv8=; b=ffIayFYTjpGX7eUxlBl/wvpJmgH7nEobaiLiD9+oy1Nc+hP94quxTNJsFub3aXGrxs+Q55 GOq0cAGq6BGwc0QZWk8yTTjpTjpkGeEa1aiIKX/wfPkl/Vhu/hqbzZoaGLvnfxyuhsyn1d Xu+x7Y4o2TmGVEmoOz4BbjAn/eARElOH/pl/r9nYRfX2IO08RuT2pOtD+az7pJXZ6IU/DC EEzHKHwraRwNdAotsN8cKFW98Ih3Bfh3wER0njxN61f8PerLKatXy9DC6W0/DpMNzVysUK HZBexPxgZyw0Ylk0Pn+Pzvp4oVULOrsHwBZbb++oR13d9seSn/bMo7zseFwGgg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1731419812; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=2RjeK5XhTQOZiZKtBsTQywhtmPvWaHJTMBn7bEjasv8=; b=bZUbyrGye8GxA/lwxmTXrPPfWI85C9f26WLrn2odSyGEX98ECv4FLLYyJy6C3a03rLXc3z W+2zvDvtv24FM0S2jvUo2wY1ppFmsB3rUuO2jJ8k/5To/86VhDJjX+mJKOKF6rMhhLfkkH n3RQkR1wCGqJvIUggEbudtxDW6AsUFm97pCPBxNg7V/Ewiu+yKxhj93w44Dc3XtmU0H66z FA9yg0AUppNuGEDw175y9lq0aWcRCimo9fiWnIlqiNj/h17pLZ9dg5JUBmGwnn+ZDXB0Br P+sjE0NhePc1qTr33O6L0WW39WeZwW1gLTHVObENo043y6iYm0gPeqxyPvHCpg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1731419812; a=rsa-sha256; cv=none; b=VE/Oae8XcXZNAHO71f4h258Y1D7XfjOtIdDDgndLJzZkDZFVrmRkLIMgL3KqW4O5RdFilb XFcWwxx5Oc4lXK93K1ikT24+pBFjkbMeHRYfNiYPcqWwioEESpbqwb6qnPJFh66l+TKDf5 huLWF6W4Uc4nVNFwp6M9qg3GdzUFmBtKauxALAxBRewR6XRWEF1QMGHyC33ROUh2F/Ljdk pEmeTKSGCuwTMmoul+OF02poFAaDHHojy/7j97s5I+Hha/aCtRQWlBh2aWtnWGMXuQYxso Rsd1rCg7A7wuw2yoiPUsdFEWcfvPm4YLWmyuV7A4RyqvSJWDmn3lZYW2svrhrQ== Received: from smtpclient.apple (ns1.oxydns.net [45.32.91.63]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) (Authenticated sender: zlei/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4Xnnyn6DRJzhXT; Tue, 12 Nov 2024 13:56:49 +0000 (UTC) (envelope-from zlei@FreeBSD.org) From: Zhenlei Huang Message-Id: <333D66C8-12BC-43CD-B33B-B410B8B3BC22@FreeBSD.org> Content-Type: multipart/alternative; boundary="Apple-Mail=_D3B1327B-7D7C-43FD-AC3F-5C01AF6C1C6F" List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.10\)) Subject: Re: git: 9e469437993b - main - inet.4: drop "experimetal use" from net0 and net240 descriptions Date: Tue, 12 Nov 2024 21:56:43 +0800 In-Reply-To: <46spnoss-r0s0-92o3-60r7-r2o49ro82580@SerrOFQ.bet> Cc: Ed Maste , "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" To: "Bjoern A. Zeeb" References: <202411111247.4ABClC6l042813@gitrepo.freebsd.org> <46spnoss-r0s0-92o3-60r7-r2o49ro82580@SerrOFQ.bet> X-Mailer: Apple Mail (2.3696.120.41.1.10) --Apple-Mail=_D3B1327B-7D7C-43FD-AC3F-5C01AF6C1C6F Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii > On Nov 12, 2024, at 3:59 AM, Bjoern A. Zeeb wrote: >=20 > On Mon, 11 Nov 2024, Ed Maste wrote: >=20 >> The branch main has been updated by emaste: >>=20 >> URL: = https://cgit.FreeBSD.org/src/commit/?id=3D9e469437993bd17290d145fa7a615a68= b2257875 >>=20 >> commit 9e469437993bd17290d145fa7a615a68b2257875 >> Author: Ed Maste >> AuthorDate: 2024-11-10 15:41:02 +0000 >> Commit: Ed Maste >> CommitDate: 2024-11-11 12:46:58 +0000 >>=20 >> inet.4: drop "experimetal use" from net0 and net240 descriptions >>=20 >> The sysctls enable any use of 0/8 and 240/4, not only experimental = use. >>=20 >> Reviewed by: zlei >> Sponsored by: The FreeBSD Foundation >> Differential Revision: https://reviews.freebsd.org/D47506 >=20 >=20 > They are labeled "experimental" because they are in no way official = standard > or their use being endorsed by any accepted Internet Standards Body, >=20 > Officially vendors at this point are not supposed to support it. > The fact that most of them have a "simple switch" to turn it on but = off > by default as otherwise they would violate an RFC. Emm, while I was reviewing this change, I also wondered if it is too = early to remove the word *experimental* as the RFC is still in draft = status. Well later I think ( maybe I'm wrong ) RFC actually lag behind = the reality ( I'm saying FreeBSD as a vendor and move fast action ) so I = think it is OK to remove now. >=20 > I would really prefer this to be backed out until an RFC is published = or > IANA decided to re-assign the (use of the) netblock for any > official/private use. No objection. >=20 >=20 > I was fine with the original implementation if the default didn't = change > the status quo given it's experimental nature. >=20 > I'll follow-up on that in the other review. >=20 >> --- >> share/man/man4/inet.4 | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >>=20 >> diff --git a/share/man/man4/inet.4 b/share/man/man4/inet.4 >> index a12dec49caea..c9267558d6f3 100644 >> --- a/share/man/man4/inet.4 >> +++ b/share/man/man4/inet.4 >> @@ -169,10 +169,10 @@ The following general variables are defined: >> .It Va accept_sourceroute >> Boolean: enable/disable accepting of source-routed IP packets = (default false). >> .It Va allow_net0 >> -Boolean: allow experimental use of addresses in 0.0.0.0/8 as = endpoints, >> +Boolean: allow use of addresses in 0.0.0.0/8 as endpoints, >> and allow forwarding of packets with these addresses. >> .It Va allow_net240 >> -Boolean: allow experimental use of addresses in 240.0.0.0/4 as = endpoints, >> +Boolean: allow use of addresses in 240.0.0.0/4 as endpoints, >> and allow forwarding of packets with these addresses. >> .It Va curfrags >> Integer: Current number of IPv4 fragments across all reassembly = queues >>=20 >=20 > --=20 > Bjoern A. Zeeb = r15:7 --Apple-Mail=_D3B1327B-7D7C-43FD-AC3F-5C01AF6C1C6F Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=us-ascii

On Nov 12, 2024, at 3:59 AM, Bjoern A. Zeeb <bz@FreeBSD.org> = wrote:

On Mon, 11 Nov 2024, Ed Maste wrote:

The = branch main has been updated by emaste:

URL: = https://cgit.FreeBSD.org/src/commit/?id=3D9e469437993bd17290d14= 5fa7a615a68b2257875

commit = 9e469437993bd17290d145fa7a615a68b2257875
Author: =     Ed Maste <emaste@FreeBSD.org>
AuthorDate: = 2024-11-10 15:41:02 +0000
Commit: =     Ed Maste <emaste@FreeBSD.org>
CommitDate: = 2024-11-11 12:46:58 +0000

  inet.4:= drop "experimetal use" from net0 and net240 descriptions

  The sysctls enable any use of 0/8 = and 240/4, not only experimental use.

  Reviewed by:    zlei
  Sponsored by:   The FreeBSD = Foundation
  Differential Revision: https://reviews.freebsd.org/D47506


They are labeled "experimental" because they are in no way = official standard
or their use being endorsed by any accepted Internet = Standards Body,

Officially vendors at this point are not supposed to support = it.
The fact that = most of them have a "simple switch" to turn it on but off
by default as = otherwise they would violate an RFC.

Emm, while I was reviewing this change, I also = wondered if it is too early to remove the word *experimental* as the RFC = is still in draft status. Well later I think ( maybe I'm wrong ) RFC = actually lag behind the reality ( I'm saying FreeBSD as a vendor and = move fast action ) so I think it is OK to remove = now.


I would = really prefer this to be backed out until an RFC is published = or
IANA decided = to re-assign the (use of the) netblock for any
official/private use.

No objection.



I was fine = with the original implementation if the default didn't change
the status = quo given it's experimental nature.

I'll follow-up on that in the other review.

---
share/man/man4/inet.4 | 4 ++--
1 file changed, = 2 insertions(+), 2 deletions(-)

diff --git = a/share/man/man4/inet.4 b/share/man/man4/inet.4
index = a12dec49caea..c9267558d6f3 100644
--- = a/share/man/man4/inet.4
+++ b/share/man/man4/inet.4
@@ -169,10 +169,10 @@ The following general variables are = defined:
.It Va accept_sourceroute
Boolean: = enable/disable accepting of source-routed IP packets (default false).
.It Va allow_net0
-Boolean: allow experimental = use of addresses in 0.0.0.0/8 as endpoints,
+Boolean: = allow use of addresses in 0.0.0.0/8 as endpoints,
and = allow forwarding of packets with these addresses.
.It Va = allow_net240
-Boolean: allow experimental use of addresses = in 240.0.0.0/4 as endpoints,
+Boolean: allow use of = addresses in 240.0.0.0/4 as endpoints,
and allow = forwarding of packets with these addresses.
.It Va = curfrags
Integer: Current number of IPv4 fragments across = all reassembly queues


-- 
Bjoern A. = Zeeb =             &n= bsp;           &nbs= p;            =             &n= bsp;  r15:7



= --Apple-Mail=_D3B1327B-7D7C-43FD-AC3F-5C01AF6C1C6F--