git: 8b54d874c70d - main - hifn/safe: Remove dummy calls to bus_generic_detach

From: John Baldwin <jhb_at_FreeBSD.org>
Date: Tue, 05 Nov 2024 01:33:47 UTC
The branch main has been updated by jhb:

URL: https://cgit.FreeBSD.org/src/commit/?id=8b54d874c70d9fb3ed2e059f65c91b3e0eaadbd7

commit 8b54d874c70d9fb3ed2e059f65c91b3e0eaadbd7
Author:     John Baldwin <jhb@FreeBSD.org>
AuthorDate: 2024-11-05 01:31:30 +0000
Commit:     John Baldwin <jhb@FreeBSD.org>
CommitDate: 2024-11-05 01:31:30 +0000

    hifn/safe: Remove dummy calls to bus_generic_detach
    
    These drivers do not add child devices, so there's no need to try to
    detach children.
    
    Reviewed by:    imp
    Differential Revision:  https://reviews.freebsd.org/D47390
---
 sys/dev/hifn/hifn7751.c | 2 --
 sys/dev/safe/safe.c     | 1 -
 2 files changed, 3 deletions(-)

diff --git a/sys/dev/hifn/hifn7751.c b/sys/dev/hifn/hifn7751.c
index 23cf019b93a6..2e7545779b09 100644
--- a/sys/dev/hifn/hifn7751.c
+++ b/sys/dev/hifn/hifn7751.c
@@ -637,8 +637,6 @@ hifn_detach(device_t dev)
 
 	crypto_unregister_all(sc->sc_cid);
 
-	bus_generic_detach(dev);	/*XXX should be no children, right? */
-
 	bus_teardown_intr(dev, sc->sc_irq, sc->sc_intrhand);
 	/* XXX don't store rid */
 	bus_release_resource(dev, SYS_RES_IRQ, 0, sc->sc_irq);
diff --git a/sys/dev/safe/safe.c b/sys/dev/safe/safe.c
index da2afbd38fad..c512f3fc62c0 100644
--- a/sys/dev/safe/safe.c
+++ b/sys/dev/safe/safe.c
@@ -464,7 +464,6 @@ safe_detach(device_t dev)
 	mtx_destroy(&sc->sc_ringmtx);
 	safe_dma_free(sc, &sc->sc_ringalloc);
 
-	bus_generic_detach(dev);
 	bus_teardown_intr(dev, sc->sc_irq, sc->sc_ih);
 	bus_release_resource(dev, SYS_RES_IRQ, 0, sc->sc_irq);