From nobody Mon Nov 04 15:01:54 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4XhvnZ6K30z5cBL8; Mon, 04 Nov 2024 15:01:54 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4XhvnZ5tSMz4ZVS; Mon, 4 Nov 2024 15:01:54 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1730732514; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=hdjE5/WoVwNYjUCGbG3uUlHw6V/vMEl/CYuVqNK6FB8=; b=FOeHaVk9i0V/j1Fr/6m4qN/tNU9ZuyD5iaGbzPtweRemw0ZRXIPLfpW7mBE1UiCjNric9P gifht+FNg5D88SwDOfh9ll2259KummclxNtmleBfVOTTYIKUqMzdT9e2DWgT3lM50M44qH 9KpWzEWpmR19KPHKSy64k05452qt7B5siuoVkynyy1Ymh30m58BTQJnXhp+OWEBhCp4kuK qwZJ+r9szH42Vmf/n9/pETaJjH653o2/wds3G+Qagf677cKES4wxs8RCLGHzPqoYnRTAWW 4c0m3IMawH0CyTUFop0k60SYj5nUxk6e7yjokH3d+fXKQ2YvpRrYLp2/51cWjA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1730732514; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=hdjE5/WoVwNYjUCGbG3uUlHw6V/vMEl/CYuVqNK6FB8=; b=irwxwzqLDjGQcfqaef2xwo6ofPLAEtdRqCvw1qBxhU+drXvhha76n1ZznqoO3wVBSSje1y AEFbf5JWubRERCFNAZe90STQY3caMIQOVMJaGFwPnsh4pVPRYDb/R9lssDGbNdoEpltor2 PkJC3TsgvK5q1aaGBnstqxBulT49m/zaCyLgbsw3eVU9Pjt26X6B5js8MR/ZOtNmIYw6ZB nrbX+uYNsPDj1w0B1W1DVPgb2y8lHHaWfB16srJUzMNQwLFam1PCNe0Szdh1H3ypHsRPfK pEN47d3FwrDULEJH3sxw2odBvfHRAXIVhtyHJgdimZyA6FOBpFp2MCj6jrf61Q== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1730732514; a=rsa-sha256; cv=none; b=cVHKSfjiItX+GZs9pldyMUfoDiHz8smXH+9naaNVJldoEDqO8LNBO6nd8sHMPLALoggXL/ TUjrJx+dEO1EEjjBxMJjvQlHNkv3UQ+i/uQW64kvErgsG5QF1XrGXw5UAifyHaky6RAoKY zW1RMmxq/IrXY5WuEWEIEFP+9PRG65B+uhsyazZWRKlfSniFZ+GB7nNzDlYmRF6393GSoX e+Ps60t32DqKUEDJJEiNfNUaYu8GGs/j3UsVOf6iuArCLegTDtcwImVpveLvAd+Kg2FQcS 0iB+wbmwvGZmC0yGS6T3OeHIyEC4peVYrryUvtDOGWRWczBCDXcJBuYr6rCRMg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4XhvnZ53p8zdDj; Mon, 4 Nov 2024 15:01:54 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 4A4F1sdo078290; Mon, 4 Nov 2024 15:01:54 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 4A4F1swx078287; Mon, 4 Nov 2024 15:01:54 GMT (envelope-from git) Date: Mon, 4 Nov 2024 15:01:54 GMT Message-Id: <202411041501.4A4F1swx078287@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Mitchell Horne Subject: git: 6e5650896fe4 - main - ice(4): properly use kernel option RSS List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: mhorne X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 6e5650896fe47398e49e3d81af60cc60dbb09e6e Auto-Submitted: auto-generated The branch main has been updated by mhorne: URL: https://cgit.FreeBSD.org/src/commit/?id=6e5650896fe47398e49e3d81af60cc60dbb09e6e commit 6e5650896fe47398e49e3d81af60cc60dbb09e6e Author: Brian Poole AuthorDate: 2024-10-11 19:57:52 +0000 Commit: Mitchell Horne CommitDate: 2024-11-04 15:01:37 +0000 ice(4): properly use kernel option RSS Header ice_rss.h uses the kernel RSS interface if option RSS is defined. However when ice_rss.h is included by ice_lib.h there is no prior inclusion of ice_opts.h to set RSS causing ifdef RSS to always fail. Add ice_opts.h to the top of ice_lib.h (like ice_iflib.h) so RSS can be defined when ice_rss.h is parsed. With that in place, compilation fails due to a missing defintion of ICE_DEFAULT_RSS_HASH_CONFIG. It is defined in ice_rss.h only when RSS is not defined. Since this define is not part of the kernel RSS interface but ice-specific, it should always be defined. Move its definition outside of ifdef RSS. PR: 255309 Reviewed by: mhorne, erj (earlier version) MFC after: 3 days Pull Request: https://github.com/freebsd/freebsd-src/pull/1460 --- sys/dev/ice/ice_lib.h | 3 +++ sys/dev/ice/ice_rss.h | 16 ++++++++-------- 2 files changed, 11 insertions(+), 8 deletions(-) diff --git a/sys/dev/ice/ice_lib.h b/sys/dev/ice/ice_lib.h index 466cb8701b79..b6b23ec82161 100644 --- a/sys/dev/ice/ice_lib.h +++ b/sys/dev/ice/ice_lib.h @@ -40,6 +40,9 @@ #ifndef _ICE_LIB_H_ #define _ICE_LIB_H_ +/* include kernel options first */ +#include "ice_opts.h" + #include #include #include diff --git a/sys/dev/ice/ice_rss.h b/sys/dev/ice/ice_rss.h index ede1fad5abe7..df485f4b1f5a 100644 --- a/sys/dev/ice/ice_rss.h +++ b/sys/dev/ice/ice_rss.h @@ -68,14 +68,6 @@ CTASSERT(ICE_AQC_GET_SET_RSS_KEY_DATA_RSS_KEY_SIZE >= RSS_KEYSIZE); #define RSS_HASHTYPE_RSS_UDP_IPV6 (1 << 9) /* IPv6 UDP 4-tuple */ #define RSS_HASHTYPE_RSS_UDP_IPV6_EX (1 << 10) /* IPv6 UDP 4-tuple + ext hdrs */ -#define ICE_DEFAULT_RSS_HASH_CONFIG \ - ((u_int)(RSS_HASHTYPE_RSS_IPV4 | \ - RSS_HASHTYPE_RSS_TCP_IPV4 | \ - RSS_HASHTYPE_RSS_UDP_IPV4 | \ - RSS_HASHTYPE_RSS_IPV6 | \ - RSS_HASHTYPE_RSS_TCP_IPV6 | \ - RSS_HASHTYPE_RSS_UDP_IPV6)) - #define rss_getkey(key) ice_get_default_rss_key(key) #define rss_getnumbuckets() (mp_ncpus) #define rss_get_indirection_to_bucket(index) (index) @@ -113,4 +105,12 @@ rss_hash2bucket(uint32_t hash_val, uint32_t hash_type, uint32_t *bucket_id) #endif /* !RSS */ +#define ICE_DEFAULT_RSS_HASH_CONFIG \ + ((u_int)(RSS_HASHTYPE_RSS_IPV4 | \ + RSS_HASHTYPE_RSS_TCP_IPV4 | \ + RSS_HASHTYPE_RSS_UDP_IPV4 | \ + RSS_HASHTYPE_RSS_IPV6 | \ + RSS_HASHTYPE_RSS_TCP_IPV6 | \ + RSS_HASHTYPE_RSS_UDP_IPV6)) + #endif /* _ICE_COMMON_COMPAT_H_ */