From nobody Sun Nov 03 16:16:54 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4XhKVZ5GkYz5cNlS; Sun, 03 Nov 2024 16:16:54 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4XhKVZ3BD5z4RsK; Sun, 3 Nov 2024 16:16:54 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1730650614; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=oVFEQHPDxa+11aiaf5UfRMRrHqQ2CyV7ILbA0tr/Ibs=; b=U0Flh1k7ace5a7edtCt25B3h5wMjwJf/GIRkcXDTQHfftUxKcWBibyDW6q1V/YfKevtsSo zsLMda9wp2gAgdlGnFoqaoM0OTdBrnFyMvuzFBzRX2BUcD9iiIS/u8E+dRHzLVqfwiGYTL TA7Tq1drcAYt1V6rzVRemlmBB/lmlNdIcs9GBkZ6RWiSGVLWOzlWqIf9xHXd8yA/PYu10p +jA4IgaenVDkWOP8zqd7fmJlbW79HqDfgyZAPRZbcdTVH3ttxB4vII+p+LOhrf6p2wzlOY c/CVE+0OhotnK7xXQfZTyx4jUuXgQpGnnwXmg6I/1ZobvGsrWhbMGaXscPIDGg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1730650614; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=oVFEQHPDxa+11aiaf5UfRMRrHqQ2CyV7ILbA0tr/Ibs=; b=Ej/KhjeX9QVq4KIWEQpMhoac4j+woPNyBi4ab87OUhXBYG2n3q4MuKamTGutDPAzVAIqk+ lmtxXk8hIR17P42tYf6RkakWdfoKtK2uzBPv3oCvhCS0xm+5zlRFI6oPnk6+dTgOOnE8nm tj44ccyR/HgEFxpHcWB99ab3zaEAy22oopIDTk2KbEgmAkb/wa2nhc4v+iVWFuxvlt4ahM Mu5DX98D0rYixwLU7c+fiVKmdCTb/b9K4PrEe6+FP6lcQfbW6OdujzMBd2prncYkHFCpL5 QbXLMG/8td4Xr1d4P/7S6mhqqCeG+m9l4XV8ta1Eyxza3ECxvlW1q0ZuA+1Jcg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1730650614; a=rsa-sha256; cv=none; b=KmPXLWQeGDBSRW85z3cuzRXZjVdURDA4CyvzUe+7ojJUl0ndlbGrXeLoArf5HldK8aTyJ3 72tckweBa7INMHdj8h+RvGzhkB/ly24lpB0q9cy0YhDyIwfGcDEfakX8HL9IwDkzavezFS hf7UJ9RJ1pm0orVLNh/9HsMOMMTFCNupo46NV0G2hpEVU2Cv9iB8Xhh8RYpyRCQSaXkAT5 L/p7iPqcL9rntECnhWs2Mjy+mL271tDFZvOzfG/3hsKKLez6W70oeGh7wAuye1D3J/BrXI Iy1Qo5DP1NmLSRGd1ReEVCmy4tYqcCeIb/aZEAX9vgevPPm+ceWnLhcOITMtaQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4XhKVZ2p0GzwHJ; Sun, 3 Nov 2024 16:16:54 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 4A3GGsB2036516; Sun, 3 Nov 2024 16:16:54 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 4A3GGsDe036513; Sun, 3 Nov 2024 16:16:54 GMT (envelope-from git) Date: Sun, 3 Nov 2024 16:16:54 GMT Message-Id: <202411031616.4A3GGsDe036513@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Colin Percival Subject: git: aeba4bd10f08 - releng/14.2 - acpi_gpiobus: Narrow scope of NOT_YET List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: cperciva X-Git-Repository: src X-Git-Refname: refs/heads/releng/14.2 X-Git-Reftype: branch X-Git-Commit: aeba4bd10f08559c599b08e4c2e9ef899e758740 Auto-Submitted: auto-generated The branch releng/14.2 has been updated by cperciva: URL: https://cgit.FreeBSD.org/src/commit/?id=aeba4bd10f08559c599b08e4c2e9ef899e758740 commit aeba4bd10f08559c599b08e4c2e9ef899e758740 Author: Colin Percival AuthorDate: 2024-10-22 18:25:11 +0000 Commit: Colin Percival CommitDate: 2024-11-03 16:15:30 +0000 acpi_gpiobus: Narrow scope of NOT_YET GPIO interrupts work just fine and will be used shortly. We still do not support GPIO_INTR_SHAREABLE however, so leave that within the NOT_YET scope. Reviwed by: andrew Approved by: re (kib) MFC after: 1 week Sponsored by: Amazon Differential Revision: https://reviews.freebsd.org/D47251 (cherry picked from commit 2d4219919a48aa6d67ae62e2b8859ffe3b035bd2) (cherry picked from commit 1f6941760746367704c9f1fa730a00b99d4d46b2) --- sys/dev/gpio/acpi_gpiobus.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/sys/dev/gpio/acpi_gpiobus.c b/sys/dev/gpio/acpi_gpiobus.c index 3b6fc6dde674..9828170daeca 100644 --- a/sys/dev/gpio/acpi_gpiobus.c +++ b/sys/dev/gpio/acpi_gpiobus.c @@ -52,8 +52,6 @@ acpi_gpiobus_convflags(ACPI_RESOURCE_GPIO *gpio_res) uint32_t flags = 0; /* Figure out pin flags */ -#ifdef NOT_YET - /* These are currently unused. */ if (gpio_res->ConnectionType == ACPI_RESOURCE_GPIO_TYPE_INT) { switch (gpio_res->Polarity) { case ACPI_ACTIVE_HIGH: @@ -69,10 +67,12 @@ acpi_gpiobus_convflags(ACPI_RESOURCE_GPIO *gpio_res) break; } +#ifdef NOT_YET + /* This is not currently implemented. */ if (gpio_res->Shareable == ACPI_SHARED) flags |= GPIO_INTR_SHAREABLE; - } #endif + } switch (gpio_res->IoRestriction) { case ACPI_IO_RESTRICT_INPUT: flags |= GPIO_PIN_INPUT;