From nobody Sun Nov 03 16:16:52 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4XhKVX4DtCz5cP08; Sun, 03 Nov 2024 16:16:52 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4XhKVX23yhz4S0q; Sun, 3 Nov 2024 16:16:52 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1730650612; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=km6TJ8A2GkXIzEzF2JLcabthYBU5AUIV1crC1qOUL9g=; b=rJWYNgxsss0GjKaR2RpzyJ0cEustCOVpvqCuvkdghsO6b4mAcLksIDyrwqIVu1TvJP9yxP Mu18eTkEkHAwQJrEtgUSjL5DihHK6x4PAtrhuamYKMiKNDwbBIQrr/8V47UABsU3S8r9M+ RH4Oj3jUhdCkYO+JvyNVzl9mVFkbVR5/+J4QyJ4fqGUElAGd9O6gNb7GsClOF5gELY9zTz ZketZ6OZ568IeJYMu6J2QzcTSWCUWyCBf+NhFl4i8KvdJWHsi9pk5LhtvdEA3qrhckKaH8 c8lOIpkELduv+TMdpF6cesqKgbhCt9hhRYEI5Pm4HRewR4W2po6bnl84jg5Y2A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1730650612; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=km6TJ8A2GkXIzEzF2JLcabthYBU5AUIV1crC1qOUL9g=; b=NCsrk7tElYtEt47xconHeQodzKrTspht6nFugDNb8mKpgkYaC915OnoZj4T1ieTc3bfSEE 5lEFH/FCibmqBmpQQf11rAq3Le6BF6IYEmccaOnKNLswhBEadvPOwn8gK90mAAqCZ/cjSA C6ZJ6JIghmEKIJxEw/MlNXop4V1W53fCrTpVudXQ3N9MlThAKHbYMD8P/tDRDTXYjxTQ+K Xc/BXJRS9aKld8Ln8kMEG/sUvOYF2N4yRkp4G0PWuKYxB6DiJpI35Vrap05RUaJD0DuQ1S FIUdi6cdilIYllUAwcLgQIS5OBmXP4ztKWrl02EaV/1rcOuaFZQiD3mthmBg3w== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1730650612; a=rsa-sha256; cv=none; b=FlFpDcaox5geNBNkuTo8hffYLdQCU0zBCtUtpsHLkf8sLmIgof9Rqvhh6/kdkx4A5ktFlU fUhrAXBs+zwcXpWBeWSLNSoqRgcFkETkoVN8HlrF/C5mlNxCqLbDVaxu0VeU34Qn8A03Ef m6ps3u0ZPSEXoaJH/27drD9HcmUpMqlW2sHx0zm1SJ7VqLKbFg0wrRq2057364jijNMYr9 Uo7QFvnXu2nWY9v22lNCdefSdn/d7GDC0W/W7wDl8+ygz65YIwQa9CU3jQCPf9MfD2o9j4 RF8MPpTM152iMMlnmGkGfs7feZ84QZW0J6ECbN34z4P8YHrs8ztflQ+JWEO8zQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4XhKVX10BnzwC0; Sun, 3 Nov 2024 16:16:52 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 4A3GGqot036433; Sun, 3 Nov 2024 16:16:52 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 4A3GGqx8036430; Sun, 3 Nov 2024 16:16:52 GMT (envelope-from git) Date: Sun, 3 Nov 2024 16:16:52 GMT Message-Id: <202411031616.4A3GGqx8036430@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Colin Percival Subject: git: 28b881840df7 - releng/14.2 - ACPI: Add ACPI_Q_AEI_NOPULL quirk and use in EC2 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: cperciva X-Git-Repository: src X-Git-Refname: refs/heads/releng/14.2 X-Git-Reftype: branch X-Git-Commit: 28b881840df7cbf9c01ddec86f45a080619efaa7 Auto-Submitted: auto-generated The branch releng/14.2 has been updated by cperciva: URL: https://cgit.FreeBSD.org/src/commit/?id=28b881840df7cbf9c01ddec86f45a080619efaa7 commit 28b881840df7cbf9c01ddec86f45a080619efaa7 Author: Colin Percival AuthorDate: 2024-10-22 14:47:30 +0000 Commit: Colin Percival CommitDate: 2024-11-03 16:15:22 +0000 ACPI: Add ACPI_Q_AEI_NOPULL quirk and use in EC2 AWS Graviton [1234] systems have a bug in their ACPI where they mark the PL061's GPIO pins as needing to be configured in PullUp mode (in fact the PL061 has no pullup/pulldown resistors); this flag needs to be removed in order for _AEI objects to be handled on these systems. Reviewed by: Ali Saidi Approved by: re (kib) MFC after: 1 week Sponsored by: Amazon Differential Revision: https://reviews.freebsd.org/D47239 (cherry picked from commit 2f3f867ac6dd7ff3769366b828b79c44b38828e1) (cherry picked from commit 5fa51c3653b14b364e26a4cce2733c7be6ee7721) --- release/tools/ec2.conf | 5 +++++ sys/dev/acpica/acpivar.h | 3 +++ 2 files changed, 8 insertions(+) diff --git a/release/tools/ec2.conf b/release/tools/ec2.conf index 522aaa400520..963c6ff4957b 100644 --- a/release/tools/ec2.conf +++ b/release/tools/ec2.conf @@ -63,6 +63,11 @@ ec2_common() { # nodes, but apply the workaround just in case. echo 'hw.broken_txfifo="1"' >> ${DESTDIR}/boot/loader.conf + # Graviton 1 through Graviton 4 have a bug in their ACPI where they + # mark the PL061's pins as needing to be configured in PullUp mode + # (in fact the PL061 has no pullup/pulldown resistors). + echo 'debug.acpi.quirks="8"' >> ${DESTDIR}/boot/loader.conf + # Load the kernel module for the Amazon "Elastic Network Adapter" echo 'if_ena_load="YES"' >> ${DESTDIR}/boot/loader.conf diff --git a/sys/dev/acpica/acpivar.h b/sys/dev/acpica/acpivar.h index afb0a6909e1a..eb6022cde159 100644 --- a/sys/dev/acpica/acpivar.h +++ b/sys/dev/acpica/acpivar.h @@ -224,12 +224,15 @@ extern struct mtx acpi_mutex; * ACPI_Q_MADT_IRQ0: Specifies that ISA IRQ 0 is wired up to pin 0 of the * first APIC and that the MADT should force that by ignoring the PC-AT * compatible flag and ignoring overrides that redirect IRQ 0 to pin 2. + * ACPI_Q_AEI_NOPULL: Specifies that _AEI objects incorrectly designate pins + * as "PullUp" and they should be treated as "NoPull" instead. */ extern int acpi_quirks; #define ACPI_Q_OK 0 #define ACPI_Q_BROKEN (1 << 0) #define ACPI_Q_TIMER (1 << 1) #define ACPI_Q_MADT_IRQ0 (1 << 2) +#define ACPI_Q_AEI_NOPULL (1 << 3) #if defined(__amd64__) || defined(__i386__) /*