From nobody Sun Nov 03 16:02:26 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4XhK9v2qWQz5cN12; Sun, 03 Nov 2024 16:02:27 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4XhK9t5glJz4MtK; Sun, 3 Nov 2024 16:02:26 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1730649746; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=xDGCNAbaP3dgJnQ4ec60qtBaEGiAKNTeTeofWPCfeEM=; b=OlgDLH6Z/w4uGlFFjtcZrgzSieWi5pLVqaJGwKLpDljKg+KVkPD9AR4mrOdMpSbzRT8s4e KMsYuZGtIWH1rENLNqZbMRKmcTR5JEYAMHdZlITD0uaFeAXhMSeR0pLUE5UkKWkNwsl5lP yNCgrD/IoSkszMDdDamORNX/OBlHVFSlYfib/7OEK6Df8xT/h4uPt8xNwJv9gOlR1sI03F jiDj9R/VlVbOgGq738eNkjtwpas6gHcF5Zvp7H8Ao9GbRpsTNA5TK9eqC+HdR5J4xrb6if 9N3w1y37JcW1linTZTPurYzgd5D7dhWlwvapHNFeUhScgvczdabYqQJmrFH9XQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1730649746; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=xDGCNAbaP3dgJnQ4ec60qtBaEGiAKNTeTeofWPCfeEM=; b=HsQsLyNIfT34u54/kYm5OpbLv7O5EvTQITWcDYq/5pKeV7NHSF7rgeb7okDKx43apjw4nD vy1pabQjS89jdsCUoSvHUgVspFbL7a1YMgY2/L2f7895wIFFtmXCH/n3K6SRxuQpVyILM3 /nznD1e92BOiVV8dY9+mN1qu0wnTEWn22uP2wumC7uJPH2UxgeOq02D0d1AOkBGg7Zc15H M+35s/sKPUIFdoUV0N0BTKNc+QwqhVhnHV0n87/66sRz5sHvGxz+nmNkjbLbK3ES7a6aI0 12VL24JE0CNWrZS96xteNzEXrBqO0T8cIzX1amUlqijLToJ4EdscEbTn0Xk3+g== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1730649746; a=rsa-sha256; cv=none; b=mJhtT1vqi4LsSxPpjpVmM5AnvWO9j/Uv1Sxj4+A1fOwA7OnKMQOJHRUP+SlaBHNNvwf01Y RBfCx3FJvtBRnW6EsOUKj2zAvydhGd5brX/9g7lZvNQLWqF5rbsT/+rQM8kDl87FHXo7xZ NR5yQ9PJwXadmLg2PYjRSWTxP6H88bsQLdmnD3RHjEgcoZQ3EM9L430nDBtRnceeKuM1cg bqCwowg7z1GtASVmDU4FUbBWwr4e8F3EWCJUiELqkEVov0VksezeOZIcDOQrcl84DuBEys guGvx1Zrsg+gpSZhGEhfcGna3y1ID+YZKST3t/ir5OLbjrBz9D0n65Z7yYzIGQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4XhK9t5G7VzwSv; Sun, 3 Nov 2024 16:02:26 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 4A3G2Qsf016675; Sun, 3 Nov 2024 16:02:26 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 4A3G2QrS016672; Sun, 3 Nov 2024 16:02:26 GMT (envelope-from git) Date: Sun, 3 Nov 2024 16:02:26 GMT Message-Id: <202411031602.4A3G2QrS016672@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Colin Percival Subject: git: 1f6941760746 - stable/14 - acpi_gpiobus: Narrow scope of NOT_YET List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: cperciva X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: 1f6941760746367704c9f1fa730a00b99d4d46b2 Auto-Submitted: auto-generated The branch stable/14 has been updated by cperciva: URL: https://cgit.FreeBSD.org/src/commit/?id=1f6941760746367704c9f1fa730a00b99d4d46b2 commit 1f6941760746367704c9f1fa730a00b99d4d46b2 Author: Colin Percival AuthorDate: 2024-10-22 18:25:11 +0000 Commit: Colin Percival CommitDate: 2024-11-03 16:01:27 +0000 acpi_gpiobus: Narrow scope of NOT_YET GPIO interrupts work just fine and will be used shortly. We still do not support GPIO_INTR_SHAREABLE however, so leave that within the NOT_YET scope. Reviwed by: andrew MFC after: 1 week Sponsored by: Amazon Differential Revision: https://reviews.freebsd.org/D47251 (cherry picked from commit 2d4219919a48aa6d67ae62e2b8859ffe3b035bd2) --- sys/dev/gpio/acpi_gpiobus.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/sys/dev/gpio/acpi_gpiobus.c b/sys/dev/gpio/acpi_gpiobus.c index 3b6fc6dde674..9828170daeca 100644 --- a/sys/dev/gpio/acpi_gpiobus.c +++ b/sys/dev/gpio/acpi_gpiobus.c @@ -52,8 +52,6 @@ acpi_gpiobus_convflags(ACPI_RESOURCE_GPIO *gpio_res) uint32_t flags = 0; /* Figure out pin flags */ -#ifdef NOT_YET - /* These are currently unused. */ if (gpio_res->ConnectionType == ACPI_RESOURCE_GPIO_TYPE_INT) { switch (gpio_res->Polarity) { case ACPI_ACTIVE_HIGH: @@ -69,10 +67,12 @@ acpi_gpiobus_convflags(ACPI_RESOURCE_GPIO *gpio_res) break; } +#ifdef NOT_YET + /* This is not currently implemented. */ if (gpio_res->Shareable == ACPI_SHARED) flags |= GPIO_INTR_SHAREABLE; - } #endif + } switch (gpio_res->IoRestriction) { case ACPI_IO_RESTRICT_INPUT: flags |= GPIO_PIN_INPUT;