Re: cfbe7a62dc62 - main - nfs, rpc: Ensure kernel credentials have at least one group

On Sun, Nov 3, 2024 at 3:33 AM Cy Schubert <Cy.Schubert@cschubert.com> wrote:
>
> CAUTION: This email originated from outside of the University of Guelph. Do not click links or open attachments unless you recognize the sender and know the content is safe. If in doubt, forward suspicious emails to IThelp@uoguelph.ca.
>
>
> In message <3070589.hHqAuc6tWs@ravel>, Olivier Certner writes:
> > --nextPart2434776.THHZn3L5Ee
> > Content-Transfer-Encoding: 7Bit
> > Content-Type: text/plain; charset="UTF-8"; protected-headers="v1"
> > From: Olivier Certner <olce@freebsd.org>
> > Date: Sun, 03 Nov 2024 11:35:53 +0100
> > Message-ID: <3070589.hHqAuc6tWs@ravel>
> > In-Reply-To: <20241103065704.4377C114@slippy.cwsent.com>
> > MIME-Version: 1.0
> >
> > I now probably know what is going on and will post a patch soon (to fix both
> > MINIMAL build and your panics).
> >
> > Is your "BREAK" kernel configuration omitting INET or NFSD?
>
> No. All it does is allow me to hit break (ctrl-e c l 1 using
> comms/com-console on serial console) to break to debugger any time while
> the server is running.
Since the nfscommon can be loaded as a module (ie. not always
present), I think you'll
need to use UID_NOBODY and GID_NOGROUP instead of nfsrv_XXX outside
of the nfs code. There is also the issue of it being NFSD_VNET(), which should
not be used outside of the NFS code. It is currently just a VNET
variable, but bz@
was thinking of changing that someday.

Sorry I didn't spot this during the review, rick

>
>
> --
> Cheers,
> Cy Schubert <Cy.Schubert@cschubert.com>
> FreeBSD UNIX:  <cy@FreeBSD.org>   Web:  https://FreeBSD.org
> NTP:           <cy@nwtime.org>    Web:  https://nwtime.org
>
>                         e^(i*pi)+1=0
>
>
>