From nobody Sun Nov 03 00:40:06 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Xgwjf3Y2wz5b5Jl; Sun, 03 Nov 2024 00:40:06 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Xgwjf2hLCz4XZV; Sun, 3 Nov 2024 00:40:06 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1730594406; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=8/m8lX1XngYKzNon9xt782wOt4Rj5iMmN0/mbtFR4GY=; b=V2j6jbSlF/UX++GdoHHIiSubQMYijppWVKL3IyjcyyVAKI/9ZnToWtazFVEINDIHCyS4bt sxMHAXdeuxpl0ZsJ795HgX3VrOIvOrBiEQ9GTbGioTx0neD6hRX6LeCg4+QlreLXhTYalt fmjkxgdslQ/8I4tAEVizOm7k3r5Ua4n+i93hNaQSVrwyFN7s18BLFTVPJ0AJ1EbbvBGaEm fjYZWHxdyiCE1UT4obnCFlRuypzy6ESJDdPFQx66VVAhKZyU561LUXhO6GOltRkIS5gcBg N1wsv88N5kgd0yHEKjHeEj6LItcfrjtobTL6yQdI54JKgC05aH28v4ICDDWyyg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1730594406; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=8/m8lX1XngYKzNon9xt782wOt4Rj5iMmN0/mbtFR4GY=; b=iOVCxz2qzFi9Tz9G5Ur9rFcoZ4I1tq+mQarNi7B0VEJoHDOU7ce+a10nrp8V7zzKb/Pc/8 mW96mvYoUDYo53zBYhohrKES0y66C2z4FT86Lz32gxJvBwS5CViEQK8MOgiApbXXqKC0fO HxZvEb2Jp/4bq8QLHlKObdK3wabV4EOxoQ0v3dQFOJ5R2wHQZU80wAXpMmIcg34yLUp4Vl myqY7r61IN4FyZXkJ9G8FIBGHmrqhfgnvYi2fh7gEXIg1YvL2/X+PKhh5e2xeCoL1ekdkz 71M8yT8vs2bp73zUbD4W5Qir8ScGhLYLhft9u0IztNa5fbiAYctd0YwcdJ7x7g== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1730594406; a=rsa-sha256; cv=none; b=jthdbKgUcIswkNLV6x3YrsfkPAXY6yKfKUn00ADMvZVbvzMrdMaqzymSOetG03R47Yw/bL /uyA6OzuckvZry3xONKhLgJZVGnYJ8PPJ6jwyUbdAU/CP/3FzepnoNuEC3uJcWXyRde5l0 9qs3Abhazq1rnKzAttdIPFOJDYEGpd/2/kdUNkihYAaMu4ePAaPvGAsRUU0nXmS3Rw3XpX g+eggq35QDBpkTjudaTXbc+i4TPugSyd6aLMrsaXtKl1CMUO9oYsTU3JTDKfvfk+DCNqAy L1KivqNn3fIbY9O24w3l5rpw+627K284ue5xbm/4ozv2CclK2v9ZxurApySYxw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Xgwjf2HYyzRls; Sun, 3 Nov 2024 00:40:06 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 4A30e6pP094303; Sun, 3 Nov 2024 00:40:06 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 4A30e6ks094297; Sun, 3 Nov 2024 00:40:06 GMT (envelope-from git) Date: Sun, 3 Nov 2024 00:40:06 GMT Message-Id: <202411030040.4A30e6ks094297@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Konstantin Belousov Subject: git: 05bc70bab4ff - stable/14 - x86: do not leak msi_lock in msix_alloc() on iommu remapping failure List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kib X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: 05bc70bab4ff1dcc3eec8d9c47d469f78c08ba9e Auto-Submitted: auto-generated The branch stable/14 has been updated by kib: URL: https://cgit.FreeBSD.org/src/commit/?id=05bc70bab4ff1dcc3eec8d9c47d469f78c08ba9e commit 05bc70bab4ff1dcc3eec8d9c47d469f78c08ba9e Author: Konstantin Belousov AuthorDate: 2024-10-27 01:39:58 +0000 Commit: Konstantin Belousov CommitDate: 2024-11-03 00:39:43 +0000 x86: do not leak msi_lock in msix_alloc() on iommu remapping failure (cherry picked from commit 439fa16e1fd35181898b61264b205bf3b7103a41) --- sys/x86/x86/msi.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sys/x86/x86/msi.c b/sys/x86/x86/msi.c index c8e7db9469ed..9d5a51f9753c 100644 --- a/sys/x86/x86/msi.c +++ b/sys/x86/x86/msi.c @@ -723,6 +723,7 @@ again: if (error != 0) { msi->msi_dev = NULL; apic_free_vector(cpu, vector, i); + mtx_unlock(&msi_lock); return (error); } msi->msi_remap_cookie = cookie;