From nobody Tue May 28 05:46:48 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4VpM2w4xZ7z5LhCC; Tue, 28 May 2024 05:46:48 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4VpM2w4MKvz4pTW; Tue, 28 May 2024 05:46:48 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1716875208; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Dkl8/5PL2RAA6SfH9/YfOEf3PcX3SbjvGO2lT5lYyg0=; b=g87UapG678f0VDgPAkIn2wiX2H8UuTaRBgceg2AUBfoRn0h/LnvdpOWOfYt38+3SjRC2nP S4xPVvMwMzhZY0GzCXYrh81Zc65CZBEVkz7x9HQrtL1BJdFSSoVQY1FAqsQJjTa7LdJdyV qQUs3LkvlId3kDUYadGe7fvrrUeGG8yh3Rq81eYC267IDTG2YOSB/iFObI5be97Z+wiVgM RxoCnmdpgvIJ+/B6lhUDfQIIaaDbA/1lP8W8cDpeN41ImQd6KIknwobhsIUDe0zxe0hgCr ywAYQseu4rSPPE/NG7TCPytSsQzXVeqfDH6JxJkd9AWhVoBVm2uThIUgYrOV9w== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1716875208; a=rsa-sha256; cv=none; b=baYuUenmi2MRaCc8fo0nz/sGssjeodI90pnYQce6DD8/zVYh2ic4UsM1r5XhkIYA3apwRu uyty3ic336Ws3Fiqf3JJ08LXQi4XcJSSDHdP9SxjxkvlXPkyXZOUKsrRbvnG6wVgmejqCu AAXsVymC73vgjwutcPx2CeTcWUGyFWzbirPlwzfivXoK9QrSRoR41OZ0cyruYjaSEEBYjB s9It3mGbOREFpYOLXmBNT048EOPKwSUTCGFiHK0QzgfahhgbZhVoDCIOsoAxjHO6BuUzCk KyC4wvOQ98qaIi1lLn0V/ojJMZdrT01Gam5sjobHqAfqtPDE01/qITTHw1axng== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1716875208; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Dkl8/5PL2RAA6SfH9/YfOEf3PcX3SbjvGO2lT5lYyg0=; b=L4nkGCidy/X6tPbzBYt+nuJaqenxAGfo05AWLjE75KTxRUAWBE6LYKPXWd+fMdciCC/ubz n47Skdooxi+X8Mp3VzAtS8yQ1oaY2tTjBGoCYBsEauotb4PtgC+zknFhBxu3JVd56YkAqC Km+Cao7uZ7em3WSZlMYuvVWmbPlWccO5blb7P/89veVxvJL1SL1ctoCi5Xo9DyErGl/YSa THhC34V20nXW2NKwYMEIdJx07nI/9DAZ058vwAUB/c8E5riY4Qgg8vBhQqeHTexy29Bobs WE2GcIAaocBgIrup8h4P6gwI/1Elk0HNljUmgi+c1mpXsXg4YwkCK8BX1LGhdQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4VpM2w3rMvz1Ftr; Tue, 28 May 2024 05:46:48 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 44S5kmv0052604; Tue, 28 May 2024 05:46:48 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 44S5kmCC052599; Tue, 28 May 2024 05:46:48 GMT (envelope-from git) Date: Tue, 28 May 2024 05:46:48 GMT Message-Id: <202405280546.44S5kmCC052599@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Kevin Bowling Subject: git: 9370f49ad1c4 - main - qlnx: qlnxe: Fix kernel address leakage List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kbowling X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 9370f49ad1c4625cd73c4d84d3e42ed3e20fabbf Auto-Submitted: auto-generated The branch main has been updated by kbowling: URL: https://cgit.FreeBSD.org/src/commit/?id=9370f49ad1c4625cd73c4d84d3e42ed3e20fabbf commit 9370f49ad1c4625cd73c4d84d3e42ed3e20fabbf Author: Fuqian Huang AuthorDate: 2024-05-28 05:45:52 +0000 Commit: Kevin Bowling CommitDate: 2024-05-28 05:45:52 +0000 qlnx: qlnxe: Fix kernel address leakage In function qlnx_rdma_deregister_if, the address of object rdma_if will be printed out. rdma_if is the address of a global variable qlnxr_drv, which is passed from dev/qlnx/qlnxr/qlnxr_os.c A kernel address leakage happens. Fix this by removing the printf statement. PR: 238646 MFC after: 1 week --- sys/dev/qlnx/qlnxe/qlnx_rdma.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/sys/dev/qlnx/qlnxe/qlnx_rdma.c b/sys/dev/qlnx/qlnxe/qlnx_rdma.c index 77b25a017ade..a69f0efd095a 100644 --- a/sys/dev/qlnx/qlnxe/qlnx_rdma.c +++ b/sys/dev/qlnx/qlnxe/qlnx_rdma.c @@ -253,8 +253,6 @@ qlnx_rdma_deregister_if(qlnx_rdma_if_t *rdma_if) int ret = 0; qlnx_host_t *ha; - printf("%s: enter rdma_if = %p\n", __func__, rdma_if); - if (mtx_initialized(&qlnx_rdma_dev_lock)) { mtx_lock(&qlnx_rdma_dev_lock); @@ -285,7 +283,6 @@ qlnx_rdma_deregister_if(qlnx_rdma_if_t *rdma_if) mtx_unlock(&qlnx_rdma_dev_lock); } - printf("%s: exit rdma_if = %p\n", __func__, rdma_if); return (ret); }