From nobody Mon May 27 15:41:29 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Vp0HY46Dgz5LMTs; Mon, 27 May 2024 15:41:29 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Vp0HY3bzYz4K4p; Mon, 27 May 2024 15:41:29 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1716824489; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=6dJuxUTqNiSTJn23MuzklGxLOTTdIW54cRqQkIMSLSQ=; b=mvKbAa4LCk32xRSqTOJbK/QmKItBPVeFDmLwPG77cwvhO1FokL7iLx+c+EBroW+ymeMMwj TNrlbslBjh9HsPfkCcP7WJMiF7V2Pb4kAJvSN1gywA0ozhdqXud+YYSFbsyy+QB9RcwVtj Qmd/JghEgd+sFXrYNfxJsnBnylUPcNfglRW9Og7wLox1bknQ4R9zc//sxDGUhy7bul+KmO Qcm0aFo9L7Mazoo/DQz3HPcqtj4iUKEfiFctrxFc4twrF/wDyQKo3t1wIBZGxsqVsEcdI+ u1bnJLRRBRC9fhdyjJbleTlqtDtYx+Y8Mf16sp6x6u7+n4JvQixyv11D4Y4H4g== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1716824489; a=rsa-sha256; cv=none; b=xjOSt6QSWI3l7O5nEjlgxt57o1ZnWJ2rwCXjEK6fY6wgSaag5HWk4YfpQB4yNEUA3A797B a5M2ndkc4OOPPiqH1uZ7Wx/jkPfepo40szYVUR7Hb1JjCgAINpxdTB99QcnJJiFMNOAeme qs7osqj+ucRyRxxqyi/A0OWkyaY0MayF+oa82FOfwLjkya1+1thXW1wR93jhtnBbZOB4Jl n6ikenWl8hPR4wKQekPZCQja/VGK8CzR3JRPgfo2x/bEtv0B3cUTZFnfZkQP4wDTcpnAk+ klNVKUMFkn+yODfdBaCkdbVLR2SX3jS9RHWh9wff7VrSwOtffGv/Dvgxw5aCjQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1716824489; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=6dJuxUTqNiSTJn23MuzklGxLOTTdIW54cRqQkIMSLSQ=; b=ULP5OzOGBJ9DyYAcOrMKJLnqJKajnugwHIEaChifXqWw1GcWn/faRV1+/Ef99Al04E4wfx 6vVJFaKHWcMddenSHQaRJmtg2VXhkf/mtGV3IkAvQqJnoPrWXS5PrjAc+v14O1Xyj8eoIy zWEd7aRstvBi08wrkJtu4peL+uiCvkaakjFvTr2hAlgufpoFdo8upGyl/82yIcPOs+1doj ugOBtInQVZ6gA5QuwfnXfO5Hs5Lb6G+RZLMk5abZvGNnsCvlXTrP88Lq54eg+ViOzjJrFM ri9HkyknQ9/vsQ8zlSzHwN4bseGCVfaM+vSLILPBjoyV5zYMNOGjWMlbKATk5Q== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Vp0HY3C9wzqmQ; Mon, 27 May 2024 15:41:29 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 44RFfTVW025344; Mon, 27 May 2024 15:41:29 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 44RFfThv025341; Mon, 27 May 2024 15:41:29 GMT (envelope-from git) Date: Mon, 27 May 2024 15:41:29 GMT Message-Id: <202405271541.44RFfThv025341@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Ed Maste Subject: git: f952f27731ee - stable/13 - Increase IOAPIC_MAX_ID to 255 (from 254) List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: emaste X-Git-Repository: src X-Git-Refname: refs/heads/stable/13 X-Git-Reftype: branch X-Git-Commit: f952f27731eea10bfa621bf8d19a1264a3244203 Auto-Submitted: auto-generated The branch stable/13 has been updated by emaste: URL: https://cgit.FreeBSD.org/src/commit/?id=f952f27731eea10bfa621bf8d19a1264a3244203 commit f952f27731eea10bfa621bf8d19a1264a3244203 Author: Ed Maste AuthorDate: 2024-05-10 17:40:59 +0000 Commit: Ed Maste CommitDate: 2024-05-27 15:25:28 +0000 Increase IOAPIC_MAX_ID to 255 (from 254) A test system provided by AMD panicked with "madt_parse_apics: I/O APIC ID 255 too high". I/O APIC ID 255 is acceptable, so increase the limit. Reviewed by: jhb, kib Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D45157 (cherry picked from commit 4e3286818327453efd8e4c133928ba26a169567a) (cherry picked from commit 18119e711f1c844bd6eacf5afc8d4cdec3ac8085) --- sys/x86/include/apicvar.h | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/sys/x86/include/apicvar.h b/sys/x86/include/apicvar.h index 0165d432be80..4d1bd4cc9cb0 100644 --- a/sys/x86/include/apicvar.h +++ b/sys/x86/include/apicvar.h @@ -78,7 +78,12 @@ #define MAX_APIC_ID 0x800 #define APIC_ID_ALL 0xffffffff -#define IOAPIC_MAX_ID xAPIC_MAX_APIC_ID +/* + * The 0xff ID is used for broadcast IPIs for local APICs when not using + * x2APIC. IPIs are not sent to I/O APICs so it's acceptable for an I/O APIC + * to use that ID. + */ +#define IOAPIC_MAX_ID 0xff /* I/O Interrupts are used for external devices such as ISA, PCI, etc. */ #define APIC_IO_INTS (IDT_IO_INTS + 16)