From nobody Thu May 23 18:37:00 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4VlcMw5sGQz5L3Zh for ; Thu, 23 May 2024 18:37:00 +0000 (UTC) (envelope-from brooks@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4VlcMw4zLHz4xhX; Thu, 23 May 2024 18:37:00 +0000 (UTC) (envelope-from brooks@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1716489420; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=gtNxrvXbKIypG0TJ7fuOPZd97+FE61NnxZyISpkQ1Vk=; b=LVyFZwZ6nttqJqUorChEKTxXT3CWg8DOj4+W9/j7+rEwwSumAGPwBSjKSBEcORyZ8Boe+o MZY9ZGP7YUe4qN5CkLTxqJMGw1sk6SmGCn/S2Vlce+xVWM7v8cAJZATErcYFmGAqBJCLYx iwitQgmEKiZWkJJ7G68oP8ST9zNiovMc1MxoJja+4u9qcvkm1SdkFDbPK8N2qWfOyW6e7S OgDC3HxSL09TMD5clfjcpCBEcII5t50IUrvuhcTYiFUAlcnOW9zbqKoj5wy4cJmHY177/7 PhTDbUL0VuJgeCxtQPurORxhbldwivUF3IEMY1vA49YL4x2+d1tmcyqy0Gw7mg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1716489420; a=rsa-sha256; cv=none; b=BQnnGl0LZeZGkZZIBqRBQaVKT/hbiCmM4UX0slHQChPGkoF7HwGe44QQAXwdvkHAsc3LZq x+OBvOs7LCbJ03Sw2tpHoRVG9YncFVIYKjZy/I0f7Ed3Qxw9CUZokeuoP9VNFzaQ29EZ7H hVhRdINfe5sX8w2ZMyFsVHwD3SFCG2wfATMHGW3g56WWATfZzEUf0osOIswqxyywKWJ5ZE +zzJhAg/LeT5uNSYRFYmszUwt/+uquCiTg2olBKz8IkJXhOIBvtFyv94kMFgnNzjw6fkrg I9Ndp0rvWbD274VT6VID352U8U/h/wruJhETl7QtNGvzvRTytCQEFK4uzgLjcg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1716489420; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=gtNxrvXbKIypG0TJ7fuOPZd97+FE61NnxZyISpkQ1Vk=; b=uVJGE8PnjcMOiZlDfhfeLmYh3ZjYVFxJ1DzuBPYEfR441nUiL52uVDH/bWzhfHOvihU/YC vc0L5L2MZvuwBOnkCEiX7l9yJ19rN0HH1VOLifslndnEBaeVhnhnK6YAgPavf5DRf3JkJ+ /5/FSGy/7TGPVXVSO9PXRF++LLZfCzn1l1Pgloa8qA+C7jPhkyE2IYSt25w6L/n8QaaykV i2pM9eVxZrZaY8hWyPcc5SNcci/NSgqRqbZJ21bxFyc0kdpQMdsPGTlr6dVudbMerXxgXt L0fDPZvTl/jn3+eX20LVXaIFW4mJAjD5QYGrHaG6ckM1JvOA2q1ER5EHLLWEbQ== Received: from spindle.one-eyed-alien.net (spindle.one-eyed-alien.net [199.48.129.229]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) (Authenticated sender: brooks/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4VlcMw4GrlzKBm; Thu, 23 May 2024 18:37:00 +0000 (UTC) (envelope-from brooks@freebsd.org) Received: by spindle.one-eyed-alien.net (Postfix, from userid 3001) id 434633C019B; Thu, 23 May 2024 18:37:00 +0000 (UTC) Date: Thu, 23 May 2024 18:37:00 +0000 From: Brooks Davis To: Gleb Smirnoff Cc: John Baldwin , Dmitry Salychev , Lexi Winter , Mariusz Zaborski , dev-commits-src-all@freebsd.org Subject: Re: generated sources Was: git: 408957613bc0 - main - Regen Message-ID: References: <3edabe3b-4b51-401f-ad64-e36c84fd455b@FreeBSD.org> List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Thu, May 23, 2024 at 11:20:08AM -0700, Gleb Smirnoff wrote: > Hi, > > sorry for slightly diverting the discussion, but looks like this thread is the > right place... > > On Wed, May 22, 2024 at 12:55:24PM -0700, John Baldwin wrote: > J> I don't think it's worth reverting at this point. For `make sysent` I would > J> suggest 'sysent: Regen' as a commit log in the future. We typically use > J> 'src.conf.5: Regen' after running `make makeman`. > > On Wed, May 22, 2024 at 05:05:14PM +0000, Brooks Davis wrote: > B> This is more or less standard practice for generated files. These > B> commits are of basically no interest. Historically they had to exist > B> because the source file $FreeBSD$ entries were embedded in the generated > B> files and thus had to be final. That isn't true any more so I often just > B> include them in the origional commit unless I'm doing a lot of minor > B> changes to the source files. > > Is it possible to generate the files during normal kernel build? That would > require lua packages installed, but we already almost require git installed to > work with FreeBSD sources. Absence of lua can be checked in Makefile and a > verbose error message would be printed. Or may be we can use the small lua that > we have in the loader? Sorry if the very last suggestion was stupid - really > don't have any knowledge in the area. TL;DR: No one likes the current state of affairs, but it's complicated to fix or we'd have done it long ago. We'd like to generate these files at build time, but at least sys/sys/syscall.mk is difficult to handle as it's required to build libc so I belive we'd need to arrange to create it before entering lib/libc. The others seem straightforward, but right now we've got a single script to generate everything and we'd want to be selective about generating things so we did it in the right place. I know there's some work in progress to turn sys/tools/makesyscalls.lua into something more library-like, but it's not done. (I've not been helping by adding things to makesyscalls.lua and thus moving the goalposts...) > After the xz/liblzma backdoor all the generated code committed manually makes > me concerned, as it has 0% chance to get reviewed by community. This is a valid, but not very practical concern. We check that these are in sync routinely in github CI and could easily factor those checks out to do in jenkins if we wanted more immediate post-commit feedback. > Just if my suggestion sounds stupid and there is a good reason to have what we > have - an automatic generation followed by a manual commit - then please > explain this reason. Not stupid, just not easy to change. -- Brooks