From nobody Thu May 23 17:29:35 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4VlZt94j4mz5Kghb; Thu, 23 May 2024 17:29:37 +0000 (UTC) (envelope-from michaelo@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4VlZt92RQ0z4q29; Thu, 23 May 2024 17:29:37 +0000 (UTC) (envelope-from michaelo@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1716485377; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=R2iniBvMdCHogYerE1wKz6FukJHvAgYh4v8TOPNJw0E=; b=GWzG6/siVsZlJdI+P7tQg9HEps8zJb+BcLBOHjKfsHgCtOSMdHPt2zDPQjrG1ST6Ao1i5h YgKoU0HgQfqXpCqrwp0z5eoauFWaJKmVyj1Yg/JQyb/CPBS/sw7lpGgAnlz7w7SELN+i5O LW8WjPBLOJRnxRUZEqoS2n376e501VexC4a78IudFbQl4iCAQauVd7hrSp+hubCNTn9Upg MS687JrMTA3jzpwr9FGBDfS9/vaceBA7Qw5efn3nhuPbCF+RVev9nvcjHgN1pytIlt2YmD pPNvKSFfDTTuaHdyrCntm14ES4bhdWmDlqnWgjrghifdf5UxPDJIwBdbGUQz2Q== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1716485377; a=rsa-sha256; cv=none; b=npB566mA0GsS7koQBDfEQbwScKGQf/tVtG7To/pXejwnNcveYUEQTny9iZltxGgHo4cRYd Gs7yaCjSr0DZbMXgtMajRZmhPK5uJU0q3ydmx1iAdfrpJ/BGMrcgu6G2/NykfdE0w7lnX6 DV9LbqqoAG/wzCNQnXmDo25Cfj0ACX0SaLjvGwuF8ov+qbPR4jLjpeV821jNDeeNW1CKnQ i5ptavNl+wie3i0vKY767A9sH9IKnbeKse7NIRbaS4a2LUeLdHALWkk4+EbqmoJsurfwDs MH1vNxTyKGuN3eqPsD5c/mE7LbkxEIkDs4UUHr+OGwsMMozyGT6fgG/PcUCRpg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1716485377; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=R2iniBvMdCHogYerE1wKz6FukJHvAgYh4v8TOPNJw0E=; b=AoRigS7doWIAKsV4mc2nGW0A5y1vzeDPDlqH3whIX0VvtndaCJVRnXKI6DxxFGexwIf9ti gCDmWu12D/EYyqSZM13pwwn1XfLhZPhLO3krj+wkm59oYzZW/n6M86KPFIRp3PiuX0NMxR Hj1vAhm81KAklyG7t2RNhNP9Ap+g+1Jemq5Fm53wAbhRuFiPuyec5FW6rRkXFRxyyE6V5D H6tTq4zKhaogESF/v+tuJjC8YA6Ed0EYK/M1/asx07v0sC+yoJRpJ65i6N8wzHuTQEcOBv 0z1C4aNYTmATKooXrSxlO8Cr2pPObBEAYIL1XkKiqtNvCoOi4rYXPKMh/iGOdQ== Received: from [192.168.1.23] (unknown [147.161.168.127]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: michaelo/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4VlZt83dNRzHVj; Thu, 23 May 2024 17:29:36 +0000 (UTC) (envelope-from michaelo@FreeBSD.org) Message-ID: Date: Thu, 23 May 2024 19:29:35 +0200 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 User-Agent: Thunderbird Daily Subject: Re: git: aa48259f3371 - main - periodic.conf: remove long deprecated security_daily_compat_var() Content-Language: en-US To: Mike Karels , Baptiste Daroussin Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org References: <202405030740.4437eWUC034126@gitrepo.freebsd.org> <648BD801-F3C0-40DD-B500-CB71177A6748@karels.net> <61c568fb-7e9d-4445-9d91-0830975bb54b@FreeBSD.org> <1AE302C8-5EED-4644-8900-6D8B91326183@karels.net> From: Michael Osipov In-Reply-To: <1AE302C8-5EED-4644-8900-6D8B91326183@karels.net> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 2024-05-23 18:05, Mike Karels wrote: > On 23 May 2024, at 10:14, Baptiste Daroussin wrote: > >> On Thu 23 May 14:34, Michael Osipov wrote: >>> On 2024-05-23 14:10, Mike Karels wrote: >>>> On 22 May 2024, at 10:07, Baptiste Daroussin wrote: >>>> >>>>> On Fri 03 May 07:40, Michael Osipov wrote: >>>>>> The branch main has been updated by michaelo: >>>>>> >>>>>> URL: https://cgit.FreeBSD.org/src/commit/?id=aa48259f337100e79933d660fec8856371f761ed >>>>>> >>>>>> commit aa48259f337100e79933d660fec8856371f761ed >>>>>> Author: Michael Osipov >>>>>> AuthorDate: 2024-04-15 11:05:17 +0000 >>>>>> Commit: Michael Osipov >>>>>> CommitDate: 2024-05-03 07:38:55 +0000 >>>>>> >>>>>> periodic.conf: remove long deprecated security_daily_compat_var() >>>>>> >>>>>> This function is documented to be gone in after 11. Time to remove this >>>>>> compat shim. >>>>>> >>>>>> PR: 275296 >>>>>> Reviewed by: jrm (mentor) >>>>>> MFC after: 1 month >>>>>> Differential Revision: https://reviews.freebsd.org/D44796 >>>>> >>>>> this broke pkg's periodic script, I would have appreciated a heads up to give me >>>>> time to prepare a release compatible prior this commit. >>>>> >>>>> This also breaks some ports. >>>>> >>>>> Bapt >>>> >>>> This produces almost a dozen failure messages in the daily security email. >>>> Given that the deprecated function was still in use, it should not be removed. >>>> Michael, please revert this. >>> >>> Salut Baptiste, >>> Hi Mike, >>> >>> this is surprising that is it still in use although clear marked as >>> deprecated after 11. Though, Baptiste has pushed a new pkg release yesterday >>> [1] and only main is affected, do you still prefer to revert this commit >>> (for now)? >>> >>> @bapt, can you name the affected ports and report a PR, so we can track >>> them? >>> >> >> This was in use beside the deprecation, because pkg for one is supposed to >> support as many version of freebsd as possible so we had to keep the deprecation >> notice. >> >> I have released a new version of pkg without it and merged that version in >> quarterly branches, so even if it gets MFCed we should be safe. >> >> I was scared more ports where keeping for the same reason the deprecated code, I >> span the ports tree itself and found one port which I fixed straight away, I >> also did a deep analysis of the any port which plist contains etc/periodic, >> I extracted all their sources and I found nothing. >> >> so I think we are safe now. I don't think we should revert. >> >> Best regards, >> Bapt > > OK, I'll withdraw my request to revert if we're confident that there are no > stragglers. Alright, thank you folks. We'll keep as-is and MFC will still land no sooner than in June. Personal thanks to Baptiste because you picked up the problem so quickly! Michael