From nobody Wed May 22 14:38:01 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Vkv6d3v9Bz5LqJc; Wed, 22 May 2024 14:38:01 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Vkv6d37w8z4JDb; Wed, 22 May 2024 14:38:01 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1716388681; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=MedQFDT7nmV3FN7g45YK3QhNW/3qPxLC1w4nLI5tqCI=; b=O/56Jvlbc9yb3e/xHGmosiygaLIv0GppQ2r4KaVHETP+xgofQe+gP9a6UJxdRXbIx1rtoR PvzyuUrpEltR7DXgdY0Oy3adI4vEGfS2662/n4Zhyw+obUGEom//sCqLYFywM3XEK9Yu0s BmTiAWCJzqdOkHYsnPdqc2+n2E9usJWbYoonYz9hSxAT5PQAPyAK1yRecHV+727CWnneJu wCT8lZ6M81uP0JsnBPPez/UKL9pc522L2kJmRXqe1bB8OtP58/vsSAUeAXSSSAC7HWImJM 7DCbuQjK+bAt9e6RgHo43Wt4q7hAw4HYShKErfl32g009vuS1Ff/6KTbWV7jIA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1716388681; a=rsa-sha256; cv=none; b=sLrEdbcr/mGPpi0n1E9GcFqYdHtHRWf1wZHvZqCMtRHV+oUkR7tFc6XTLAQWYVmxOaIaJe QUr3VhCp9lGK4x9g/Xah3KRg/H6nHY2ziqUNtGBLKj8Ru6yGRga9XIyF442kppNE/LdD+N h5MbOvA2E/SLFLXh1cPfbgB3LsK6Pw9Zu3wl2/12T8E3aaksDSn2OowPhcR1u9seYvzPR7 RJKWHKUELv7z2bu11Pc6cFXqrDClSciY6n/wTaReWAj5hSyDPw3trxkplSjJpI521D4MEn +9o3Dl8/3EeNezZggfLKR8UCOrBoStrpZGjQTFA21vTOY3GONdH7FeLsuRoqdg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1716388681; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=MedQFDT7nmV3FN7g45YK3QhNW/3qPxLC1w4nLI5tqCI=; b=Ms2Qcx39JlSd82P3iiO5f9OqAzLstpqXNMefe/M7kuwHGGMEMnNRoewpqk0XSp0P8u1YNS /o/M38tx5wCyuzfUa08nDPL3M83TTO9HTyarQyRwTZC1TJJQnmyO9UhqGIPo6mNNXV3JRE xrKud9kWPto4JSQUFWXD7KlNCnwPaxUZP3UcTCHX8Hig+0qfsrH3sEO2+BDKH8yjUclRjq +3cJ9tmzfzJFwI59z6cgwcWSza4B1mo0JbNuaJ8H38BSbqkF3xSJueSEaJaMTRLkgHc3JN 6cLLfj9qXAP7V7WUP3dP6cckShMrvOXKV9fIk0QBprQHUDRGcBcEubSbgrWydA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Vkv6d2lfMz18dV; Wed, 22 May 2024 14:38:01 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 44MEc1x7019763; Wed, 22 May 2024 14:38:01 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 44MEc1gn019760; Wed, 22 May 2024 14:38:01 GMT (envelope-from git) Date: Wed, 22 May 2024 14:38:01 GMT Message-Id: <202405221438.44MEc1gn019760@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Warner Losh Subject: git: f9c67a0f203f - stable/14 - devctl: Disable the boottime optimization of suppressing NOMATCH List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: imp X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: f9c67a0f203fe3bf4fa83f38bcd5963ea568142d Auto-Submitted: auto-generated The branch stable/14 has been updated by imp: URL: https://cgit.FreeBSD.org/src/commit/?id=f9c67a0f203fe3bf4fa83f38bcd5963ea568142d commit f9c67a0f203fe3bf4fa83f38bcd5963ea568142d Author: Warner Losh AuthorDate: 2024-05-18 13:07:16 +0000 Commit: Warner Losh CommitDate: 2024-05-22 14:37:58 +0000 devctl: Disable the boottime optimization of suppressing NOMATCH The usb bus code (uhub) doens't present the same information to devctl as it does to the NOMATCH events it generats. As such, devmatch fails to find USB devices on boot when NOMATCH events are optimized out. Since the savings of boot time is relatively trivial for all but the most demanding boot environments, disable it by default until this issue is fixed. Fixes: 6437872c1d66 MFC After: 1 minute Sponsored by: Netflix (cherry picked from commit 97aedd3395b4e9b017e29823096771aff0835ff0) --- sys/kern/kern_devctl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/kern/kern_devctl.c b/sys/kern/kern_devctl.c index 0dd05a49c9ad..602b82105525 100644 --- a/sys/kern/kern_devctl.c +++ b/sys/kern/kern_devctl.c @@ -89,7 +89,7 @@ static int sysctl_devctl_queue(SYSCTL_HANDLER_ARGS); static int devctl_queue_length = DEVCTL_DEFAULT_QUEUE_LEN; SYSCTL_PROC(_hw_bus, OID_AUTO, devctl_queue, CTLTYPE_INT | CTLFLAG_RWTUN | CTLFLAG_MPSAFE, NULL, 0, sysctl_devctl_queue, "I", "devctl queue length"); -static bool nomatch_enabled = false; +static bool nomatch_enabled = true; SYSCTL_BOOL(_hw_bus, OID_AUTO, devctl_nomatch_enabled, CTLFLAG_RWTUN, &nomatch_enabled, 0, "enable nomatch events");