From nobody Fri May 17 21:41:39 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Vh0lq1WbVz5K8f0; Fri, 17 May 2024 21:41:43 +0000 (UTC) (envelope-from bz@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Vh0lq15WTz4Q2G; Fri, 17 May 2024 21:41:43 +0000 (UTC) (envelope-from bz@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1715982103; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=XNG5+I3Dd3kfNjLnrhvPkwv13SQUdpDEe7hC+pIRmKU=; b=AnxKtMYS/fem2xzORNBbJHRFwinZ/eJ7+HBbzS9k/LDN58YAmT3keehTyjwfhV6b1xn1uH HpKj20A4nbiLKG+bIQsxRA6sY9RcHFEqMyniwwZqPlLZ17pHzMg+6KR+aEW4A33cc6oljE Glpp8AMpukkzSt2jw3vh+H6IzZjsjevSDOr2swBVkqQT+jUdjKAuLGs6kX6mte5Q1E+f1u qyod7lkmBVvH5+2NH2Z9XF4SNz/6w+k5+KTS8UnIkEJJ/IT1X96fV9RgCtwDz7ybYezp2N HrvciR+Bj7/YfN31S2L7QR1rAjr4AXSFGiRNbzDog4sIaB/j7tFdd8pbOCZorg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1715982103; a=rsa-sha256; cv=none; b=FaKAkelp8NbxckvcOVsVN7R01s+nQ8O1NFoP+rp/M6Ke2KhfDhVd9Bxed+BxnoYryN72sh EyYBReMzoU2FANgKngoLPMkvLK7sV0EoqQXar/brNfOH2K6DtmqWcB/eqR4EshPZ5LptpJ uMcs6f2tl8HgJUUeOU4ZTQ8f9hCmhlHBsXIoH9pBU3YJZOytNcdU8JfKzwEJz7hOlzh29A bdXEB4/q4a7kNIHR1cDyJOq7JKZqzWSYrOdbHVHvtXCPab5+W/mSon9grjznciJzovhtzf +2WlKxu4WcJcLH79osVlR0D4qU1+TytFdDLTemkZCSGUry9coLoXILufLnuXGQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1715982103; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=XNG5+I3Dd3kfNjLnrhvPkwv13SQUdpDEe7hC+pIRmKU=; b=HGKoXjBeWmnyApyL6B4vJ90wO/qdNLwN24mOJk7Hh8+pgDzLE+GfIINB/sqAxjfPBge4rw 1IkBHPlOtMdBQreNGJqUHqrzQ3t82JonWgM6MntxR0cMkqnfhB0TKZVR00q/i1gWRcVete K1rkvLiU2RcdlKSoEdlUlkMCBYR9HhLy38dyPxaU40hOkPWEifiBcAHCRLgvWP1IvJTizX mK2iBddG/tBPdR/awvuvoymxYULOyBh+9pPWqYcBzeeLPRaWZ35bm/zcycKx5cOsEaC7Vv /OYlGHkwf8ACwrTXR0BWK1n3p8VQblCpOzkI0P26loO8k+KdPHO6GED6OpMlFQ== Received: from mx1.sbone.de (mx1.sbone.de [IPv6:2a01:4f8:13b:39f::9f:25]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mx1.sbone.de", Issuer "SBone.DE Root Certificate Authority" (not verified)) (Authenticated sender: bz/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4Vh0lq01HdzNlk; Fri, 17 May 2024 21:41:42 +0000 (UTC) (envelope-from bz@FreeBSD.org) Received: from mail.sbone.de (mail.sbone.de [IPv6:fde9:577b:c1a9:4902:0:7404:2:1025]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.sbone.de (Postfix) with ESMTPS id 977AB8D4A127; Fri, 17 May 2024 21:41:41 +0000 (UTC) Received: from content-filter.t4-02.sbone.de (content-filter.t4-02.sbone.de [IPv6:fde9:577b:c1a9:4902:0:7404:2:2742]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.sbone.de (Postfix) with ESMTPS id D50AC2D029D9; Fri, 17 May 2024 21:41:40 +0000 (UTC) X-Virus-Scanned: amavisd-new at sbone.de Received: from mail.sbone.de ([IPv6:fde9:577b:c1a9:4902:0:7404:2:1025]) by content-filter.t4-02.sbone.de (content-filter.t4-02.sbone.de [IPv6:fde9:577b:c1a9:4902:0:7404:2:2742]) (amavisd-new, port 10024) with ESMTP id 33rDm7sIxwep; Fri, 17 May 2024 21:41:39 +0000 (UTC) Received: from strong-iwl0.sbone.de (strong-iwl0.sbone.de [IPv6:fde9:577b:c1a9:4902:b66b:fcff:fef3:e3d2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.sbone.de (Postfix) with ESMTPSA id E69212D029D2; Fri, 17 May 2024 21:41:39 +0000 (UTC) Date: Fri, 17 May 2024 21:41:39 +0000 (UTC) From: "Bjoern A. Zeeb" To: Emmanuel Vadot cc: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: Re: git: cff79fd02636 - main - linuxkpi: Fix spin_lock_init In-Reply-To: <202405170559.44H5xD7d019861@gitrepo.freebsd.org> Message-ID: <720nrnro-51n7-5669-o85o-p0rsr44o5951@SerrOFQ.bet> References: <202405170559.44H5xD7d019861@gitrepo.freebsd.org> X-OpenPGP-Key-Id: 0x14003F198FEFA3E77207EE8D2B58B8F83CCF1842 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed On Fri, 17 May 2024, Emmanuel Vadot wrote: > The branch main has been updated by manu: > > URL: https://cgit.FreeBSD.org/src/commit/?id=cff79fd02636f34010d8b835cc9e55401fa76e74 > > commit cff79fd02636f34010d8b835cc9e55401fa76e74 > Author: Emmanuel Vadot > AuthorDate: 2024-05-17 04:52:53 +0000 > Commit: Emmanuel Vadot > CommitDate: 2024-05-17 05:58:59 +0000 > > linuxkpi: Fix spin_lock_init > > Some linux code re-init some spinlock so add MTX_NEW to mtx_init. Sorry, I should have realized during the review; we no longer run the memset(0) on them when (re-)initializing. > Reported by: David Wolfskill > Fixes: ae38a1a1bfdf ("linuxkpi: spinlock: Simplify code") > --- > sys/compat/linuxkpi/common/include/linux/spinlock.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sys/compat/linuxkpi/common/include/linux/spinlock.h b/sys/compat/linuxkpi/common/include/linux/spinlock.h > index 3f6eb4bb70f6..2992e41c9c02 100644 > --- a/sys/compat/linuxkpi/common/include/linux/spinlock.h > +++ b/sys/compat/linuxkpi/common/include/linux/spinlock.h > @@ -140,7 +140,7 @@ typedef struct mtx spinlock_t; > #define spin_lock_name(name) _spin_lock_name(name, __FILE__, __LINE__) > > #define spin_lock_init(lock) mtx_init(lock, spin_lock_name("lnxspin"), \ > - NULL, MTX_DEF | MTX_NOWITNESS) > + NULL, MTX_DEF | MTX_NOWITNESS | MTX_NEW) > > #define spin_lock_destroy(_l) mtx_destroy(_l) As mentioned elsewhere; it is funny this exists^^^ -- Bjoern A. Zeeb r15:7