From nobody Fri May 17 16:36:32 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Vgszj1dYbz5LQmF; Fri, 17 May 2024 16:36:33 +0000 (UTC) (envelope-from brooks@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Vgszh6Jnrz4VfF; Fri, 17 May 2024 16:36:32 +0000 (UTC) (envelope-from brooks@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1715963792; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=c9FiHzRE71lWJv+LaG1EPCBHMzW2UW/xBNnCZjVpfRw=; b=PekSOc1MdDc9lQ4tl0b9w51bo3J9GFT3Cehz+oTG32iw6ZLiCzVGfJvkmyhPtm6TyoJk87 gJYspVMZ2s067lIdKaztpFUL+RqHzt0yq/FBYiaYH4hYDRMnhd3IGFacnSr4agtcjRb4K3 RCsxJmQt5qQBfGhO1+iTF5cWU+0LBefcsPYFw8u5OzVniq7FObefetnw3Afzq5jilOAeUz YZ0duUiFA7oyuTt0D7/0Rcr386CoZA1vj5G5wZABwZJtE2p+3qTeRNV3g2U3zOg0h1C557 hQU+XCPm/4gL2Z/bLIfS9z25LHg0VNfFayXFea/YPeZXJCKBku5MTZj95WWA9Q== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1715963792; a=rsa-sha256; cv=none; b=SV1HN/MDzYfOC+hIZW9BLSow9y/Owc+f3mlGfcFOiT8N9+0gbO0L/0S74DP6m14zBvqqIl Zjvpf8p4TFgF0WZqfuLv1FlvP2toJItpNEcOAP1nrS8Oudqw/QROzuXXRNW5acFYU1d+oL hAMDsMs59dNsqa6/2NT19JEC9Sz3qzOirQtWVAdI8eMVdhhKqHa1JrtDTdszRtqpDy6MID IzLLouBuTIpmlUmgGMXUMCr6BhA9cgChQ8dJQ7GKGtNp4z7J7qIWN3lQlVuQxzcoUsjImn kYYu2MLtRu+SRKaTAy/6I5+LxQ2uEQi0GdhSlWcYKvM0slyFq4xZSmiLa3/GhA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1715963792; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=c9FiHzRE71lWJv+LaG1EPCBHMzW2UW/xBNnCZjVpfRw=; b=x1EfQQiW0MWL5mI8Qnpyzh0Wb2LrZ5t2T+ms+F2ciEVey7Gmkw6cwb3geioxZwxTFPKW1A c9o2Pl+Z41EVaPhw2w6B14hrS89XcUiJ1Gd19xVtkTNZhOqgKzt8SdrKD4mRA/tzDsyRcj igqGe+n4MA/Lv/90LsUPtqb1dn0cadwSstzE0Hchz0SvKyU8bq8WDOixh9ksYqW5nC5AHX P8UYsOnuuyPB7xCug2zT10Cb2lrZiML4LP71NO7H6M4nyBwQyMSiCQdHadMPcjRuwowRCi k8ZgwPgWbfA3q+FqANTkOmN/ThzjjavhaJWu3oqYJlSUMp6yuwvLL3GMhPDOCg== Received: from spindle.one-eyed-alien.net (spindle.one-eyed-alien.net [199.48.129.229]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) (Authenticated sender: brooks/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4Vgszh5d1szGyL; Fri, 17 May 2024 16:36:32 +0000 (UTC) (envelope-from brooks@freebsd.org) Received: by spindle.one-eyed-alien.net (Postfix, from userid 3001) id 85C853C019B; Fri, 17 May 2024 16:36:32 +0000 (UTC) Date: Fri, 17 May 2024 16:36:32 +0000 From: Brooks Davis To: John Baldwin Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 16d8dfde0c0f - main - aarch64: disable LIB32 with gcc Message-ID: References: <202405171601.44HG1RH4047215@gitrepo.freebsd.org> <55ef7d2e-e01b-42a2-acc9-b7351b1aa1f2@FreeBSD.org> List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <55ef7d2e-e01b-42a2-acc9-b7351b1aa1f2@FreeBSD.org> On Fri, May 17, 2024 at 09:12:17AM -0700, John Baldwin wrote: > On 5/17/24 9:01 AM, Brooks Davis wrote: > > The branch main has been updated by brooks: > > > > URL: https://cgit.FreeBSD.org/src/commit/?id=16d8dfde0c0fb2eb95f2dd8c350ae652fa2c68fa > > > > commit 16d8dfde0c0fb2eb95f2dd8c350ae652fa2c68fa > > Author: Brooks Davis > > AuthorDate: 2024-05-17 15:47:06 +0000 > > Commit: Brooks Davis > > CommitDate: 2024-05-17 16:01:18 +0000 > > > > aarch64: disable LIB32 with gcc > > gcc doesn't have -m32 support on aarch64 so mark LIB32 broken there. > > We have to check both COMPILER_TYPE and X_COMPILER_TYPE becuase > > X_COMPILER_TYPE is only conditionally set and COMPILER_TYPE is the host > > compiler in Makefile.inc1. > > Reviewed by: emaste > > Differential Revision: https://reviews.freebsd.org/D45089 > > --- > > share/mk/src.opts.mk | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/share/mk/src.opts.mk b/share/mk/src.opts.mk > > index 00405e3f934f..501df88cd776 100644 > > --- a/share/mk/src.opts.mk > > +++ b/share/mk/src.opts.mk > > @@ -303,7 +303,7 @@ __DEFAULT_YES_OPTIONS+=LLDB > > __DEFAULT_NO_OPTIONS+=LLDB > > .endif > > # LIB32 is not supported on all 64-bit architectures. > > -.if (${__T} == "amd64" || ${__T:Maarch64*} != "" || ${__T} == "powerpc64") > > +.if (${__T:Maarch64*} != "" && ((defined(X_COMPILER_TYPE) && ${X_COMPILER_TYPE} != "gcc") || (!defined(X_COMPILER_TYPE) && ${COMPILER_TYPE} != "gcc"))) || ${__T} == "amd64" || ${__T} == "powerpc64" > > __DEFAULT_YES_OPTIONS+=LIB32 > > .else > > BROKEN_OPTIONS+=LIB32 > > I'd rather fix the compiler port? aarch64 still doesn't build world at all > (though might build some more after Andrew's commits today). I'd meant to include a reference to the bug I filed on the issue which discusses possible solutions. I personally don't care enough about 32-bit arm to spend more time on this though. https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=278879 -- Brooks