From nobody Fri May 17 16:14:46 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4VgsVc0PFRz5LPgM; Fri, 17 May 2024 16:14:48 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4VgsVb6vdjz4RQG; Fri, 17 May 2024 16:14:47 +0000 (UTC) (envelope-from jhb@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1715962488; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=H8H7+of1KMkBG359D6AZt0OJ4YuIwMDR8u32qzO1K4I=; b=vJAM1qZNO/q2S3HW1XkulnwDPAzi+rU2HG4VjcAkMqqj/h/zURC2s4epw8UikZ/7ccUkjD 2yE6M1Z0tXkhD1pSNtSfkNyEU4iVU117/4LQrqECNlEa22RtyRVNj+y0pV6sQ4uhku+r0U tCZGqGyiY3SUQ7cUSZwFuMFHJN4IqW5rBz8K28Hun6cl33a3hZYrDMnlLYKNs+WvVgjmvW ad/HrOURn+p7G2a2mLaIHDIAhjBodH4aAP+QqHrv5EVgd0vroRDfNPa6ctkRAS3Uc+JnUY xnHYgJW0gECrcG1K4RToSwT8zzvM6mFkP6azQz0Mg81zxw99v/hJVNK7EYSPOA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1715962488; a=rsa-sha256; cv=none; b=V+J9nFePZZi2XzTuZQJ+JJ0JTjenbBFU4JBYMxK1Dap43kUHiXirskhyxnNjBAzbAJNgcv Bz00oGjCPtjvKS2Rt6vPEQ98VovOwfxrtLxGc0+0r6/kcvqDXxOVZ8hzUXhm9lYu515W5s r5BqdZKu/DAk0H56dR9OrrBzxP24JyBJuy23uaY4sgFELBe+r0jlDS/upoatjTNCZztJVJ lTSu9fZ/AUjhYGJgEtq2s3TnbXozEuLfotWIQSThliCZdw60ydrtGnSvBUNqrtdNDwWFBB /eNNdlL6ncB/wUehRY9xy5zNI0/+reMb6StgXTndCCzlz2tnSk8WJ51VzqRvFg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1715962488; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=H8H7+of1KMkBG359D6AZt0OJ4YuIwMDR8u32qzO1K4I=; b=GA7mCwH7uzyaM7tT2+An35PNf5iNUbJfaa8NtpIY3j74Ng7BWxLfQeqRerlNCdpMKZB/J6 zRFQRq117T3e0jK2VOci/GWQh/9WXNYSP9dO0zdvZGwQiJSzXoqKWngVemlS7crzCQl1d3 KisewagMV+jxYLP+UAVAvrnjQ3NKXUSZGa048QQwvo6VOGFXwtIlvlUEQ5sSm5tYIRnUek ngK9NGqz077aO8V75AxzkziDnjw8gIYkFMojPJ4D1F6A1cKtXbIku3d32PZ4JEZeeIVPaU TjCLpOMqBQMYy0plhVRZlEeTRbkVN/2qR7jGKVH9ZG1RlC5/GnF2+JzQzyeEHg== Received: from [IPV6:2601:644:937f:4c50:b5f7:9ebf:56fb:a04d] (unknown [IPv6:2601:644:937f:4c50:b5f7:9ebf:56fb:a04d]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id 4VgsVb3FqRzHdt; Fri, 17 May 2024 16:14:47 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Message-ID: <456e4eef-e194-4e32-b3a7-c93bb941b82b@FreeBSD.org> Date: Fri, 17 May 2024 09:14:46 -0700 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: git: 4c0dfd5959bd - main - arm: fail early on gcc builds Content-Language: en-US To: Brooks Davis , src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org References: <202405171601.44HG1Sef047261@gitrepo.freebsd.org> From: John Baldwin In-Reply-To: <202405171601.44HG1Sef047261@gitrepo.freebsd.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 5/17/24 9:01 AM, Brooks Davis wrote: > The branch main has been updated by brooks: > > URL: https://cgit.FreeBSD.org/src/commit/?id=4c0dfd5959bd499754e3fc9a7ce37c1d5ece31f7 > > commit 4c0dfd5959bd499754e3fc9a7ce37c1d5ece31f7 > Author: Brooks Davis > AuthorDate: 2024-05-17 15:47:22 +0000 > Commit: Brooks Davis > CommitDate: 2024-05-17 16:01:19 +0000 > > arm: fail early on gcc builds > > Since at least 2022 (see https://reviews.freebsd.org/D36754), it has > not been possible to build armv6/armv7 with gcc due to atomics macros > gcc doesn't like. Prevent developers doing due diligance from wasting > time and CPU cycles on this combination as it just fails to build in > libc. > > Reviewed by: imp, andrew > Differential Revision: https://reviews.freebsd.org/D45193 As I said in the review, this is a weird change. Only amd64 and i386 build with GCC. You should blacklist all the others if you are going to blacklist any, not just 32-bit arm. I hadn't blacklisted any to make it possible for other developers to work on it. Also, the review in question is probably not the right fix, it's probably that we need to pass different CFLAGS to GCC for 32-bit arm. -- John Baldwin