From nobody Wed May 15 17:21:26 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Vfg4Q6PdCz49wMN; Wed, 15 May 2024 17:21:26 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Vfg4Q5ymgz4fWy; Wed, 15 May 2024 17:21:26 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1715793686; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=8bBnbuh+RJm5PdjgcJgwxFV+CMYjI8/k14j78aXLLOQ=; b=ULSCwjZCkuIRwL9nk+aVBlUqGjHBfxylhXX8HOQwH3G1g3/7m1b1Onnp2Q4Y/aoexAXJ5r ViBFs6o0Wb/ZGcHMsYq+vQRkDuG8LCpPM3fWqVfqZKPkFHVdBxL50vMGu24BY92jEE7/Lt pAwllhZsn68B8iLS1ni73kKcq47PZxXdLagTxvgAlnJgXkq0igt5A2AtmDWK9OEBS1itW9 qUIbrvHJjRV4K4K2mn3ludk5xekIOwUl9wPNnsYeU/4lOPGl5jAe3ojCbRPfxASM6nGDDu TrQKgtBNlFgIbN8GeOR92aKpHT6ti5//2UXKs+QIbS7wuki+qe9oiXny1KQShA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1715793686; a=rsa-sha256; cv=none; b=iNA+YcjPRnLjI5O6tqOKUh7NJ6J10Z2S4gcay/BXA17LYJB6wF7WUP83w6IRIK7T1+oW9a P6iewzrfui70SMOihc7mb8Ls/0AlqKvG0JHfEB7T3E3ZwMT7xFBKed+/Wq9/uw7aPKaERx o8ne1xW7F77P/f9g6sWoh1V5cD40fWg+XIaZ5Z9Jx8aLrAQ8HVEVLJmJjkNPc+8CL6bgzw Zr2WLuV6OqPJfCwB1TJR7bDTiYr3nPgclfcjKTbBg19kqCc+87Ty5aNMJJercU11laCGvC zv8ElHRjZzJaynFyDeqtX1rWN3Xn/ycu+SDImFR4OiZX/xq4mekdMbpJeVzNTg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1715793686; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=8bBnbuh+RJm5PdjgcJgwxFV+CMYjI8/k14j78aXLLOQ=; b=wM42kwmHuUGiypSgIqciP6l9iUNGvAkPuk5hezO2nmIE+P/XLiiQv1VeNh3hCKDNDZD5XA VNwAnm005n7SrO9x1KrW5O3FeslLnTCH9WJgQ4EkWfPcrCliqs37uLVq/ELlcUjLdPxsYz DSxhnMdfgKspUVxtXhidVq/GblLyQtaMPE1iKfM3BkX/IK1KqNeimyCF+F9AmBGp5PPRO/ 4SKo6rzSVooPbmjKGolP22s03hlZuJVFA3Rm7ksU1bs3hzI3kuV8/NXBaYBlve9HUPPiAL EmBCth9BalgCREQs5Yalb3imxXUzUAXoGxctgPpunRvQaocxUdwHV6IdpQoXjQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Vfg4Q5ZJ8zP1N; Wed, 15 May 2024 17:21:26 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 44FHLQMm003815; Wed, 15 May 2024 17:21:26 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 44FHLQcc003812; Wed, 15 May 2024 17:21:26 GMT (envelope-from git) Date: Wed, 15 May 2024 17:21:26 GMT Message-Id: <202405151721.44FHLQcc003812@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Ed Maste Subject: git: 18119e711f1c - stable/14 - Increase IOAPIC_MAX_ID to 255 (from 254) List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: emaste X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: 18119e711f1c844bd6eacf5afc8d4cdec3ac8085 Auto-Submitted: auto-generated The branch stable/14 has been updated by emaste: URL: https://cgit.FreeBSD.org/src/commit/?id=18119e711f1c844bd6eacf5afc8d4cdec3ac8085 commit 18119e711f1c844bd6eacf5afc8d4cdec3ac8085 Author: Ed Maste AuthorDate: 2024-05-10 17:40:59 +0000 Commit: Ed Maste CommitDate: 2024-05-15 17:21:14 +0000 Increase IOAPIC_MAX_ID to 255 (from 254) A test system provided by AMD panicked with "madt_parse_apics: I/O APIC ID 255 too high". I/O APIC ID 255 is acceptable, so increase the limit. Reviewed by: jhb, kib Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D45157 (cherry picked from commit 4e3286818327453efd8e4c133928ba26a169567a) --- sys/x86/include/apicvar.h | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/sys/x86/include/apicvar.h b/sys/x86/include/apicvar.h index 10016e291b9b..ac6a82659e34 100644 --- a/sys/x86/include/apicvar.h +++ b/sys/x86/include/apicvar.h @@ -78,7 +78,12 @@ #define MAX_APIC_ID 0x800 #define APIC_ID_ALL 0xffffffff -#define IOAPIC_MAX_ID xAPIC_MAX_APIC_ID +/* + * The 0xff ID is used for broadcast IPIs for local APICs when not using + * x2APIC. IPIs are not sent to I/O APICs so it's acceptable for an I/O APIC + * to use that ID. + */ +#define IOAPIC_MAX_ID 0xff /* I/O Interrupts are used for external devices such as ISA, PCI, etc. */ #define APIC_IO_INTS (IDT_IO_INTS + 16)