From nobody Mon May 13 22:38:31 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4VdZCD2583z5L4wt; Mon, 13 May 2024 22:38:32 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4VdZCC6PHtz41k1; Mon, 13 May 2024 22:38:31 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1715639911; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=hswMvZFoQ4s7u2rIB9+CfPYv3BZGuettlMk5uC/mRhA=; b=WpZv7jEgqtViOUwFPh21Vh6UEIWbsKzVVrfC4hb5QdwzKdIlTs4rLV/g5bzyv3i87Y0LQP mFjmHGc1b/K4c04YzyxpDxEEubkdlujhay2Ry44fYP5bsHBoHtnGs4Q0yJoKkLH3XAA/uv SaW74d48GRCViQxZTZvWV+XIli7rSb7XL84xWh8xhAaF9i2B+RK5gzIkID//v7/4ZUVB89 OzXMoBBTMnFv+MGkDhXSV7u8VgzoChZoNFTgd+0fu/GrBLlLXKaYbY0M+mTuzU4I4EvXYf 0x+mcrtIyfzIYttwG5vBX3fHrEYZHgL0Oz8KuNXtiRwcsk1qnh66PWV5SeQ8yQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1715639911; a=rsa-sha256; cv=none; b=ZmoJgxolZVz38h2qkhcVedotJEW8YyiRGkBrRT3i5lF2NuHW/kQ6eSwvQ/Zw/W/NthA6cG zPjBCKh91eXhDACgepiEbZskPBLw2t2jMkGI8VVgjt9KQpiOaHOXV9JO+1MAXiT7dd9n8q oGBNHWYZtTFVMGLNF3S3jftsoyeQxkO1hqKTiMs/1R58EmFnxdGIwmsEOp10tkF4p1Y4bV zkx+YGnoMwh7AwL91muR8ZVtW1Vv/l5K/yQ/8vb8GQzuDM1bC1ewC5ThbHoLCEH8DcaPJD edAPaTNpeGdkG+5lE5kNDoq14Qa2xROzeYLxJsRnDCt0UYHhtXoSs5CJ/KRy7Q== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1715639911; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=hswMvZFoQ4s7u2rIB9+CfPYv3BZGuettlMk5uC/mRhA=; b=e2VzJqEoqc5FFd8m3CgYAI+rUz/FWC+Gbql3ZZo4DhtAPnHyklFwAfBV1xk8M21/O1BUgQ WKrBGXfNinGECGENcxHecoII/0psjSKcwHMNXgdrz4Ii0V1Sx/J06YClehSSejr1fXXrpi J44gr7LxtrOoHEOLXEY0HM05azoxYDjLvTK2jbJVBRkyYsRKD+8qsJRLahxx9DZ5a0onFU VucVmh0E2lCf+Y7sLbONZ+ngzlD5V4CGqOoFbqRmU3PpGtN/Yml6sSlx8D93VBmKlm+Qab jqduR5dCdkea5ifrOxNbLMQy4b7bSRgq3TiziBwyY9vd4RDqboQdvzx70oYjhQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4VdZCC61cKz15fN; Mon, 13 May 2024 22:38:31 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 44DMcVq3058336; Mon, 13 May 2024 22:38:31 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 44DMcVoN058333; Mon, 13 May 2024 22:38:31 GMT (envelope-from git) Date: Mon, 13 May 2024 22:38:31 GMT Message-Id: <202405132238.44DMcVoN058333@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Warner Losh Subject: git: 0dd84c3b117a - main - nvme: Add comment about where tr->deadline is set List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: imp X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 0dd84c3b117a01fdcac9a2f665fb156a2e358dfa Auto-Submitted: auto-generated The branch main has been updated by imp: URL: https://cgit.FreeBSD.org/src/commit/?id=0dd84c3b117a01fdcac9a2f665fb156a2e358dfa commit 0dd84c3b117a01fdcac9a2f665fb156a2e358dfa Author: Warner Losh AuthorDate: 2024-05-13 21:58:59 +0000 Commit: Warner Losh CommitDate: 2024-05-13 22:14:04 +0000 nvme: Add comment about where tr->deadline is set It's easy to overlook the chain of events that lead to tr->deadline being updated. Add a comment here to explain what otherwise looks like an oversight w/o careful study. Sponsored by: Netflix --- sys/dev/nvme/nvme_qpair.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/sys/dev/nvme/nvme_qpair.c b/sys/dev/nvme/nvme_qpair.c index 4c5d5f3c1ea7..5be6c151bbea 100644 --- a/sys/dev/nvme/nvme_qpair.c +++ b/sys/dev/nvme/nvme_qpair.c @@ -1315,6 +1315,11 @@ _nvme_qpair_submit_request(struct nvme_qpair *qpair, struct nvme_request *req) return; } + /* + * tr->deadline updating when nvme_payload_map calls + * nvme_qpair_submit_tracker (we call it above directly + * when there's no map to load). + */ err = bus_dmamap_load_mem(tr->qpair->dma_tag_payload, tr->payload_dma_map, &req->payload, nvme_payload_map, tr, 0); if (err != 0) {