From nobody Sun May 12 00:08:39 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4VcNJ81CTJz5Jb9p; Sun, 12 May 2024 00:08:40 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4VcNJ802q3z4tLQ; Sun, 12 May 2024 00:08:40 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1715472520; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=pMUh1y9pIVoFrRQjnMj++H1+8NbEljMTrFD1qxwlFvw=; b=L+OOlHsZXyU62YnZYyq4YCnUZtmfPp/w21xsx3TPE6yCa+duQNofohz+uTqDCqjK7OOaV9 f5CjuXRjWSZ/QJSZvax4FKlB5PvG0DwxwcSnrJdabzVGwdhEAg1fbrrPlM0e1uyBp0OM8t gbJrMOxt0cxE/ahU3IQEfOmnWbDTzk7PstBOivK0EtH28p5cPY46L2WlyohqvOZqw0ESGg mosusZuoE0mao0v52mS2PpD0prc1oR/9QmNJf3L46IcFBZpgZS3aJsXFLEbd5ydI0rlWv1 PGQ9pExypot8sMbPNWceTmPW9DIsn/Mkzq3UPVF6OaevyLzV5wfXNZ/UAmxPhA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1715472520; a=rsa-sha256; cv=none; b=ftJeQRtfMvpTEvOeAc4quCfMrABvl2yYSJh2c64wSSj9FeiZ5aw6KYlYPwNO21LFFgv43n y/4aK7myg7M3Z0iomA3JYaxNWl+UWl66G+uOkogBvOVj1Qx8Eicc3Il3B0hjpo0rmZZH97 NTxVOWdege/Wq6nvP3PMbSZWUv5JIMEX4PhCOwW3+KIm8g4O6LbnjriIZ/z+wn7i7FLQWT lzK6W/ZL7h3EDVeeTQW4ySXRMlT2+BZNdujfFWOnSQIWjyfXcIZHcvB2jjKsHomW6CbIGC rS+OI6eSuZZFiKoQvPSYE5rXighKHxPIuPfLqINVfryNCFCGWlMyiogndm0+xg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1715472520; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=pMUh1y9pIVoFrRQjnMj++H1+8NbEljMTrFD1qxwlFvw=; b=NSUuElH9vEvcDeU37SAqNhY7gZyNVY8zQbiyqcH+NFPVFCjZmbgwKhhCcprSdF8lp6OrZo Cb7/dXOWBZEBbqyOxq11M7jM4efb0tPi3+vuudUgahSWtC5BuRN3alPVHPvmX3gthlaZY8 98mPR28HOBGrUWxliZZJblMO77rT8wCYcPI6cboW/2lPOi3T2xJZynnvYQQ5bIS8xLT3wf n1WxEiD98QTmJ0BR6bEY+phDG51+TWC+gMvFVawz+vN6vpeg5qLC7hjC4wqpOtcL7LE4rV YD6lbahGmNtUM2RnVfANf+Osf+jecL6Y0rnyaPNwCR4tde+wgeU6Zwoz5Yrosw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4VcNJ74rNbzhsH; Sun, 12 May 2024 00:08:39 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 44C08dKb002336; Sun, 12 May 2024 00:08:39 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 44C08dnr002333; Sun, 12 May 2024 00:08:39 GMT (envelope-from git) Date: Sun, 12 May 2024 00:08:39 GMT Message-Id: <202405120008.44C08dnr002333@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Jake Freeland Subject: git: ba501a551776 - stable/14 - ktrace: Remove CAPFAIL from default trace points List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: jfree X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: ba501a551776bd101cd38ac2892bc900cf29da0a Auto-Submitted: auto-generated The branch stable/14 has been updated by jfree: URL: https://cgit.FreeBSD.org/src/commit/?id=ba501a551776bd101cd38ac2892bc900cf29da0a commit ba501a551776bd101cd38ac2892bc900cf29da0a Author: Jake Freeland AuthorDate: 2024-04-24 00:26:14 +0000 Commit: Jake Freeland CommitDate: 2024-05-11 23:57:44 +0000 ktrace: Remove CAPFAIL from default trace points The CAPFAIL tracepoint was recently extended to report ECAPMODE capability violations for processes that do not enter capability mode. This allows developers that are interested in Capsicumizing their programs to determine where violations are being raised. Previously, CAPFAIL only produced output for processes using Capsicum(4) capabilties. Thus, most ktrace users never received log output from the trace point. With the recent changes, this is no longer the case. Having this trace point enabled by default will produce output for all processes that use syscalls that are not permitted in capability mode. This may lead to confusion for users that are not familiar with the feature. Remove KTRFAC_CAPFAIL from ktrace's default points to avoid this. Approved by: markj (mentor) Reviewed by: markj MFC after: 1 month Differential Revision: https://reviews.freebsd.org/D44887 (cherry picked from commit f239db4800ee9e7ff8485f96b7a68e6c38178c3b) --- usr.bin/ktrace/ktrace.1 | 2 +- usr.bin/ktrace/ktrace.h | 7 +++---- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/usr.bin/ktrace/ktrace.1 b/usr.bin/ktrace/ktrace.1 index 764896b91f66..1b287af7a611 100644 --- a/usr.bin/ktrace/ktrace.1 +++ b/usr.bin/ktrace/ktrace.1 @@ -139,7 +139,7 @@ trace requests .It Cm + trace the default set of trace points - -.Cm c , i , n , p , s , t , u , y +.Cm c , i , n , s , t , u , y .El .It Ar command Execute diff --git a/usr.bin/ktrace/ktrace.h b/usr.bin/ktrace/ktrace.h index cecd0adc7321..1d96c6faa2b7 100644 --- a/usr.bin/ktrace/ktrace.h +++ b/usr.bin/ktrace/ktrace.h @@ -33,13 +33,12 @@ #define DEF_POINTS (KTRFAC_SYSCALL | KTRFAC_SYSRET | KTRFAC_NAMEI | \ KTRFAC_GENIO | KTRFAC_PSIG | KTRFAC_USER | \ - KTRFAC_STRUCT | KTRFAC_SYSCTL | KTRFAC_CAPFAIL | \ - KTRFAC_STRUCT_ARRAY) + KTRFAC_STRUCT | KTRFAC_SYSCTL | KTRFAC_STRUCT_ARRAY) #define PROC_ABI_POINTS (KTRFAC_PROCCTOR | KTRFAC_PROCDTOR) -#define ALL_POINTS (DEF_POINTS | KTRFAC_CSW | PROC_ABI_POINTS | \ - KTRFAC_FAULT | KTRFAC_FAULTEND) +#define ALL_POINTS (DEF_POINTS | KTRFAC_CAPFAIL | KTRFAC_CSW | \ + PROC_ABI_POINTS | KTRFAC_FAULT | KTRFAC_FAULTEND) #define DEF_TRACEFILE "ktrace.out"