From nobody Wed May 08 23:05:54 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4VZW363BQFz5KPpg; Wed, 08 May 2024 23:05:54 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4VZW362dyRz4cjd; Wed, 8 May 2024 23:05:54 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1715209554; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=CWTfyZ7th4h1qwNT//ZVsQvvsFnNyUYbRzUKl9HMuko=; b=IGXAhyYFvtkL7OJ+DoHKl2Vj9wQDopPAwbPN80Ox8dLspcYGW4EOQq4xITQz2+vhgyQim9 e2f65oB8dRkWeFDLX8UxQa1S07MBFqZQa4W16elMKaCBfAAd2NdRBsVmxKG1eczzzu5UeP asww2g08lfdfIQdBZ3qkauRvgtjircyNqNfcx1aqwGEWndY1aFh9Pjm5UHlcpLjLHakW6c 1xwrNIpkbyRCxiO4HjCjGP/YdmiZ1qCc2OnpL9DvJA0/BeQEitld8joU6ieNZu+KfXhXW+ Hc4dILwRdar7LNrGqZ7KwODuCXXZkzH9jEhLm08hD8ixYZZGT78Q5PkWWq7Msw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1715209554; a=rsa-sha256; cv=none; b=eyHJwGCXvMbQm/5TVa3wnJywUbmkgFS4TA2IL3uFwLqsqG1zpQeLXcN+LxkzLH1L0BkFLK 4RqsCAH7nVu2dzfgczKi8foAAeHnAfN+nKmGg55O1d/MO/Qm3FBJXhfSHTA+PUTa+cZ0AO WMfbG8keHLyFn5482z7i+vuV8uUNDgr05cZv8+IIx2KmlDPMYeKCAowkmvtgS5FKChXQfN nVU/vd0552YSFSCd4UdrGZ4HkKo2e67eTef0YxdDCVI4g1U/8dDcO8I4J0cutIZ3LkZ6Vo vckg7q7wE5tJVCy/2j7CSwQUtsLIjLBUt1981VeGna7Ub+e38jJfRRDq+SDDIg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1715209554; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=CWTfyZ7th4h1qwNT//ZVsQvvsFnNyUYbRzUKl9HMuko=; b=XEFix3K3AV5mqjAwVeHSw1z213OHp6DhpNAxe7/dyzh7Qr3B6+3pB0u2UtSnaMp4fuWqbp bsiJ+0NZqudS/4G0mEwYwtGweJpWhsLcA5QlYajy8qYQc/WRqFHLaGWE3LY4/q0WKh9v1w BWNRkFy5ZfLUzO0vNowTd2beLk6UOqZlcle6kIFQ4TNkhjGDEjPjDJ7CP0VqAPjdOZjJkO sT4jgoEJ6j1FmXsrrvlh8V0JZom5E55YWSAWb4p54Uih8iHFAt5BsRpQIeeep6Fkic8dW+ YC/Lo92qwV/t1m8ialFlKk/q3O9t0jdC25BhSwhGSb7zXTzI9Z+nPn578LyIug== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4VZW361vjhzkh3; Wed, 8 May 2024 23:05:54 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 448N5suv095262; Wed, 8 May 2024 23:05:54 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 448N5sK5095259; Wed, 8 May 2024 23:05:54 GMT (envelope-from git) Date: Wed, 8 May 2024 23:05:54 GMT Message-Id: <202405082305.448N5sK5095259@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: John Baldwin Subject: git: ebcfab998e63 - main - nvme: Explicitly align struct nvme_command on an 8 byte boundary List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: jhb X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: ebcfab998e631fa7e29e1c0694868d745fc085ee Auto-Submitted: auto-generated The branch main has been updated by jhb: URL: https://cgit.FreeBSD.org/src/commit/?id=ebcfab998e631fa7e29e1c0694868d745fc085ee commit ebcfab998e631fa7e29e1c0694868d745fc085ee Author: John Baldwin AuthorDate: 2024-05-08 23:05:39 +0000 Commit: John Baldwin CommitDate: 2024-05-08 23:05:39 +0000 nvme: Explicitly align struct nvme_command on an 8 byte boundary This was already true for most architectures due to uint64_t structure members. However, i386 is special in that it only requires 4 byte alignment for uint64_t. As a result, casts from struct nvme_command to struct nvmf_fabric_cmd were raising a "cast increases alignment" warning on i386. Explicitly aligning struct nvme_command pacifies this warning on i386. Reported by: rscheff Sponsored by: Chelsio Communications --- sys/dev/nvme/nvme.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/dev/nvme/nvme.h b/sys/dev/nvme/nvme.h index 6ef7a2bd8aad..bca4df92cb25 100644 --- a/sys/dev/nvme/nvme.h +++ b/sys/dev/nvme/nvme.h @@ -832,7 +832,7 @@ struct nvme_command { uint32_t cdw13; /* command-specific */ uint32_t cdw14; /* command-specific */ uint32_t cdw15; /* command-specific */ -}; +} __aligned(8); _Static_assert(sizeof(struct nvme_command) == 16 * 4, "bad size for nvme_command");